Skip to content

[Due for payment 2025-04-30] [$250] DEV- Requester -> Payer section goes missing from payed money request preview after logging out and logging back in #59688

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aldo-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Do a manual request from userA to userB
  2. Make userB mark the request as paid elsewhere
  3. The request from userA's perspective should look like the screenshot (there is a section userA -> userB )
  4. Log out userA and log back in
  5. Go to the money request preview

Expected Result:

Requester -> Payer section displayed after user login

Actual Result:

Requester -> Payer section not displayed after user login

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909642168327029806
  • Upwork Job ID: 1909642168327029806
  • Last Price Increase: 2025-04-08
  • Automatic offers:
    • dominictb | Reviewer | 106873214
    • nkdengineer | Contributor | 106873215
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 4, 2025
  2. melvin-bot commented on Apr 4, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Apr 4, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. dominictb commented on Apr 8, 2025

    @dominictb
    Contributor

    I can reproduce with the steps provided in OP:

    Image

    @adelekennedy Please assign me as C+ as per this Slack post.

  5. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 8, 2025
  7. melvin-bot commented on Apr 8, 2025

    @melvin-bot
  8. changed the title [-]DEV- Requester -> Payer section goes missing from payed money request preview after logging out and logging back in[/-] [+][$250] DEV- Requester -> Payer section goes missing from payed money request preview after logging out and logging back in[/+] on Apr 8, 2025
  9. 22 remaining items

  10. changed the title [-][$250] DEV- Requester -> Payer section goes missing from payed money request preview after logging out and logging back in[/-] [+][Due for payment 2025-04-30] [$250] DEV- Requester -> Payer section goes missing from payed money request preview after logging out and logging back in[/+] on Apr 23, 2025
  11. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.31-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-30. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    @dominictb @adelekennedy @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. adelekennedy commented on Apr 30, 2025

    @adelekennedy
    Contributor

    Payment Summary

    Contributor: @nkdengineer paid $250 via Upwork
    Contributor+: @dominictb paid $250 via Upwork

  15. adelekennedy commented on Apr 30, 2025

    @adelekennedy
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  16. adelekennedy commented on Apr 30, 2025

    @adelekennedy
    Contributor

    Payment made - just checklist above

  17. dominictb commented on May 5, 2025

    @dominictb
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other: Reported on development

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/57614/files#r2073860760

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • tableReportView beta enabled

    Test:

    1. Submit an expense on WS chat
    2. Verify that on WS chat, the money request preview doesn't show From/To fields
    3. Do a manual request from userA to userB in DM
    4. Make userB mark the request as paid elsewhere
    5. Verify From/To fields show in money request preview
    6. Log out userA and log back in
    7. Go to the money request preview
    8. Verify From/To fields show in money request preview

    Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNeeds ReproductionReproducible steps needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions