You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-14] [$50] Flaky tests/ui/GroupChatNameTests.tsx test #59729
Please re-state the problem that we are trying to solve in this issue.
The test "Should show only 5 names with ellipsis when there are 8 participants in the report header" is failing because it cannot find the sidebar links.
What is the root cause of that problem?
The sidebar links are not fully rendered before the test checks for them.
What changes do you think we should make in order to solve the problem?
Add a waitFor() block to ensure the test waits for the sidebar links to render before checking.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Ensure tests wait for elements to render before checking.
What alternative solutions did you explore? (Optional)
@dangrous, it's not the same test cases we solve here. Should show only 5 names with ellipsis when there are 8 participants in the report header but the same solution can be applied to this issue. Let me know if you want to hire me there .
Activity
[-]Flaky tests/ui/GroupChatNameTests.tsx test[/-][+][$250] Flaky tests/ui/GroupChatNameTests.tsx test[/+]melvin-bot commentedon Apr 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021909223705099006673
melvin-bot commentedon Apr 7, 2025
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)[-][$250] Flaky tests/ui/GroupChatNameTests.tsx test[/-][+][$50] Flaky tests/ui/GroupChatNameTests.tsx test[/+]melvin-bot commentedon Apr 7, 2025
Upwork job price has been updated to $50
mountiny commentedon Apr 7, 2025
@nkdengineer might be interested
ahmdshrif commentedon Apr 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The test "Should show only 5 names with ellipsis when there are 8 participants in the report header" is failing because it cannot find the sidebar links.
What is the root cause of that problem?
The sidebar links are not fully rendered before the test checks for them.
What changes do you think we should make in order to solve the problem?
Add a
waitFor()block to ensure the test waits for the sidebar links to render before checking.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
setTimeout(not reliable).melvin-bot commentedon Apr 14, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
39 remaining items
mananjadhav commentedon May 13, 2025
This would be ready for payout tomorrow. It was about fixing flaky test so no checklist needed.
VictoriaExpensify commentedon May 14, 2025
Thanks for the note @mananjadhav - always appreciated when there is no checklist
VictoriaExpensify commentedon May 14, 2025
@ahmdshrif - an offer has been sent but still needs to be accepted by you. Let me know once accepted and I'll process the payment
VictoriaExpensify commentedon May 14, 2025
Payment Summary:
C+: @mananjadhav owed $50 via NewDot
ahmdshrif commentedon May 14, 2025
@VictoriaExpensify done
VictoriaExpensify commentedon May 15, 2025
Updated payment summary:
C: @ahmdshrif paid $50 via Upwork
C+: @mananjadhav owed $50 via NewDot
garrettmknight commentedon May 20, 2025
$50 approved for @mananjadhav
dangrous commentedon Jul 1, 2025
Hi, it looks like these tests are still flaky - should we open a new issue for them? https://github.com/Expensify/App/actions/runs/15983163235/job/45081956645
ahmdshrif commentedon Jul 3, 2025
@dangrous, it's not the same test cases we solve here.
Should show only 5 names with ellipsis when there are 8 participants in the report headerbut the same solution can be applied to this issue. Let me know if you want to hire me there .dangrous commentedon Jul 3, 2025
ah okay cool - you're welcome to submit a proposal on the new issue if you like! #65357