Skip to content

[Due for payment 2025-05-14] [$50] Flaky tests/ui/GroupChatNameTests.tsx test #59729

Closed

Description

@mountiny

Flaky Group chat test:

Tests for group chat name › Should show only 5 names with ellipsis when there are 8 participants in the report header

The run is here https://github.com/Expensify/App/actions/runs/14309102159/job/40099599877

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909223705099006673
  • Upwork Job ID: 1909223705099006673
  • Last Price Increase: 2025-04-28
  • Automatic offers:
    • ahmdshrif | Contributor | 107112896
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 7, 2025
  2. changed the title [-]Flaky tests/ui/GroupChatNameTests.tsx test[/-] [+][$250] Flaky tests/ui/GroupChatNameTests.tsx test[/+] on Apr 7, 2025
  3. melvin-bot commented on Apr 7, 2025

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 7, 2025
  5. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  7. changed the title [-][$250] Flaky tests/ui/GroupChatNameTests.tsx test[/-] [+][$50] Flaky tests/ui/GroupChatNameTests.tsx test[/+] on Apr 7, 2025
  8. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    Upwork job price has been updated to $50

  9. mountiny commented on Apr 7, 2025

    @mountiny
    ContributorAuthor

    @nkdengineer might be interested

  10. ahmdshrif commented on Apr 7, 2025

    @ahmdshrif
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The test "Should show only 5 names with ellipsis when there are 8 participants in the report header" is failing because it cannot find the sidebar links.

    What is the root cause of that problem?

    The sidebar links are not fully rendered before the test checks for them.

    What changes do you think we should make in order to solve the problem?

    Add a waitFor() block to ensure the test waits for the sidebar links to render before checking.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    1. Ensure tests wait for elements to render before checking.

    What alternative solutions did you explore? (Optional)

    1. Adding delays with setTimeout (not reliable).
  11. melvin-bot commented on Apr 14, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  12. 39 remaining items

  13. mananjadhav commented on May 13, 2025

    @mananjadhav
    Collaborator

    This would be ready for payout tomorrow. It was about fixing flaky test so no checklist needed.

  14. VictoriaExpensify commented on May 14, 2025

    @VictoriaExpensify
    Contributor

    Thanks for the note @mananjadhav - always appreciated when there is no checklist

  15. VictoriaExpensify commented on May 14, 2025

    @VictoriaExpensify
    Contributor

    @ahmdshrif - an offer has been sent but still needs to be accepted by you. Let me know once accepted and I'll process the payment

  16. VictoriaExpensify commented on May 14, 2025

    @VictoriaExpensify
    Contributor

    Payment Summary:
    C+: @mananjadhav owed $50 via NewDot

  17. ahmdshrif commented on May 14, 2025

    @ahmdshrif
    Contributor
  18. VictoriaExpensify commented on May 15, 2025

    @VictoriaExpensify
    Contributor

    Updated payment summary:
    C: @ahmdshrif paid $50 via Upwork
    C+: @mananjadhav owed $50 via NewDot

  19. garrettmknight commented on May 20, 2025

    @garrettmknight
    Contributor

    $50 approved for @mananjadhav

  20. dangrous commented on Jul 1, 2025

    @dangrous
    Contributor

    Hi, it looks like these tests are still flaky - should we open a new issue for them? https://github.com/Expensify/App/actions/runs/15983163235/job/45081956645

  21. ahmdshrif commented on Jul 3, 2025

    @ahmdshrif
    Contributor

    @dangrous, it's not the same test cases we solve here. Should show only 5 names with ellipsis when there are 8 participants in the report header but the same solution can be applied to this issue. Let me know if you want to hire me there .

  22. dangrous commented on Jul 3, 2025

    @dangrous
    Contributor

    ah okay cool - you're welcome to submit a proposal on the new issue if you like! #65357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions