Skip to content

[$250] Merge account - Long email is cut off on magic code page #59757

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.24-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #56911
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Settings > Security
  3. Tap Merge account
  4. Enter long email
  5. Mark "I understand this is not reversible" checkbox
  6. Click Next

Expected Result:

The long email will be wrapped into two lines

Actual Result:

The long email is cut off

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6795521_1744068702443.ScreenRecording_04-08-2025_07-29-36_1.1.mp4

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909751045190760799
  • Upwork Job ID: 1909751045190760799
  • Last Price Increase: 2025-04-08
  • Automatic offers:
    • dominictb | Reviewer | 106853268
Issue OwnerCurrent Issue Owner: @allroundexperts

Activity

  1. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Apr 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. daledah commented on Apr 8, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The long email is cut off

    What is the root cause of that problem?

    We don't add style word-break: 'break-word'

    What changes do you think we should make in order to solve the problem?

    We should add word-break: 'break-word' to cover case very long email

    <View>
    <Text style={[styles.mb3]}>
    {translate('mergeAccountsPage.accountValidate.lossOfUnsubmittedData')}
    <Text style={styles.textStrong}>{email}</Text>.
    </Text>
    <Text>
    {translate('mergeAccountsPage.accountValidate.enterMagicCode')}
    <Text style={styles.textStrong}>{email}</Text>.
    </Text>
    </View>

    descriptionStyle={{...descriptionStyle, ...styles.textSupporting}}

    Image

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. daledah commented on Apr 8, 2025

    @daledah
    Contributor

    @marcaaron i can help to raise a quick PR if needed

  6. jasperhuangg commented on Apr 8, 2025

    @jasperhuangg
    Contributor

    Yeahh this doesn't need to be a blocker, I can't remember the last time I saw a customer with such a long email address.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 8, 2025
  8. removed their assignment
    on Apr 8, 2025
  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 8, 2025
  10. 2 remaining items

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 8, 2025
  12. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

  13. dominictb commented on Apr 9, 2025

    @dominictb
    Contributor

    This is straightforward. @daledah proposal LGTM

    🎀👀🎀 C+ reviewed

  14. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  15. amyevans commented on Apr 9, 2025

    @amyevans
    Contributor

    @allroundexperts looks like you're fixing this in a polish PR, yeah? I'll assign you. Also, please comment on any other Merge Account polish issues you plan to take so that you can be assigned, our internal engineers have varying levels of awareness of what features are in progress, who's working on what, etc. Thanks!

  16. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 9, 2025
  17. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  18. allroundexperts commented on Apr 9, 2025

    @allroundexperts
    Contributor

    I am working on this!

  19. added
    ReviewingHas a PR in review
    and removed on Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions