Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.24-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #59718
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Apple iPhone 12 Pro / iOS 18.4
App Component: Other
Action Performed:
- Navigate to https://staging.new.expensify.com/
- Incognito window: Log in with a new Gmail account using Chrome Incognito
- Normal window: Log in with the same account using Chrome normal window
- Incognito window: Create a workspace
- Incognito window: Navigate to Workspace settings - More features
- Incognito window: Enable "Accounting"
- Incognito window: Navigate to Workspace settings - Accounting
- Incognito window: Connect to Sage Intacct with invalid credentials and stop when "Can’t connect to Sage Intacct due to an authentication error." appears
- Normal window: Navigate to the workspace chat
- Normal window: Create a manual expense with any amount
- Normal window: Submit the expense
- Normal window: Approve the expense
- Normal window: Pay the expense "Elsewhere"
Expected Result:
The button should only appear if a connection is established.
Actual Result:
"Export to Sage Intacct" button appears while Sage Intacct is in authentication error state.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6795789_1744098849264.bandicam_2025-04-08_09-44-21-992.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021909909773376613538
- Upwork Job ID: 1909909773376613538
- Last Price Increase: 2025-04-16
- Automatic offers:
- mkzie2 | Contributor | 107005426
Activity
melvin-bot commentedon Apr 8, 2025
Triggered auto assignment to @flaviadefaria (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Apr 8, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-08 13:29:28 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Accounting - Export to Sage Intacct appears while Sage is in authentication error
What is the root cause of that problem?
We are getting the
connectedIntegrationeven if there is connection errorApp/src/components/ReportActionItem/ReportPreview.tsx
Line 470 in c53e6a9
What changes do you think we should make in order to solve the problem?
We should add a check here
hasAuthenticationErrorand updateshouldShowExportIntegrationButtonhere
App/src/components/ReportActionItem/ReportPreview.tsx
Line 472 in c53e6a9
if there is a connection error then return undefined
We should do the same on
MoneyReportHeaderWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
we can use this function to get the AuthenticationError and prevent ExportIntegration button on header and report preview.
App/src/libs/actions/connections/index.ts
Line 353 in c53e6a9
to get the
AuthenticationErrorthen use inshouldShowExportIntegrationButtonReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
samranahm commentedon Apr 8, 2025
Proposal updated
Added alternative solution
mkzie2 commentedon Apr 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Export to Sage Intacct" button appears while Sage Intacct is in authentication error state.
What is the root cause of that problem?
The export button is always shown if the
connectedIntegrationexists. If we enter invalid credentail,connectedIntegrationis not empty but has no data.App/src/components/ReportActionItem/ReportPreview.tsx
Line 472 in c102d5c
What changes do you think we should make in order to solve the problem?
This bug is also happening on
MoneyReportHeader. I think the best way is we can create a util likegetValidConnectedIntegration, this function will return the valid connection (the connection doesn't have authentication error or other conditions that we can ensure is a valid connected integration).And then we can use it here and here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
This is a minor UI bug, so I don't think we need to add the test.
What alternative solutions did you explore? (Optional)
We can fix this case by case by adding
!isAuthenticationErrorchecking toshouldShowExportIntegrationButtonApp/src/components/MoneyReportHeader.tsx
Line 312 in c102d5c
App/src/components/ReportActionItem/ReportPreview.tsx
Line 472 in c102d5c
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Accounting - Export to Sage Intacct appears while Sage is in authentication error[/-][+][$250] Accounting - Export to Sage Intacct appears while Sage is in authentication error[/+]melvin-bot commentedon Apr 9, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021909909773376613538
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)flaviadefaria commentedon Apr 9, 2025
Added the
externallabel.ishpaul777 commentedon Apr 14, 2025
reviewing tmrw
32 remaining items
[-][$250] Accounting - Export to Sage Intacct appears while Sage is in authentication error[/-][+][Due for payment 2025-05-28] [$250] Accounting - Export to Sage Intacct appears while Sage is in authentication error[/+]melvin-bot commentedon May 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 21, 2025
@allroundexperts @flaviadefaria @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
flaviadefaria commentedon May 28, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
flaviadefaria commentedon May 28, 2025
@allroundexperts can you please fill out the checklist above so that I can proceed to payment? Thanks!
flaviadefaria commentedon May 29, 2025
Friendly bump here @allroundexperts :)
allroundexperts commentedon Jun 1, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/44170/files#r2119551532
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/506901
Regression Test Proposal
Precondition:
Test:
Verify Export to Sage Intacct button does not show in the report header
Do we agree 👍 or 👎
flaviadefaria commentedon Jun 2, 2025
Payment Summary
@allroundexperts requires payment through NewDot Manual Requests - $250
@mkzie2 requires payment automatic offer (Contributor) - $250 (paid)
JmillsExpensify commentedon Jun 13, 2025
$250 approved for @allroundexperts