You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-05] [$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar #59948
Version Number: 9.1.25-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+780473@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Search
Action Performed:
Precondition:
Log in with Expensifail account.
Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense to the workspace chat.
Go to Reports.
Go to Expense Reports.
Click on the expense report from Step 3.
Send a user mention who is not a member of the expense report.
Refresh the page if whisper does not show up.
Expected Result:
Invite user whisper is accompanied by Concierge user name and avatar.
Actual Result:
Invite user whisper is missing Concierge user name and avatar.
🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 18:39:20 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Invite user whisper is missing Concierge user name and avatar
What is the root cause of that problem?
We will display a message as group (hide sender, because we assume the messages are consecutive and from the same user) if cannot find the next consecutive action:
Note that, "next" here means the above message in display order, because messages are displayed in reverse order. In this case, the nextAction for the actionable message should be the first message with index 0 (the mention message). But we cannot find it because the loop here stops at 1 (i >0):
That means any message appears in the second place will hide sender. For example, if another user sends a message here, its sender would be hidden as well even though the first message sender and the second's are not the same.
What changes do you think we should make in order to solve the problem?
Update the loop condition to be i >= 0.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
changed the title [-]Expense Reports - Invite user whisper is missing Concierge user name and avatar[/-][+][$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/+]on Apr 15, 2025
changed the title [-][$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/-][+][Due for payment 2025-05-05] [$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/+]on Apr 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.32-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@s77rt@greg-schroeder@s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, I think the missed condition is not something that could resurface again
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.gijoe0295 commentedon Apr 9, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 18:39:20 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Invite user whisper is missing Concierge user name and avatar
What is the root cause of that problem?
We will display a message as group (hide sender, because we assume the messages are consecutive and from the same user) if cannot find the next consecutive action:
App/src/libs/ReportActionsUtils.ts
Lines 667 to 668 in 17615a1
App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx
Lines 290 to 292 in 11a424a
Note that, "next" here means the above message in display order, because messages are displayed in reverse order. In this case, the
nextActionfor the actionable message should be the first message with index 0 (the mention message). But we cannot find it because the loop here stops at 1 (i >0):App/src/libs/ReportActionsUtils.ts
Lines 586 to 587 in 17615a1
That means any message appears in the second place will hide sender. For example, if another user sends a message here, its sender would be hidden as well even though the first message sender and the second's are not the same.
What changes do you think we should make in order to solve the problem?
Update the loop condition to be
i >= 0.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
gijoe0295 commentedon Apr 15, 2025
@greg-schroeder Can you take a look?
[-]Expense Reports - Invite user whisper is missing Concierge user name and avatar[/-][+][$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/+]melvin-bot commentedon Apr 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021912140453301034956
melvin-bot commentedon Apr 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)s77rt commentedon Apr 15, 2025
@gijoe0295 Can you still reproduce the bug? The expense chat loads in RHP in my case (maybe we reverted a PR?)
I think this is unintended, this comment states that we would return
falsebuttrueis returned insteadApp/src/libs/ReportActionsUtils.ts
Lines 666 to 670 in 316a0d1
21 remaining items
[-][$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/-][+][Due for payment 2025-05-05] [$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/+]melvin-bot commentedon Apr 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.32-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 28, 2025
@s77rt @greg-schroeder @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
s77rt commentedon May 5, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Better Expense Reports] Add MoneyRequestReportView #58360 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No, I think the missed condition is not something that could resurface again
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
greg-schroeder commentedon May 6, 2025
Was OOO for the bank holiday yesterday, processing today
greg-schroeder commentedon May 6, 2025
Payment summary:
Contributor: @gijoe0295 - $250 - Paid via Upwork
C+: @s77rt - $250 - ND Manual Request
No regression test required per C+, closing
JmillsExpensify commentedon May 13, 2025
$250 approved for @s77rt