Skip to content

[Due for payment 2025-05-05] [$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar #59948

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.25-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+780473@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense to the workspace chat.
  4. Go to Reports.
  5. Go to Expense Reports.
  6. Click on the expense report from Step 3.
  7. Send a user mention who is not a member of the expense report.
  8. Refresh the page if whisper does not show up.

Expected Result:

Invite user whisper is accompanied by Concierge user name and avatar.

Actual Result:

Invite user whisper is missing Concierge user name and avatar.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021912140453301034956
  • Upwork Job ID: 1912140453301034956
  • Last Price Increase: 2025-04-15
  • Automatic offers:
    • gijoe0295 | Contributor | 106949048
Issue OwnerCurrent Issue Owner: @greg-schroeder

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 9, 2025
  2. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. gijoe0295 commented on Apr 9, 2025

    @gijoe0295
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 18:39:20 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Invite user whisper is missing Concierge user name and avatar

    What is the root cause of that problem?

    We will display a message as group (hide sender, because we assume the messages are consecutive and from the same user) if cannot find the next consecutive action:

    if (!currentAction || !nextAction) {
    return true;

    const displayAsGroup =
    !isConsecutiveChronosAutomaticTimerAction(visibleReportActions, index, chatIncludesChronosWithID(reportAction?.reportID)) &&
    hasNextActionMadeBySameActor(visibleReportActions, index);

    Image

    Note that, "next" here means the above message in display order, because messages are displayed in reverse order. In this case, the nextAction for the actionable message should be the first message with index 0 (the mention message). But we cannot find it because the loop here stops at 1 (i >0):

    function findNextAction(reportActions: ReportAction[], actionIndex: number): OnyxEntry<ReportAction> {
    for (let i = actionIndex - 1; i > 0; i--) {

    That means any message appears in the second place will hide sender. For example, if another user sends a message here, its sender would be hidden as well even though the first message sender and the second's are not the same.

    What changes do you think we should make in order to solve the problem?

    Update the loop condition to be i >= 0.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  4. gijoe0295 commented on Apr 15, 2025

    @gijoe0295
    Contributor

    @greg-schroeder Can you take a look?

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 15, 2025
  6. changed the title [-]Expense Reports - Invite user whisper is missing Concierge user name and avatar[/-] [+][$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/+] on Apr 15, 2025
  7. melvin-bot commented on Apr 15, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 15, 2025
  9. melvin-bot commented on Apr 15, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  10. s77rt commented on Apr 15, 2025

    @s77rt
    Member

    @gijoe0295 Can you still reproduce the bug? The expense chat loads in RHP in my case (maybe we reverted a PR?)

    because we assume the messages are consecutive and from the same user) if cannot find the next consecutive action

    I think this is unintended, this comment states that we would return false but true is returned instead

    // It's OK for there to be no previous action, and in that case, false will be returned
    // so that the comment isn't grouped
    if (!currentAction || !nextAction) {
    return true;
    }

  11. 21 remaining items

  12. changed the title [-][$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/-] [+][Due for payment 2025-05-05] [$250] Expense Reports - Invite user whisper is missing Concierge user name and avatar[/+] on Apr 28, 2025
  13. melvin-bot commented on Apr 28, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Apr 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.32-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-05. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Apr 28, 2025

    @melvin-bot

    @s77rt @greg-schroeder @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. s77rt commented on May 5, 2025

    @s77rt
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [Better Expense Reports] Add MoneyRequestReportView #58360 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: n/a

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      Bug requires regression test: No, I think the missed condition is not something that could resurface again

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  17. greg-schroeder commented on May 6, 2025

    @greg-schroeder
    Contributor

    Was OOO for the bank holiday yesterday, processing today

  18. greg-schroeder commented on May 6, 2025

    @greg-schroeder
    Contributor

    Payment summary:

    Contributor: @gijoe0295 - $250 - Paid via Upwork
    C+: @s77rt - $250 - ND Manual Request

    No regression test required per C+, closing

  19. JmillsExpensify commented on May 13, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @s77rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions