You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-23] [Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly #59979
Version Number: 9.1.26-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sdsoidsj@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.4 App Component: Search
Action Performed:
Precondition:
Log in with Expensifail account.
Launch Expensify app.
Submit a few expenses to the workspace chat.
Go to Settings > Troubleshoot.
Tap Clear cache and restart.
Tap Reset and refresh.
Go to Reports.
Tap on the bookmark icon > Chats.
Expected Result:
Expense preview will not load infinitely.
The skeleton loading on the expense preview will be positioned correctly.
Actual Result:
Expense preview loads infinitely.
The skeleton loading on the expense preview is not positioned correctly.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I've changed the skeleton layout in this PR and it was merged 10 hours ago, so it's probably not a case anymore. I hadn't seen this issue, so I'll add to the PR description that this problem is addressed to avoid confusion.
changed the title [-][Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly[/-][+][Due for payment 2025-04-23] [Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly[/+]on Apr 16, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@johncschuster@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 10, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 10, 2025
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 10, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 10, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
luacmartins commentedon Apr 10, 2025
This view is under a beta, so NAB. cc @mountiny @wildan-m @allgandalf
13 remaining items
wildan-m commentedon Apr 11, 2025
Can't reproduce the layout issue, but the infinite loading can be resolved by using the useOnyx wrapper
#60088
JakubKorytko commentedon Apr 11, 2025
I've changed the skeleton layout in this PR and it was merged 10 hours ago, so it's probably not a case anymore. I hadn't seen this issue, so I'll add to the PR description that this problem is addressed to avoid confusion.
melvin-bot commentedon Apr 14, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mountiny commentedon Apr 14, 2025
Regreassion testing will be handled as part of the project and there is no payment to issue here so we can close
[-][Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly[/-][+][Due for payment 2025-04-23] [Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly[/+]melvin-bot commentedon Apr 16, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 16, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 16, 2025
@allgandalf @johncschuster @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]