Skip to content

[Due for payment 2025-04-23] [Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly #59979

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.26-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Search

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Launch Expensify app.
  2. Submit a few expenses to the workspace chat.
  3. Go to Settings > Troubleshoot.
  4. Tap Clear cache and restart.
  5. Tap Reset and refresh.
  6. Go to Reports.
  7. Tap on the bookmark icon > Chats.

Expected Result:

  • Expense preview will not load infinitely.
  • The skeleton loading on the expense preview will be positioned correctly.

Actual Result:

  • Expense preview loads infinitely.
  • The skeleton loading on the expense preview is not positioned correctly.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6797769_1744254357338.ScreenRecording_04-10-2025_11-02-56_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 10, 2025
  2. melvin-bot commented on Apr 10, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 10, 2025

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 10, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 10, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. luacmartins commented on Apr 10, 2025

    @luacmartins
    Contributor

    This view is under a beta, so NAB. cc @mountiny @wildan-m @allgandalf

  7. 13 remaining items

  8. wildan-m commented on Apr 11, 2025

    @wildan-m
    Contributor

    Can't reproduce the layout issue, but the infinite loading can be resolved by using the useOnyx wrapper

    #60088

  9. JakubKorytko commented on Apr 11, 2025

    @JakubKorytko
    Member

    Can't reproduce the layout issue

    I've changed the skeleton layout in this PR and it was merged 10 hours ago, so it's probably not a case anymore. I hadn't seen this issue, so I'll add to the PR description that this problem is addressed to avoid confusion.

  10. melvin-bot commented on Apr 14, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. mountiny commented on Apr 14, 2025

    @mountiny
    Contributor

    Regreassion testing will be handled as part of the project and there is no payment to issue here so we can close

  12. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon Apr 14, 2025
  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 16, 2025
  14. changed the title [-][Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly[/-] [+][Due for payment 2025-04-23] [Better Expense Report View] Expense preview loads infinitely and skeleton loading is not positioned correctly[/+] on Apr 16, 2025
  15. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Guccio163 does not require payment (Contractor)
    • @allgandalf requires payment (Needs manual offer from BZ)
  17. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    @allgandalf @johncschuster @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions