Skip to content

[Due for payment 2025-05-27] Expense - Empty message row after moving report in offline mode #60251

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.28-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace.
  3. Enable Delayed submissions in Workflows if it is not enabled by default.
  4. Go to workspace chat.
  5. Go offline.
  6. Submit an expense.
  7. Click Submit on the expense preview.
  8. Submit another expense.
  9. Click on the expense preview of the first expense in Step 6.
  10. Click Report.
  11. Select another report.

Expected Result:

There will be no empty message row after moving the expense report.

Actual Result:

There is an empty message row after moving the expense report.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 15, 2025
  2. melvin-bot commented on Apr 15, 2025

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 15, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Apr 15, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 15, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nkdengineer commented on Apr 15, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There is an empty message row after moving the expense report.

    What is the root cause of that problem?

    The old iou action is changed to a deleted add comment with an empty message then an empty message row is displayed in offline

    {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${oldReportID}`,
    value: {
    [oldIOUAction.reportActionID]: {
    actionName: CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT,
    originalMessage: {
    deleted: DateUtils.getDBTime(),
    },
    message: [
    {
    deleted: DateUtils.getDBTime(),
    type: CONST.REPORT.MESSAGE.TYPE.TEXT,

    What changes do you think we should make in order to solve the problem?

    We can change the message to Deleted expense

    {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${oldReportID}`,
    value: {
    [oldIOUAction.reportActionID]: {
    actionName: CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT,
    originalMessage: {
    deleted: DateUtils.getDBTime(),
    },
    message: [
    {
    deleted: DateUtils.getDBTime(),
    type: CONST.REPORT.MESSAGE.TYPE.TEXT,

    Or we can add shouldShow flag as false here and filter out the reportAction with shouldShow false here

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. nkuoch commented on Apr 15, 2025

    @nkuoch
    Contributor

    cc @waterim @rayane-d @luacmartins this deploy blocker seems to be linked to Implement ChangeTransactionsReport ?

  8. rayane-d commented on Apr 15, 2025

    @rayane-d
    Contributor
  9. 26 remaining items

  10. melvin-bot commented on May 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on May 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-27. 🎊

    For reference, here are some details about the assignees on this issue:

    • @waterim does not require payment (Contractor)
    • @rayane-d requires payment through NewDot Manual Requests
    • @ishpaul777 requires payment through NewDot Manual Requests
  12. melvin-bot commented on May 20, 2025

    @melvin-bot

    @rayane-d / @ishpaul777 @strepanier03 @rayane-d / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on May 27, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @waterim is from an agency-contributor and not due payment
    • Reviewer: @rayane-d owed $250 via NewDot
    • Reviewer: @ishpaul777 owed $250 via NewDot

    BugZero Checklist (@strepanier03)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. strepanier03 commented on May 27, 2025

    @strepanier03
    Contributor

    I'll check back later for the checklist.

  15. strepanier03 commented on May 28, 2025

    @strepanier03
    Contributor

    @rayane-d @ishpaul777 - Can one of you handle the checklist so I can finish up the payment summary?

  16. ishpaul777 commented on May 29, 2025

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/58597/files#r2114721847

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: not CRITICAL, was a edge case from new feature

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. not recomended, was one time edge case from a new feature

  17. ishpaul777 commented on May 29, 2025

    @ishpaul777
    Contributor

    all done!@strepanier03

  18. strepanier03 commented on May 29, 2025

    @strepanier03
    Contributor

    Payment summary

  19. strepanier03 commented on May 29, 2025

    @strepanier03
    Contributor

    @rayane-d and @ishpaul777 - Payment summary above, I'm going to close this but feel free to put in the request.

  20. ishpaul777 commented on May 29, 2025

    @ishpaul777
    Contributor

    I think its only me, i took over the review while @rayane-d was away (slack)

  21. garrettmknight commented on Jun 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions