You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-27] Expense - Empty message row after moving report in offline mode #60251
Version Number: 9.1.28-1 Reproducible in staging?: Yes Reproducible in production?: Unable to check, new feature If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sdsoidsj@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Create a workspace.
Enable Delayed submissions in Workflows if it is not enabled by default.
Go to workspace chat.
Go offline.
Submit an expense.
Click Submit on the expense preview.
Submit another expense.
Click on the expense preview of the first expense in Step 6.
Click Report.
Select another report.
Expected Result:
There will be no empty message row after moving the expense report.
Actual Result:
There is an empty message row after moving the expense report.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Or we can add shouldShow flag as falsehere and filter out the reportAction with shouldShow false here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rayane-d / @ishpaul777@strepanier03@rayane-d / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not CRITICAL, was a edge case from new feature
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. not recomended, was one time edge case from a new feature
Activity
melvin-bot commentedon Apr 15, 2025
Triggered auto assignment to @nkuoch (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 15, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 15, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 15, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nkdengineer commentedon Apr 15, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is an empty message row after moving the expense report.
What is the root cause of that problem?
The old iou action is changed to a deleted add comment with an empty message then an empty message row is displayed in offline
App/src/libs/actions/Transaction.ts
Lines 668 to 680 in 6d6628c
What changes do you think we should make in order to solve the problem?
We can change the message to
Deleted expenseApp/src/libs/actions/Transaction.ts
Lines 668 to 680 in 6d6628c
Or we can add
shouldShowflag asfalsehere and filter out thereportActionwithshouldShowfalse hereWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nkuoch commentedon Apr 15, 2025
cc @waterim @rayane-d @luacmartins this deploy blocker seems to be linked to Implement ChangeTransactionsReport ?
rayane-d commentedon Apr 15, 2025
Discussing in https://expensify.slack.com/archives/C01GTK53T8Q/p1744712146580769
26 remaining items
melvin-bot commentedon May 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 20, 2025
@rayane-d / @ishpaul777 @strepanier03 @rayane-d / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 27, 2025
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
strepanier03 commentedon May 27, 2025
I'll check back later for the checklist.
strepanier03 commentedon May 28, 2025
@rayane-d @ishpaul777 - Can one of you handle the checklist so I can finish up the payment summary?
ishpaul777 commentedon May 29, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/58597/files#r2114721847
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not CRITICAL, was a edge case from new feature
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. not recomended, was one time edge case from a new feature
ishpaul777 commentedon May 29, 2025
all done!@strepanier03
strepanier03 commentedon May 29, 2025
Payment summary
strepanier03 commentedon May 29, 2025
@rayane-d and @ishpaul777 - Payment summary above, I'm going to close this but feel free to put in the request.
ishpaul777 commentedon May 29, 2025
I think its only me, i took over the review while @rayane-d was away (slack)
garrettmknight commentedon Jun 3, 2025
$250 approved for @ishpaul777