Skip to content

[Due for payment 2025-05-27] Avoid unnecessary SearchForReports calls #60336

Closed

Description

@mountiny

Problem

Coming from here, @martasudol discovered that we are calling the SearchForReports API that is used in the Chat switched to fetch reports also in other actions on the Reports (search) page. This is unnecessary as the results of the API are not used and it breaks out 1:1:1 philosophy

Solution

Avoid calling this extra API call when its not needed

Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 16, 2025
  2. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

  3. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. mountiny commented on Apr 16, 2025

    @mountiny
    ContributorAuthor

    Making this one HIGH as its influencing performance but not that much

  5. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    @martasudol Huh... This is 4 days overdue. Who can take care of this?

  6. melvin-bot commented on Apr 22, 2025

    @melvin-bot

    @martasudol Huh... This is 4 days overdue. Who can take care of this?

  7. mountiny commented on Apr 22, 2025

    @mountiny
    ContributorAuthor

    @martasudol how is this looking?

  8. 26 remaining items

  9. melvin-bot commented on May 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on May 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-27. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on May 20, 2025

    @melvin-bot

    @mountiny @laurenreidexpensify @martasudol The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. mountiny commented on May 20, 2025

    @mountiny
    ContributorAuthor

    This Pr is in production! @s77rt can you add a checklist here please?

  13. s77rt commented on May 20, 2025

    @s77rt
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other: Callstack
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Update SearchPageHeaderInput to display recent search and chats #53198 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: n/a

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      Bug requires regression test: No. I don't think this needs a regression test

  14. melvin-bot commented on May 27, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  15. s77rt commented on May 27, 2025

    @s77rt
    Member

    I require payment here. @mountiny can you please assign me

  16. laurenreidexpensify commented on May 27, 2025

    @laurenreidexpensify
    Contributor

    payment summary

    C+ s77rt please request payment in New Expensify $250

  17. JmillsExpensify commented on May 29, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @s77rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions