You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-27] Avoid unnecessary SearchForReports calls #60336
Coming from here, @martasudol discovered that we are calling the SearchForReports API that is used in the Chat switched to fetch reports also in other actions on the Reports (search) page. This is unnecessary as the results of the API are not used and it breaks out 1:1:1 philosophy
Solution
Avoid calling this extra API call when its not needed
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mountiny@laurenreidexpensify@martasudol The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No. I don't think this needs a regression test
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Apr 16, 2025
Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.
melvin-bot commentedon Apr 16, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mountiny commentedon Apr 16, 2025
Making this one HIGH as its influencing performance but not that much
melvin-bot commentedon Apr 21, 2025
@martasudol Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Apr 22, 2025
@martasudol Huh... This is 4 days overdue. Who can take care of this?
mountiny commentedon Apr 22, 2025
@martasudol how is this looking?
26 remaining items
melvin-bot commentedon May 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 20, 2025
@mountiny @laurenreidexpensify @martasudol The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny commentedon May 20, 2025
This Pr is in production! @s77rt can you add a checklist here please?
s77rt commentedon May 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Update SearchPageHeaderInput to display recent search and chats #53198 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Bug requires regression test: No. I don't think this needs a regression test
melvin-bot commentedon May 27, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
s77rt commentedon May 27, 2025
I require payment here. @mountiny can you please assign me
laurenreidexpensify commentedon May 27, 2025
payment summary
C+ s77rt please request payment in New Expensify $250
JmillsExpensify commentedon May 29, 2025
$250 approved for @s77rt