You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-28] [$250] No spacing for "Settings" in Spanish #60373
Version Number: v9.1.29-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: - Email or phone of affected tester (no customers):applausetester+en@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Macbook Pro 2023 / Sequoia 15.2 App Component: Chat Report View
Action Performed:
Open the ND app on Desktop
Sign in using expensifail account
Put app in Spanish and observe the "Settings" border
Expected Result:
Border should have valid padding
Actual Result:
When in Spanish, no spacing, the words are practically touching the division line
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Alternatively we could make use of smaller translations.
we could fall back to tooltip style. ie. remove bottom text and show only icons on the LHB and render tooltip on hover.
Follow the design doc and use account and Cuenta instead of settings and use workspace and Espacios for the workspace(workspace tab is yet to be built).
we could use tooltips for large screen and use labels for small screens.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@RachCHopkins@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: New requirement
Where bug was reported:
2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: New requirement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Apr 16, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 16, 2025
Triggered auto assignment to @chiragsalian (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 16, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 16, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nyomanjyotisa commentedon Apr 16, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 14:00:57 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
No spacing for "Settings" in Spanish on Left handbar
What is the root cause of that problem?
We set the
navigationTabBarSizeto 72 as the widthApp/src/styles/variables.ts
Line 101 in 0591b9c
What changes do you think we should make in order to solve the problem?
Based on this comment we should change the label to "Account"
So, create new translation under
commonAnd change the following to common.account`
App/src/pages/home/sidebar/NavigationTabBarAvatar.tsx
Line 71 in 717b77a
Or use the existing
accounttranslation instead of creating new oneAdditionally we can show a tooltip instead, and remove the current label for non mobile. But keep showing the label on mobile
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Set the
navigationTabBarSizeto 80, or any larger value as neededChavdaSachin commentedon Apr 16, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Left hand Navigation Bar is not wide enough to accommodate Spanish translation for 'Settings'
What is the root cause of that problem?
Left hand Navigation Bar is not wide enough.
What changes do you think we should make in order to solve the problem?
Change size here
App/src/styles/variables.ts
Line 101 in 0591b9c
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Alternatively we could make use of smaller translations.
we could fall back to tooltip style. ie. remove bottom text and show only icons on the LHB and render tooltip on hover.
Follow the design doc and use
accountandCuentainstead ofsettingsand useworkspaceandEspaciosfor the workspace(workspace tab is yet to be built).we could use tooltips for large screen and use labels for small screens.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
47 remaining items
melvin-bot commentedon Apr 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 21, 2025
@dukenv0307 @RachCHopkins @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dubielzyk-expensify commentedon Apr 22, 2025
Just wanted to say I agree with this for now 👍 Think we should make it obvious at this stage
dukenv0307 commentedon Apr 22, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: New requirement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/495508
Regression Test Proposal
Test:
Do we agree 👍 or 👎
dubielzyk-expensify commentedon Apr 23, 2025
Looks like we've introduced a bug here by making the translation
Accountin Engish as well. We only wanted to do this for Spanish.Can we fix this? cc @Expensify/design
dubielzyk-expensify commentedon Apr 23, 2025
Actually, @shawnborton pointed out that it might be changed for a different reason so I'm probably just wrong here 🤔
dannymcclain commentedon Apr 23, 2025
We want to change the name of that tab to
Accountin both English and Spanish—noted in the LHB design doc!RachCHopkins commentedon Apr 28, 2025
@shawnborton @dubielzyk-expensify @dannymcclain - can I pay this issue, or does it need to wait for this to be fixed? I can't tell, did this intro a bug or not?
dannymcclain commentedon Apr 28, 2025
@RachCHopkins I believe so - everything looks right on to me now.
RachCHopkins commentedon Apr 29, 2025
Payment Summary:
Upwork job here
RachCHopkins commentedon Apr 29, 2025
Contributor has been paid, the contract has been completed, and the Upwork post has been closed.
JmillsExpensify commentedon May 13, 2025
$250 approved for @dukenv0307