Skip to content

[Due for payment 2025-04-28] [$250] No spacing for "Settings" in Spanish #60373

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.29-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Chat Report View

Action Performed:

  1. Open the ND app on Desktop
  2. Sign in using expensifail account
  3. Put app in Spanish and observe the "Settings" border

Expected Result:

Border should have valid padding

Actual Result:

When in Spanish, no spacing, the words are practically touching the division line

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021912637774181540592
  • Upwork Job ID: 1912637774181540592
  • Last Price Increase: 2025-04-16
  • Automatic offers:
    • thelullabyy | Contributor | 106968119
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 16, 2025
  2. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 16, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nyomanjyotisa commented on Apr 16, 2025

    @nyomanjyotisa
    Member

    🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 14:00:57 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    No spacing for "Settings" in Spanish on Left handbar

    What is the root cause of that problem?

    We set the navigationTabBarSize to 72 as the width

    navigationTabBarSize: 72,

    What changes do you think we should make in order to solve the problem?

    Based on this comment we should change the label to "Account"

    So, create new translation under common

    //en
    account: 'Account',
    
    //es
    account: 'Cuenta',
    

    And change the following to common.account`

    {translate('common.settings')}

    Or use the existing account translation instead of creating new one

    Additionally we can show a tooltip instead, and remove the current label for non mobile. But keep showing the label on mobile

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Set the navigationTabBarSize to 80, or any larger value as needed

  7. ChavdaSachin commented on Apr 16, 2025

    @ChavdaSachin
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Left hand Navigation Bar is not wide enough to accommodate Spanish translation for 'Settings'

    What is the root cause of that problem?

    Left hand Navigation Bar is not wide enough.

    What changes do you think we should make in order to solve the problem?

    Change size here

    navigationTabBarSize: 72,

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    1. Alternatively we could make use of smaller translations.

    2. we could fall back to tooltip style. ie. remove bottom text and show only icons on the LHB and render tooltip on hover.

    3. Follow the design doc and use account and Cuenta instead of settings and use workspace and Espacios for the workspace(workspace tab is yet to be built).

    4. we could use tooltips for large screen and use labels for small screens.

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  8. 47 remaining items

  9. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-28. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    @dukenv0307 @RachCHopkins @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. dubielzyk-expensify commented on Apr 22, 2025

    @dubielzyk-expensify
    Contributor

    As clean as it looks without labels... I feel like we need labels for our customer base, just to make this insanely clear which tab does what.

    Just wanted to say I agree with this for now 👍 Think we should make it obvious at this stage

  12. dukenv0307 commented on Apr 22, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: New requirement

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: New requirement

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template

    Regression Test Proposal

    Test:

    1. Open the ND app on Desktop
    2. Put app in Spanish and observe the "Settings" border
    3. Verify the Tab title is 'Account' for English and 'Cuenta' for Spanish

    Do we agree 👍 or 👎

  13. dubielzyk-expensify commented on Apr 23, 2025

    @dubielzyk-expensify
    Contributor

    Looks like we've introduced a bug here by making the translation Account in Engish as well. We only wanted to do this for Spanish.

    Can we fix this? cc @Expensify/design

  14. dubielzyk-expensify commented on Apr 23, 2025

    @dubielzyk-expensify
    Contributor

    Actually, @shawnborton pointed out that it might be changed for a different reason so I'm probably just wrong here 🤔

  15. dannymcclain commented on Apr 23, 2025

    @dannymcclain
    Contributor

    Looks like we've introduced a bug here by making the translation Account in Engish as well. We only wanted to do this for Spanish.

    We want to change the name of that tab to Account in both English and Spanish—noted in the LHB design doc!

  16. RachCHopkins commented on Apr 28, 2025

    @RachCHopkins
    Contributor

    @shawnborton @dubielzyk-expensify @dannymcclain - can I pay this issue, or does it need to wait for this to be fixed? I can't tell, did this intro a bug or not?

  17. dannymcclain commented on Apr 28, 2025

    @dannymcclain
    Contributor

    @RachCHopkins I believe so - everything looks right on to me now.

  18. RachCHopkins commented on Apr 29, 2025

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @thelullabyy to be paid $250 via Upwork
    • Contributor+: @dukenv0307 to be paid $250 via NewDot Manual Request

    Upwork job here

  19. RachCHopkins commented on Apr 29, 2025

    @RachCHopkins
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

  20. JmillsExpensify commented on May 13, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions