Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+583@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)
Action Performed:
- Open the staging.new.expensify.com website.
- Sign up with a new account.
- On the first onboarding step, add a work Email like XXX@working.com
- Tap on "Add work Email" button.
- Complete the rest of onboarding steps.
- Once redirected to inbox, tap on FAB and select "New Workspace"
- Complete the workspace creation flow.
- Return to inbox.
- Note that now, on #Admins room of the created workspace, a "Trial: 30 days left" sign can be seen.
Expected Result:
The "Trial: 30 days left" sign, should be displayed on Concierge chat preview.
Actual Result:
The "Trial: 30 days left" sign, is displayed on preview of #Admins room of the first created workspace, instead of on Concierge chat´s preview.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021915847868020875229
- Upwork Job ID: 1915847868020875229
- Last Price Increase: 2025-04-25
Activity
melvin-bot commentedon Apr 17, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 17, 2025
Triggered auto assignment to @nkuoch (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 17, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 17, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
ashuvssut commentedon Apr 17, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 12:19:09 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Trial: 30 days left" sign, should be displayed on Concierge chat preview instead of
#admin's report which was created whenMANAGE_TEAMonboarding intent was selected during onboarding processWhat is the root cause of that problem?
We are check if the onboarding intent was
MANAGE_TEAM. That is, we checkonboardingPurposeSelected === "newDotManageTeam"(Check this PR which added it)if
MANAGE_TEAMonboarding intent was selected when onboarding, then we show theFreeTrialbanner on the #admin reportApp/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 67 in 717b77a
App/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 294 in 717b77a
What changes do you think we should make in order to solve the problem?
Currently we only show
FreeTrialbadge on#adminreport when onboarding intent was selected asMANAGE_TEAMApp/src/components/LHNOptionsList/OptionRowLHN.tsx
Line 294 in 717b77a
Instead of that, we should show
FreeTrialon a Concierge chat report onlyWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
marcaaron commentedon Apr 17, 2025
I am approaching this issue with total confusion. Did @c3024 write the test steps incorrectly?
The PR description says:
Which is the "actual result"
I'm gonna pop the blocker off this because I don't think this one is that bad in any case and I'd like to deploy today.
15 remaining items
[-]LHN - "Trial" sign, is displayed on #Admins room of WS when adding work Email on onboarding[/-][+][$250] LHN - "Trial" sign, is displayed on #Admins room of WS when adding work Email on onboarding[/+]melvin-bot commentedon Apr 25, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021915847868020875229
melvin-bot commentedon Apr 25, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (
External)marcaaron commentedon Apr 25, 2025
Ok I'm going to close it then for now. It's not clear that anything needs to be fixed.