Skip to content

[Due for payment 2025-04-28] [Due for payment 2025-04-25] Review duplicates - Receipt thumbnail on the confirmation page does not have right margin #60422

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): yonghongkok2+sjdsdisodio1@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two expenses with the same amount and merchant.
  4. Go to transaction thread of any expense.
  5. Click Review duplicates.
  6. Click Keep this one on any preview.

Expected Result:

Receipt thumbnail on the confirmation page will have right margin.

Actual Result:

Receipt thumbnail on the confirmation page does not have right margin.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 17, 2025
  2. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 17, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. NikkiWines commented on Apr 17, 2025

    @NikkiWines
    Contributor

    Discussing in slack

  7. Eskalifer1 commented on Apr 17, 2025

    @Eskalifer1
    Contributor

    Discussing in slack

    Can i have access to slack please?)

  8. ntdiary commented on Apr 17, 2025

    @ntdiary
    Contributor

    Can i have access to slack please?)

    https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#slack-channels
    @Eskalifer1, here’s how to apply, but I’m not sure if the issue with adding users has been resolved yet. :)

  9. 14 remaining items

  10. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-25. 🎊

  12. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    @NikkiWines / @marcaaron @alexpensify @NikkiWines / @marcaaron The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. changed the title [-][Due for payment 2025-04-25] Review duplicates - Receipt thumbnail on the confirmation page does not have right margin[/-] [+][Due for payment 2025-04-28] [Due for payment 2025-04-25] Review duplicates - Receipt thumbnail on the confirmation page does not have right margin[/+] on Apr 21, 2025
  14. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-28. 🎊

  15. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    @NikkiWines / @marcaaron @alexpensify @NikkiWines / @marcaaron The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. alexpensify commented on Apr 25, 2025

    @alexpensify
    Contributor

    @marcaaron, can you please confirm? I believe that @FitseTLT and @ahmedGaber93 helped fix this one. If yes, I need to prepare for the payment date on Monday. Thanks!

  17. FitseTLT commented on Apr 25, 2025

    @FitseTLT
    Contributor

    @marcaaron, can you please confirm? I believe that @FitseTLT and @ahmedGaber93 helped fix this one. If yes, I need to prepare for the payment date on Monday. Thanks!

    @alexpensify, please close it.

  18. alexpensify commented on Apr 25, 2025

    @alexpensify
    Contributor

    @FitseTLT thanks, after my comment, I saw that there is another GH where the payment will happen. Thanks again for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions