You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expensify logo has same redirection as "Inbox" #60428
Version Number: 9.1.29-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+en@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Open the ND app on Desktop
Sign into a valid user (HT Beta enabled user)
Go to a different page (For example settings)
Tap in Inbox
Go to a different page (For example settings)
Tap on E logo
Expected Result:
User expects the 2 buttons to have different redirections, perhaps the E button should lead to WS switcher
Actual Result:
Both buttons have the same redirection
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6805085_1744896253003.Same_redirection_for_2_different_buttons.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I think the both have the same Navigation.navigate() redirection, perhaps we should change it to WS switcher. Posting a proposal soon if this goes external...
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Apr 17, 2025
Triggered auto assignment to @lakchote (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 17, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 17, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lakchote commentedon Apr 17, 2025
Looks like it could be related to [Desktop Navigation] Add a responsive LHB
cc @mountiny
PiyushChandra17 commentedon Apr 17, 2025
I think the both have the same Navigation.navigate() redirection, perhaps we should change it to WS switcher. Posting a proposal soon if this goes external...
nyomanjyotisa commentedon Apr 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expensify logo has same redirection as "Inbox"
What is the root cause of that problem?
We use pressable Expensify Logo here and on click execute
navigateToChatsfunctionApp/src/components/Navigation/NavigationTabBar/index.tsx
Lines 208 to 220 in 717b77a
What changes do you think we should make in order to solve the problem?
Use
WorkspaceSwitcherButtoninstead, and add the wrapper styleWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
WojtekBoman commentedon Apr 17, 2025
Hey, this is expected behaviour, it is in line with the design doc
Here are comments where it's mentioned
#60024 (comment)
#60024 (comment)
cc: @mountiny @flaviadefaria @dannymcclain
PiyushChandra17 commentedon Apr 17, 2025
This issue is not reproducible on the latest main, can someone verify
PiyushChandra17 commentedon Apr 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expensify logo has same redirection as "Inbox"
What is the root cause of that problem?
We are clearly redirecting to the
navigateToChatshere,App/src/components/Navigation/NavigationTabBar/index.tsx
Lines 212 to 213 in 717b77a
Perhaps this is the root cause
What changes do you think we should make in order to solve the problem?
Instead
navigateToChats, navigate to WS switcherReplace this line:
App/src/components/Navigation/NavigationTabBar/index.tsx
Line 213 in 717b77a
with,
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
PiyushChandra17 commentedon Apr 17, 2025
Since this is deployblocker, i can help raise a quick PR.
cc: @lakchote
lakchote commentedon Apr 17, 2025
Thank you for clarifying! You are right, it's expected given what has been written in the design doc here.
Closing the issue.
mountiny commentedon Apr 17, 2025
Thanks! We will updated the test rail cases as part of the proejct