Skip to content

Expensify logo has same redirection as "Inbox" #60428

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.29-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the ND app on Desktop
  2. Sign into a valid user (HT Beta enabled user)
  3. Go to a different page (For example settings)
  4. Tap in Inbox
  5. Go to a different page (For example settings)
  6. Tap on E logo

Expected Result:

User expects the 2 buttons to have different redirections, perhaps the E button should lead to WS switcher

Actual Result:

Both buttons have the same redirection

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6805085_1744896253003.Same_redirection_for_2_different_buttons.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Apr 17, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lakchote commented on Apr 17, 2025

    @lakchote
    Contributor

    Looks like it could be related to [Desktop Navigation] Add a responsive LHB

    cc @mountiny

  5. PiyushChandra17 commented on Apr 17, 2025

    @PiyushChandra17
    Contributor

    I think the both have the same Navigation.navigate() redirection, perhaps we should change it to WS switcher. Posting a proposal soon if this goes external...

  6. nyomanjyotisa commented on Apr 17, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expensify logo has same redirection as "Inbox"

    What is the root cause of that problem?

    We use pressable Expensify Logo here and on click execute navigateToChats function

    <PressableWithFeedback
    accessibilityRole={CONST.ROLE.BUTTON}
    accessibilityLabel="Home"
    accessible
    testID="ExpensifyLogoButton"
    onPress={navigateToChats}
    wrapperStyle={styles.leftNavigationTabBarItem}
    >
    <ImageSVG
    style={StyleUtils.getAvatarStyle(CONST.AVATAR_SIZE.DEFAULT)}
    src={Expensicons.ExpensifyAppIcon}
    />
    </PressableWithFeedback>

    What changes do you think we should make in order to solve the problem?

    Use WorkspaceSwitcherButton instead, and add the wrapper style

    const policy = usePolicy(activeWorkspaceID);
    
                            <View style={styles.leftNavigationTabBarItem}>
                                <WorkspaceSwitcherButton policy={policy} />
                            </View>
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    N/A

  7. WojtekBoman commented on Apr 17, 2025

    @WojtekBoman
    Contributor

    Hey, this is expected behaviour, it is in line with the design doc
    Here are comments where it's mentioned
    #60024 (comment)
    #60024 (comment)

    cc: @mountiny @flaviadefaria @dannymcclain

  8. PiyushChandra17 commented on Apr 17, 2025

    @PiyushChandra17
    Contributor

    This issue is not reproducible on the latest main, can someone verify

  9. PiyushChandra17 commented on Apr 17, 2025

    @PiyushChandra17
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expensify logo has same redirection as "Inbox"

    What is the root cause of that problem?

    We are clearly redirecting to the navigateToChats here,

    testID="ExpensifyLogoButton"
    onPress={navigateToChats}

    Perhaps this is the root cause

    What changes do you think we should make in order to solve the problem?

    Instead navigateToChats, navigate to WS switcher

    Replace this line:

    with,

    onPress={() => Navigation.navigate(ROUTES.WORKSPACE_SWITCHER)}

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Result

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  10. PiyushChandra17 commented on Apr 17, 2025

    @PiyushChandra17
    Contributor

    Since this is deployblocker, i can help raise a quick PR.

    cc: @lakchote

  11. lakchote commented on Apr 17, 2025

    @lakchote
    Contributor

    Hey, this is expected behaviour, it is in line with the design doc Here are comments where it's mentioned #60024 (comment) #60024 (comment)

    cc: @mountiny @flaviadefaria @dannymcclain

    Thank you for clarifying! You are right, it's expected given what has been written in the design doc here.

    Closing the issue.

  12. mountiny commented on Apr 17, 2025

    @mountiny
    Contributor

    Thanks! We will updated the test rail cases as part of the proejct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions