Skip to content

[Pay May 6] [$250] QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page. #60532

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+bm572@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Workspace Settings

Action Performed:

Precondition -
Enable the Expensify Card and set up any bank account, and verify it.
Connect to QBO

  1. Go to https://staging.new.expensify.com/
  2. Go to accounting > QBO advanced settings > click on auto-sync, then disable it.
  3. Back to accounting page and click on Card reconciliation, then click on the auto-sync hyperlink

Expected Result:

Clicking the Auto-sync hyperlink should navigate directly to the Auto-sync page under the Advanced Settings section in QBO (where the Enable/Disable toggle is located).

Actual Result:

Clicking the Auto-sync hyperlink only navigates to the general Advanced Settings page in QBO, not specifically to the Auto-sync page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021914280458819088667
  • Upwork Job ID: 1914280458819088667
  • Last Price Increase: 2025-04-21
  • Automatic offers:
    • nyomanjyotisa | Contributor | 107006382
Issue OwnerCurrent Issue Owner: @hungvu193

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2025
  2. melvin-bot commented on Apr 19, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nyomanjyotisa commented on Apr 19, 2025

    @nyomanjyotisa
    Member

    🚨 Edited by proposal-police: This proposal was edited at 2025-04-19 13:12:17 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page

    What is the root cause of that problem?

    we currently navigate to the advance settings on auto-sync click for QBO

    Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCED.getRoute(policyID));

    What changes do you think we should make in order to solve the problem?

    Navigate directly to autosync instead

    Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC.getRoute(policyID));
    

    Additionally might need to do the same for Netsuite as well, and use this route

    And also additionally might need to change the const name accordingly here

    Also additionally we can update the onBackButtonPress here accordingly, to go back to the card-reconciliation page if coming from that page

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    I dont think we need automated test for this, but if needed we can add UI test to confirm that autosync setting opened when clickin on auto-sync click for QBO

    What alternative solutions did you explore? (Optional)

    N/A

  4. ishakakkad commented on Apr 19, 2025

    @ishakakkad
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.

    What is the root cause of that problem?

    Currently when user click on auto-sync link we navigate to WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCED route from here

    What changes do you think we should make in order to solve the problem?

    To fix this issue we need to replace WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCED here with following code.

    Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_AUTO_SYNC.getRoute(policyID));
    

    Note:
    We can also check for other connection type as well, if required we make the same change for other connection types.

    const navigateToAdvancedSettings = useCallback(() => {
    switch (connection) {
    case CONST.POLICY.CONNECTIONS.ROUTE.QBO:
    Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCED.getRoute(policyID));
    break;
    case CONST.POLICY.CONNECTIONS.ROUTE.XERO:
    Navigation.navigate(ROUTES.POLICY_ACCOUNTING_XERO_ADVANCED.getRoute(policyID));
    break;
    case CONST.POLICY.CONNECTIONS.ROUTE.NETSUITE:
    Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_ADVANCED.getRoute(policyID));
    break;
    case CONST.POLICY.CONNECTIONS.ROUTE.SAGE_INTACCT:
    Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_ADVANCED.getRoute(policyID));
    break;
    default:
    break;
    }
    }, [connection, policyID]);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    We can test navigateToAdvancedSettings().

    What alternative solutions did you explore? (Optional)

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 21, 2025
  6. changed the title [-]QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.[/-] [+][$250] QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.[/+] on Apr 21, 2025
  7. melvin-bot commented on Apr 21, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 21, 2025
  9. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

  10. mallenexpensify commented on Apr 21, 2025

    @mallenexpensify
    Contributor

    Looks like this can likely be External. @hungvu193 can you confirm and attempt reproduction? Thx

  11. 23 remaining items

  12. trjExpensify commented on May 13, 2025

    @trjExpensify
    Contributor

    I think we have a regression to account for here, so payment summary as follows:

  13. garrettmknight commented on May 13, 2025

    @garrettmknight
    Contributor

    $125 approved for @hungvu193

  14. garrettmknight commented on May 13, 2025

    @garrettmknight
    Contributor

    Also paying out the upwork contract.

  15. garrettmknight commented on May 13, 2025

    @garrettmknight
    Contributor

    @hungvu193 please complete the checklist.

  16. mallenexpensify commented on May 13, 2025

    @mallenexpensify
    Contributor

    Thanks for the assist @trjExpensify

  17. hungvu193 commented on May 14, 2025

    @hungvu193
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A (We only recently introduced auto sync screen, before that we navigate user to advance page).

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Enable the Expensify Card and set up any bank account, and verify it.
    • Connect to QBO

    Test:

    1. Go to https://staging.new.expensify.com/
    2. Go to accounting > QBO advanced settings > click on auto-sync, then disable it.
    3. Back to accounting page and click on Card reconciliation, then click on the auto-sync hyperlink.
    4. Verify that you're navigated to auto sync page. Enable auto sync.
    5. Click When to Export.
    6. Select Cash, or the other one that is not selected.
    7. Click RHP back button.
    8. Verify that you're navigated to Card Reconciliation Page.
      Do we agree 👍 or 👎
  18. mallenexpensify commented on May 16, 2025

    @mallenexpensify
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions