You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Pay May 6] [$250] QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page. #60532
Version Number: 9.1.30-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+bm572@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Web, mweb App Component: Workspace Settings
Action Performed:
Precondition -
Enable the Expensify Card and set up any bank account, and verify it.
Connect to QBO
Go to accounting > QBO advanced settings > click on auto-sync, then disable it.
Back to accounting page and click on Card reconciliation, then click on the auto-sync hyperlink
Expected Result:
Clicking the Auto-sync hyperlink should navigate directly to the Auto-sync page under the Advanced Settings section in QBO (where the Enable/Disable toggle is located).
Actual Result:
Clicking the Auto-sync hyperlink only navigates to the general Advanced Settings page in QBO, not specifically to the Auto-sync page.
Additionally might need to do the same for Netsuite as well, and use this route
And also additionally might need to change the const name accordingly here
Also additionally we can update the onBackButtonPresshere accordingly, to go back to the card-reconciliation page if coming from that page
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
I dont think we need automated test for this, but if needed we can add UI test to confirm that autosync setting opened when clickin on auto-sync click for QBO
What alternative solutions did you explore? (Optional)
changed the title [-]QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.[/-][+][$250] QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.[/+]on Apr 21, 2025
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A (We only recently introduced auto sync screen, before that we navigate user to advance page).
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Enable the Expensify Card and set up any bank account, and verify it.
Activity
melvin-bot commentedon Apr 19, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Apr 19, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-19 13:12:17 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page
What is the root cause of that problem?
we currently navigate to the advance settings on auto-sync click for QBO
App/src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx
Line 59 in 7e5a333
What changes do you think we should make in order to solve the problem?
Navigate directly to autosync instead
Additionally might need to do the same for Netsuite as well, and use this route
And also additionally might need to change the const name accordingly here
Also additionally we can update the
onBackButtonPresshere accordingly, to go back to thecard-reconciliationpage if coming from that pageWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
I dont think we need automated test for this, but if needed we can add UI test to confirm that autosync setting opened when clickin on auto-sync click for QBO
What alternative solutions did you explore? (Optional)
N/A
ishakakkad commentedon Apr 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.
What is the root cause of that problem?
Currently when user click on
auto-synclink we navigate toWORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCEDroute from hereWhat changes do you think we should make in order to solve the problem?
To fix this issue we need to replace
WORKSPACE_ACCOUNTING_QUICKBOOKS_ONLINE_ADVANCEDhere with following code.Note:
We can also check for other connection type as well, if required we make the same change for other connection types.
App/src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx
Lines 56 to 73 in 7e5a333
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can test navigateToAdvancedSettings().
What alternative solutions did you explore? (Optional)
[-]QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.[/-][+][$250] QBO - Auto-sync hyperlink in Card Reconciliation does not navigate to the Auto-sync page.[/+]melvin-bot commentedon Apr 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021914280458819088667
melvin-bot commentedon Apr 21, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)mallenexpensify commentedon Apr 21, 2025
Looks like this can likely be
External. @hungvu193 can you confirm and attempt reproduction? Thx23 remaining items
trjExpensify commentedon May 13, 2025
I think we have a regression to account for here, so payment summary as follows:
garrettmknight commentedon May 13, 2025
$125 approved for @hungvu193
garrettmknight commentedon May 13, 2025
Also paying out the upwork contract.
garrettmknight commentedon May 13, 2025
@hungvu193 please complete the checklist.
mallenexpensify commentedon May 13, 2025
Thanks for the assist @trjExpensify
hungvu193 commentedon May 14, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A (We only recently introduced auto sync screen, before that we navigate user to advance page).
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
mallenexpensify commentedon May 16, 2025
Test case created, thanks y'all!