You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-20] [$250] Workspace - Bank address suggestion modal isn't showing #60571
Version Number: 9.1.30-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check in Production, it asks to update the currency to USD. If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#56931 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Windows 10 / Chrome, macOS Sequoia 15.3 App Component: Workspace Settings
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Apr 21, 2025
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Apr 21, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Bank address suggestion modal doesn't show.
What is the root cause of that problem?
We render all the field as a TextInput,
App/src/pages/ReimbursementAccount/NonUSD/BankInfo/subSteps/BankAccountDetails.tsx
Lines 79 to 91 in 7a42c6a
It's the same with account holder details too.
What changes do you think we should make in order to solve the problem?
We can use the same approach as in BankInformation.
App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/BankInformation.tsx
Lines 20 to 31 in 7a42c6a
First, create the
getInputComponentfunction in both BankAccountDetails and AccountHolderDetails.App/src/pages/ReimbursementAccount/NonUSD/BankInfo/subSteps/BankAccountDetails.tsx
Lines 89 to 97 in 7a42c6a
Next, limit the address search to the selected country and map the id to the correct one.
For
BankAccountDetails, we can get the country fromreimbursementAccountDraftand map the input id as below.For
AccountHolderDetails, we can get the country fromdefaultValuesand map the input id as below.(we can optionally map the other input to empty string)
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
melvin-bot commentedon Apr 29, 2025
@adelekennedy Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Apr 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021917342205783621702
[-]Workspace - Bank address suggestion modal isn't showing[/-][+][$250] Workspace - Bank address suggestion modal isn't showing[/+]melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)22 remaining items
melvin-bot commentedon May 20, 2025
Payment Summary
Upwork Job
BugZero Checklist (@adelekennedy)
adelekennedy commentedon May 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
adelekennedy commentedon May 20, 2025
The payment summary above is correct - adding the checklist above @thesahindia!
bernhardoj commentedon May 20, 2025
Requested in ND.
JmillsExpensify commentedon May 22, 2025
$250 approved for @bernhardoj
thesahindia commentedon May 22, 2025
It wasn’t a regression, just an improvement. We can add a test case to cover it.
garrettmknight commentedon Jul 3, 2025
$250 approved for @thesahindia