Skip to content

[Due for payment 2025-05-20] [$250] Workspace - Bank address suggestion modal isn't showing #60571

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check in Production, it asks to update the currency to USD.
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56931
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, macOS Sequoia 15.3
App Component: Workspace Settings

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a new Expensifail account
  3. Create a workspace with "EUR" default currency
  4. Navigate to Workspace settings - Workflows - Connect bank account - Connect manually
  5. Select "Croatia" as the Country
  6. Click on the "Confirm" button
  7. Input any number or letters to the "Bank Address" field that would normally trigger an auto suggestion

Expected Result:

Bank address suggestion modal should be visible.

Actual Result:

Bank address suggestion modal isn't showing.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021917342205783621702
  • Upwork Job ID: 1917342205783621702
  • Last Price Increase: 2025-04-29
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 21, 2025
  2. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on Apr 21, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Bank address suggestion modal doesn't show.

    What is the root cause of that problem?

    We render all the field as a TextInput,

    return bankAccountDetailsFields?.map((field) => {
    if (field.valueSet !== undefined) {
    return getInputForValueSet(field, String(defaultValues[field.id as keyof typeof defaultValues]), isEditing, styles);
    }
    return (
    <View
    style={styles.mb6}
    key={field.id}
    >
    <InputWrapper
    InputComponent={TextInput}
    inputID={field.id}

    It's the same with account holder details too.

    What changes do you think we should make in order to solve the problem?

    We can use the same approach as in BankInformation.

    function getInputComponent(field: CorpayFormField) {
    if ((field.valueSet ?? []).length > 0) {
    return ValuePicker;
    }
    if (CONST.CORPAY_FIELDS.SPECIAL_LIST_REGION_KEYS.includes(field.id)) {
    return ValuePicker;
    }
    if (CONST.CORPAY_FIELDS.SPECIAL_LIST_ADDRESS_KEYS.includes(field.id)) {
    return AddressSearch;
    }
    return TextInput;
    }

    First, create the getInputComponent function in both BankAccountDetails and AccountHolderDetails.

    <InputWrapper
    InputComponent={TextInput}
    inputID={field.id}
    label={field.label}
    aria-label={field.label}
    role={CONST.ROLE.PRESENTATION}
    shouldSaveDraft={!isEditing}
    defaultValue={String(defaultValues[field.id as keyof typeof defaultValues]) ?? ''}
    />

    Next, limit the address search to the selected country and map the id to the correct one.

    For BankAccountDetails, we can get the country from reimbursementAccountDraft and map the input id as below.

    limitSearchesToCountry={reimbursementAccountDraft?.['country']}
    renamedInputKeys={{
        street: 'bankAddressLine1',
        city: 'bankCity',
    }}
    

    For AccountHolderDetails, we can get the country from defaultValues and map the input id as below.

    limitSearchesToCountry={defaultValues['accountHolderCountry']}
    renamedInputKeys={{
        street: 'accountHolderAddress1',
        city: 'accountHolderCity',
    }}
    

    (we can optionally map the other input to empty string)

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

  4. melvin-bot commented on Apr 29, 2025

    @melvin-bot

    @adelekennedy Still overdue 6 days?! Let's take care of this!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 29, 2025
  6. melvin-bot commented on Apr 29, 2025

    @melvin-bot
  7. changed the title [-]Workspace - Bank address suggestion modal isn't showing[/-] [+][$250] Workspace - Bank address suggestion modal isn't showing[/+] on Apr 29, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 29, 2025
  9. melvin-bot commented on Apr 29, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  10. 22 remaining items

  11. melvin-bot commented on May 20, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@adelekennedy)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1917342205783621702/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. adelekennedy commented on May 20, 2025

    @adelekennedy
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  13. adelekennedy commented on May 20, 2025

    @adelekennedy
    Contributor

    The payment summary above is correct - adding the checklist above @thesahindia!

  14. bernhardoj commented on May 20, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  15. JmillsExpensify commented on May 22, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  16. thesahindia commented on May 22, 2025

    @thesahindia
    Member

    It wasn’t a regression, just an improvement. We can add a test case to cover it.

    1. Go to any workspace > Overview
    2. Change the default currency to "EUR"
    3. Go to Workflows > Connect bank account > Connect manually
    4. Select any country
    5. Type anything into the "Bank Address"
    6. Select any address from the suggestion modal
    7. Verify it fills the address and city
    8. Fill the rest > next
    9. Enter anything into the address field
    10. Select any address from the suggestion modal
    11. Verify it fills the address and city
  17. garrettmknight commented on Jul 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions