You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-11] Track expense - Expense preview disappears when deleted offline #60638
Version Number: 9.1.31-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sd3480@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Account has self DM.
Go to staging.new.expensify.com
Go to self DM.
Submit a manual expense in self DM.
Go offline.
Right click on the expense preview > Delete expense.
Delete the expense.
Expected Result:
The expense preview will be crossed out and grayed out when deleted offline.
Actual Result:
The expense preview disappears after the expense is deleted offline.
This issue only happens with Expensifail accounts, and only with the expenses in self DM.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Track expense - Expense preview disappears when deleted offline[/-][+][Due for payment 2025-06-11] Track expense - Expense preview disappears when deleted offline[/+]on Jun 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jjcoffee@sakluger@jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Account that has a self DM
Has tableReportView beta
Test:
Go to self DM.
Submit a manual expense in self DM.
Go offline.
Right click on the expense preview > Delete expense.
Delete the expense.
Verify that the expense is greyed-out with a crossed out value
Activity
melvin-bot commentedon Apr 22, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Apr 22, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The expense preview disappears after the expense is deleted offline.
What is the root cause of that problem?
In self DM and deleted transaction we are setting children as
emptyHTMLin hereApp/src/pages/home/report/PureReportActionItem.tsx
Line 803 in 018589c
App/src/pages/home/report/PureReportActionItem.tsx
Lines 830 to 832 in 018589c
What changes do you think we should make in order to solve the problem?
We have 2 ways to fix this problem
MoneyRequestActioncomponent to render deleted transaction by adding!isDeletedAction(action)in hereApp/src/pages/home/report/PureReportActionItem.tsx
Lines 802 to 804 in 018589c
TransactionPreviewcomponent to render deleted transaction by remove!isDeletedAction(action)hereApp/src/pages/home/report/PureReportActionItem.tsx
Line 803 in 018589c
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Track expense - Expense preview disappears when deleted offline[/-][+][$250] Track expense - Expense preview disappears when deleted offline[/+]melvin-bot commentedon Apr 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021915467430280046181
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)jjcoffee commentedon Apr 25, 2025
Looks like a regression from #60179. cc @JakubKorytko are you able to take a quick look at the proposal here?
mountiny commentedon Apr 25, 2025
Putting this on hold for #60192
49 remaining items
[-]Track expense - Expense preview disappears when deleted offline[/-][+][Due for payment 2025-06-11] Track expense - Expense preview disappears when deleted offline[/+]melvin-bot commentedon Jun 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 4, 2025
@jjcoffee @sakluger @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sakluger commentedon Jun 13, 2025
Summarizing payment on this issue:
Contributor: @daledah $250, paid via Upwork
Contributor+: @jjcoffee $250, please request on Newdot
jjcoffee commentedon Jun 13, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/60179/files#r2144508594
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
garrettmknight commentedon Jun 13, 2025
$250 approved for @jjcoffee
melvin-bot commentedon Jun 16, 2025
@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!