Skip to content

[Due for payment 2025-06-11] Track expense - Expense preview disappears when deleted offline #60638

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.31-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sd3480@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Submit a manual expense in self DM.
  4. Go offline.
  5. Right click on the expense preview > Delete expense.
  6. Delete the expense.

Expected Result:

The expense preview will be crossed out and grayed out when deleted offline.

Actual Result:

The expense preview disappears after the expense is deleted offline.

This issue only happens with Expensifail accounts, and only with the expenses in self DM.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021915467430280046181
  • Upwork Job ID: 1915467430280046181
  • Last Price Increase: 2025-04-24
  • Automatic offers:
    • daledah | Contributor | 107376736
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 22, 2025
  2. melvin-bot commented on Apr 22, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Apr 22, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The expense preview disappears after the expense is deleted offline.

    What is the root cause of that problem?

    In self DM and deleted transaction we are setting children as emptyHTML in here

    if ((report.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM && !isDeletedAction(action)) || isSplitInGroupChat) {

    } else {
    children = emptyHTML;
    }

    What changes do you think we should make in order to solve the problem?

    We have 2 ways to fix this problem

    1. We will use MoneyRequestAction component to render deleted transaction by adding !isDeletedAction(action) in here
                if (canUseTableReportView && report?.type === CONST.REPORT.TYPE.CHAT && !isDeletedAction(action)) {
                    if (report.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM || isSplitInGroupChat) {
    

    if (canUseTableReportView && report?.type === CONST.REPORT.TYPE.CHAT) {
    if ((report.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM && !isDeletedAction(action)) || isSplitInGroupChat) {
    children = (

    Image
    1. We will use TransactionPreview component to render deleted transaction by remove !isDeletedAction(action) here

    if ((report.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM && !isDeletedAction(action)) || isSplitInGroupChat) {

    Image

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 24, 2025
  5. changed the title [-]Track expense - Expense preview disappears when deleted offline[/-] [+][$250] Track expense - Expense preview disappears when deleted offline[/+] on Apr 24, 2025
  6. melvin-bot commented on Apr 24, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 24, 2025
  8. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  9. jjcoffee commented on Apr 25, 2025

    @jjcoffee
    Contributor

    Looks like a regression from #60179. cc @JakubKorytko are you able to take a quick look at the proposal here?

  10. mountiny commented on Apr 25, 2025

    @mountiny
    Contributor

    Putting this on hold for #60192

  11. 49 remaining items

  12. changed the title [-]Track expense - Expense preview disappears when deleted offline[/-] [+][Due for payment 2025-06-11] Track expense - Expense preview disappears when deleted offline[/+] on Jun 4, 2025
  13. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-11. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    @jjcoffee @sakluger @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. sakluger commented on Jun 13, 2025

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @daledah $250, paid via Upwork
    Contributor+: @jjcoffee $250, please request on Newdot

  17. jjcoffee commented on Jun 13, 2025

    @jjcoffee
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/60179/files#r2144508594

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Account that has a self DM
    • Has tableReportView beta

    Test:

    1. Go to self DM.
    2. Submit a manual expense in self DM.
    3. Go offline.
    4. Right click on the expense preview > Delete expense.
    5. Delete the expense.
    6. Verify that the expense is greyed-out with a crossed out value

    Do we agree 👍 or 👎

  18. garrettmknight commented on Jun 13, 2025

    @garrettmknight
    Contributor

    $250 approved for @jjcoffee

  19. melvin-bot commented on Jun 16, 2025

    @melvin-bot

    @sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions