You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Better Expense Report View] One expense report view #60742
The main idea is to split logic deciding which version to display into 2 checks:
isTransactionThread - existing logic is unchanged, if this is true then we display "single transaction thread" just like now, including special header version;
isReportWithSingleTransaction - this will test transactions.length === 1 and will be only if previous check was false, and we know that we have a report; it always display the "report" header and then table view
Feels lik we could close this task, I haven't seen any errors related to one expense/transaction thread (other than wrong loading screen, but that is worked on).
Activity
melvin-bot commentedon Apr 23, 2025
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 24, 2025
Kicu commentedon Apr 24, 2025
Starting work on this now.
The main idea is to split logic deciding which version to display into 2 checks:
isTransactionThread- existing logic is unchanged, if this is true then we display "single transaction thread" just like now, including special header version;isReportWithSingleTransaction- this will testtransactions.length === 1and will be only if previous check was false, and we know that we have a report; it always display the "report" header and then table viewKicu commentedon Apr 25, 2025
PR ready for review
Kicu commentedon May 7, 2025
Feels lik we could close this task, I haven't seen any errors related to one expense/transaction thread (other than wrong loading screen, but that is worked on).
Kicu commentedon May 7, 2025
CC @mountiny @trjExpensify
trjExpensify commentedon May 8, 2025
Another one bites the dust!