Skip to content

[Better Expense Report View] One expense report view #60742

Closed

Description

@trjExpensify

Coming from here.

@Kicu - the one expense report view still isn't working/has regressed.

2025-04-23_20-58-34.mp4

Steps:

  1. Create an expense
  2. Click the preview
  3. Observe being taken to a one expense report table view in Inbox
  4. Switch to the Reports page
  5. Click on Expense reports
  6. Click on the one-expense report
  7. Observe being taken to a one expense report table view in Reports
Issue OwnerCurrent Issue Owner: @Kicu

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 23, 2025
  2. self-assigned this
    on Apr 23, 2025
  3. moved this to Second Cohort - CRITICAL in [#whatsnext] #migrateon Apr 23, 2025
  4. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Apr 24, 2025

    @melvin-bot
  6. Kicu commented on Apr 24, 2025

    @Kicu
    Contributor

    Starting work on this now.

    The main idea is to split logic deciding which version to display into 2 checks:

    1. isTransactionThread - existing logic is unchanged, if this is true then we display "single transaction thread" just like now, including special header version;
    2. isReportWithSingleTransaction - this will test transactions.length === 1 and will be only if previous check was false, and we know that we have a report; it always display the "report" header and then table view
  7. Kicu commented on Apr 25, 2025

    @Kicu
    Contributor

    PR ready for review

  8. Kicu commented on May 7, 2025

    @Kicu
    Contributor

    Feels lik we could close this task, I haven't seen any errors related to one expense/transaction thread (other than wrong loading screen, but that is worked on).

  9. Kicu commented on May 7, 2025

    @Kicu
    Contributor
  10. trjExpensify commented on May 8, 2025

    @trjExpensify
    ContributorAuthor

    Another one bites the dust!

  11. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions