Skip to content

[Due for payment 2025-07-25] [$150] In spanish, the "Light bulb" icon is left on a line alone and also outside module #60753

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #60479
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Chat Report View

Action Performed:

Precond: User has app in Spanish

  1. Open the ND app
  2. Sign into a valid new user
  3. Go to Create expense > Scan > Observe the popup

Expected Result:

In English, the text is on the same line as the "light bulb" icon, also the popup is maintained within the background module. User expects the same to happen for Spanish text

Actual Result:

In Spanish, the text only starts in the second line (Leave the Light bulb on a line by itself). The popup also runs outside of the background module

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021917011135225708614
  • Upwork Job ID: 1917011135225708614
  • Last Price Increase: 2025-07-02
  • Automatic offers:
    • davidgelhar | Contributor | 107454528
Issue OwnerCurrent Issue Owner: @MarioExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 23, 2025
  2. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. thelullabyy commented on Apr 24, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • In spanish, the "Light bulb" icon is left on a line alone and also outside module

    What is the root cause of that problem?

    • The Spanish translation text is too long, which causes the layout to wrap. As a result, the light bulb icon is rendered alone on the first line and visually detached from the text. This also causes the tooltip to overflow its container:

      App/src/languages/es.ts

      Lines 6751 to 6753 in e1e89c9

      scanTestTooltip: {
      part1: '¿Quieres ver cómo funciona Escanear?',
      part2: '¡Prueba con un recibo de prueba!',

    What changes do you think we should make in order to solve the problem?

    • Use shorter translations to ensure the light bulb icon remains inline with the text and the tooltip stays within the background bounds. For example:
      
      part1: '¿Cómo funciona Escanear?',
      part2: '¡Haz una prueba!',
      

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • NA

    What alternative solutions did you explore? (Optional)

    • Another option is to retain the existing translation tone but format it in a way that improves layout:

      
      scanTestTooltip: {
          part1: '¿Quieres ver cómo funciona Escanear?',
          part2: '\n¡Prueba con un recibo de prueba!',
      }
      
    • If we choose to apply formatting changes consistently, we should also update the English version in en.ts:

      
      scanTestTooltip: {
          part1: 'Want to see how Scan works?',
          part2: '\nTry a test receipt!',
      }
      
    • Optional, in:

      wrapperStyle={styles.productTrainingTooltipWrapper}
      , we can set the width style such as width: 300 or pass maxWidth prop such as maxWidth={300}. This option can be applied to both main and alternative solutions.

  4. bernhardoj commented on Apr 24, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The scan educational tooltip light bulb icon is at the top while the text is at the bottom/

    What is the root cause of that problem?

    This all happens because we set the container style to flex wrap.

    <View
    style={[
    styles.alignItemsCenter,
    styles.flexRow,
    tooltip?.shouldRenderActionButtons ? styles.justifyContentStart : styles.justifyContentCenter,
    styles.flexWrap,

    Since the text is too long, the text is wrapped to the bottom.

    What changes do you think we should make in order to solve the problem?

    Removes the flex wrap style.

    Image

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

  5. changed the title [-]In spanish, the "Light bulb" icon is left on a line alone and also outside module[/-] [+][$75] In spanish, the "Light bulb" icon is left on a line alone and also outside module[/+] on Apr 29, 2025
  6. melvin-bot commented on Apr 29, 2025

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 29, 2025
  8. melvin-bot commented on Apr 29, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 29, 2025
  10. melvin-bot commented on Apr 29, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  11. 117 remaining items

  12. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-25. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    @eVoloshchak @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. mallenexpensify commented on Jul 24, 2025

    @mallenexpensify
    Contributor

    Contributor: @davidgelhar paid $150 via Upwork
    Contributor+: @eVoloshchak due $150 via NewDot

    @dannymcclain on step 3 said On desktop, verify that the left edge of the tooltip extends beyond the bounds of the RHP, but in fact and in your video, it works another way. Expected?

    I see the above here, if anyone knows the answer.

    @eVoloshchak can you fill out the BZ checklist plz? We want a regression test cuz it'll be a design/edge case one they check every month or so.

  16. eVoloshchak commented on Jul 25, 2025

    @eVoloshchak
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: the expected result has changed since this issue was created, but the original bug was caused by the tooltip not resizing properly when switching the locale to Spanish. This can be traced back to Add useStyleUtils hook #32498, but the PR is 2 years old, I'm unable to verify that it's indeed the cause

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: regression wasn't critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Test with an account that has not yet scanned an expense.

    Test:

    1. Click "+" -> "Create Expense" -> "Scan" tab
    2. On desktop, verify that the tooltip is centered under the "Scan" button
    3. On desktop, verify that the left edge of the tooltip extends beyond the bounds of the RHP
    4. On mobile, verify that the tooltip is centered in the panel
    5. On mobile, verify that the tooltip pointer points at the center of the "Scan" button
    6. Change the language to Spanish
    7. Go through steps 1-5

    Do we agree 👍 or 👎

  17. MarioExpensify commented on Jul 28, 2025

    @MarioExpensify
    Contributor

    Thank you @eVoloshchak. @mallenexpensify with the BZ checklist filled, can we close this one?

  18. mallenexpensify commented on Jul 29, 2025

    @mallenexpensify
    Contributor
  19. garrettmknight commented on Dec 18, 2025

    @garrettmknight
    Contributor

    $150 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions