You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-07-25] [$150] In spanish, the "Light bulb" icon is left on a line alone and also outside module #60753
Version Number: v9.1.32-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#60479 Email or phone of affected tester (no customers):applausetester+en@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Macbook Pro 2023 / Sequoia 15.2 App Component: Chat Report View
Action Performed:
Precond: User has app in Spanish
Open the ND app
Sign into a valid new user
Go to Create expense > Scan > Observe the popup
Expected Result:
In English, the text is on the same line as the "light bulb" icon, also the popup is maintained within the background module. User expects the same to happen for Spanish text
Actual Result:
In Spanish, the text only starts in the second line (Leave the Light bulb on a line by itself). The popup also runs outside of the background module
Please re-state the problem that we are trying to solve in this issue.
In spanish, the "Light bulb" icon is left on a line alone and also outside module
What is the root cause of that problem?
The Spanish translation text is too long, which causes the layout to wrap. As a result, the light bulb icon is rendered alone on the first line and visually detached from the text. This also causes the tooltip to overflow its container:
, we can set the width style such as width: 300 or pass maxWidth prop such as maxWidth={300}. This option can be applied to both main and alternative solutions.
changed the title [-]In spanish, the "Light bulb" icon is left on a line alone and also outside module[/-][+][$75] In spanish, the "Light bulb" icon is left on a line alone and also outside module[/+]on Apr 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@eVoloshchak@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
@dannymcclain on step 3 said On desktop, verify that the left edge of the tooltip extends beyond the bounds of the RHP, but in fact and in your video, it works another way. Expected?
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: the expected result has changed since this issue was created, but the original bug was caused by the tooltip not resizing properly when switching the locale to Spanish. This can be traced back to Add useStyleUtils hook #32498, but the PR is 2 years old, I'm unable to verify that it's indeed the cause
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test with an account that has not yet scanned an expense.
Test:
Click "+" -> "Create Expense" -> "Scan" tab
On desktop, verify that the tooltip is centered under the "Scan" button
On desktop, verify that the left edge of the tooltip extends beyond the bounds of the RHP
On mobile, verify that the tooltip is centered in the panel
On mobile, verify that the tooltip pointer points at the center of the "Scan" button
Activity
melvin-bot commentedon Apr 23, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon Apr 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/languages/es.ts
Lines 6751 to 6753 in e1e89c9
What changes do you think we should make in order to solve the problem?
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Another option is to retain the existing translation tone but format it in a way that improves layout:
If we choose to apply formatting changes consistently, we should also update the English version in
en.ts:Optional, in:
App/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Line 917 in e1e89c9
width: 300or passmaxWidthprop such asmaxWidth={300}. This option can be applied to both main and alternative solutions.bernhardoj commentedon Apr 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The scan educational tooltip light bulb icon is at the top while the text is at the bottom/
What is the root cause of that problem?
This all happens because we set the container style to flex wrap.
App/src/components/ProductTrainingContext/index.tsx
Lines 233 to 238 in e1e89c9
Since the text is too long, the text is wrapped to the bottom.
What changes do you think we should make in order to solve the problem?
Removes the flex wrap style.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
[-]In spanish, the "Light bulb" icon is left on a line alone and also outside module[/-][+][$75] In spanish, the "Light bulb" icon is left on a line alone and also outside module[/+]melvin-bot commentedon Apr 29, 2025
melvin-bot commentedon Apr 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021917011135225708614
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)117 remaining items
melvin-bot commentedon Jul 18, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 18, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-07-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 18, 2025
@eVoloshchak @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mallenexpensify commentedon Jul 24, 2025
Contributor: @davidgelhar paid $150 via Upwork
Contributor+: @eVoloshchak due $150 via NewDot
I see the above here, if anyone knows the answer.
@eVoloshchak can you fill out the BZ checklist plz? We want a regression test cuz it'll be a design/edge case one they check every month or so.
eVoloshchak commentedon Jul 25, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: the expected result has changed since this issue was created, but the original bug was caused by the tooltip not resizing properly when switching the locale to Spanish. This can be traced back to Add
useStyleUtilshook #32498, but the PR is 2 years old, I'm unable to verify that it's indeed the cause[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
MarioExpensify commentedon Jul 28, 2025
Thank you @eVoloshchak. @mallenexpensify with the BZ checklist filled, can we close this one?
mallenexpensify commentedon Jul 29, 2025
Closing meow, test case created
garrettmknight commentedon Dec 18, 2025
$150 approved for @eVoloshchak