Repository navigation
Split bill - When writing a comment, Who paid gets hidden #6077
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to https://staging.new.expensify.com
- Click FAB + > Split bill
- Enter amount and click next
4 It will show attendee select screen, So select two or more attendees and click next - You will land at confirmation page.
- Write a comment
Expected Result:
When writing a comment, we should see the function who paid
Actual Result:
When writing a comment, ''Who paid'' is hiding
Workaround:
n/a
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
**Version Number:1.1.10-0
**Reproducible in staging?:Y
**Reproducible in production?:Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Video
Expensify/Expensify Issue URL:
**Issue reported by:Applause
Slack conversation:
Activity
MelvinBot commentedon Oct 27, 2021
Triggered auto assignment to @zanyrenney (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Oct 27, 2021
Triggered auto assignment to @TomatoToaster (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.zanyrenney commentedon Oct 27, 2021
I can't test this properly as i can't upgrade wallet due to no SSN > needing to do ondifo with US credentials:
reassigning autoassigner to get someone US.
MelvinBot commentedon Oct 27, 2021
Triggered auto assignment to @mallenexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.zanyrenney commentedon Oct 27, 2021
thanks @mallenexpensify !
TomatoToaster commentedon Oct 27, 2021
I might work on this if I can recreate this locally. I'm not sure yet if this needs to be internal, but please wait on the proposals until I try it out.
mallenexpensify commentedon Oct 27, 2021
@mvtglobally I'm a lil confused
If a user is requesting payment, then no payments would have been made at this point in the flow, right?
This is what I'm seeing when attempting to reproduce. Can you provide more details/examples and any screenshots that might be helpful?
TomatoToaster commentedon Oct 28, 2021
Wanna bump this because I also want to understand the issue. Is it that when you add too many people, the Who paid gets cut off (in small mobile screens)?
That does happen here:
But you can still scroll up and down the list to see
Who Paidand theWho Was There@mvtglobally Are you saying we should "fix position of" the
Who Paidpart and scroll only theWho Was Therein this case? I think that's not a super big deal what do you think @mallenexpensifymvtglobally commentedon Oct 30, 2021
@TomatoToaster When you look at the video in the issue, experience between mWeb and App is different.
In one case, when you write a comment the page and "Who paid" gets shifted to the top and not visible.
In another case, "Who was there" section gets hidden behind the keyboard and "Who Paid" clearly visible on top.
It makes sense to see "Who paid" on top, but not sure what should be the right experience.
We are raising inconsistency between platforms.
TomatoToaster commentedon Nov 1, 2021
Aha! I didn't realize it would look different between Mobile app and mWeb, alright let me look into that. Thanks!
TomatoToaster commentedon Nov 1, 2021
Ah ok I see it's just that the keyboard is taking up the view vs. the keyboard overlaying on top of the view. hmm I don't think this is that big of an issue even though it is a slight inconsitency between mWeb and mobile. You can see everything again once you hide the keyboard. What do you think @mallenexpensify, should I close this?
If this is worth fixing I'll apply the external label, I'm not sure how to solve this one.
mvtglobally commentedon Nov 2, 2021
Issue reproducible during KI retests.
TomatoToaster commentedon Nov 2, 2021
Discussed with @mallenexpensify, I think we can close this. The discrepancy is a good find @mvtglobally, but this might be more tricky to make uniform than it's worth (it might just be part of how iOS shows keyboards in Safari vs Mobile Apps).
Since you can see who paid after closing the keyboard again, it's still functional.