Skip to content

[Due for payment 2025-05-20] [$250] Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN #60783

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9 1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: User Settings

Action Performed:

  1. Launch app
  2. Tap account
  3. Tap inbox and quickly long press "domains" and take the finger when page transitioned to LHN

Expected Result:

Tapping inbox & quickly long press "domains" must not show copy url to clipboard in LHN.

Actual Result:

Tapping inbox & quickly long press "domains" shows copy url to clipboard in LHN.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021917323258674579490
  • Upwork Job ID: 1917323258674579490
  • Last Price Increase: 2025-04-29
  • Automatic offers:
    • thelullabyy | Contributor | 107118305
Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 24, 2025
  2. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. thelullabyy commented on Apr 24, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN

    What is the root cause of that problem?

    • When a user long-presses a button and then navigates to another screen before the long-press action completes, the event handler for the long-press still fires after the configured delay. This results in unintended behavior on the previous screen.

      onSecondaryInteraction={item.link ? (event) => openPopover(item.link, event) : undefined}

    What changes do you think we should make in order to solve the problem?

    • Introduce a guard clause in the long-press handler to ensure it only executes if the user is still on the /settings screen. If the screen has changed, the handler should return early to avoid applying unintended logic.
    const openPopover = (link: string | (() => Promise<string>) | undefined, event: GestureResponderEvent | MouseEvent) => {
        if (Navigation.getActiveRoute() !== '/settings') {
            return;
        }
    • This approach prevents the delayed long-press action from firing if the user has already navigated away.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • N/A

    What alternative solutions did you explore? (Optional)

  4. melvin-bot commented on Apr 29, 2025

    @melvin-bot

    @johncschuster Huh... This is 4 days overdue. Who can take care of this?

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 29, 2025
  6. changed the title [-]Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN[/-] [+][$250] Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN[/+] on Apr 29, 2025
  7. melvin-bot commented on Apr 29, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 29, 2025
  9. melvin-bot commented on Apr 29, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  10. rushatgabhane commented on Apr 29, 2025

    @rushatgabhane
    Member

    🎀👀🎀 looks good #60783 (comment)

  11. 20 remaining items

  12. johncschuster commented on May 20, 2025

    @johncschuster
    Contributor

    Payment Summary

    Contributor: @thelullabyy paid $250 via Upwork ✅
    Contributor+: @rushatgabhane owed $ via NewDot

    @rushatgabhane can you complete the BZ Checklist above? Thank you!

  13. johncschuster commented on May 23, 2025

    @johncschuster
    Contributor
  14. melvin-bot commented on May 27, 2025

    @melvin-bot

    @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. johncschuster commented on May 27, 2025

    @johncschuster
    Contributor

    Bumped in Slack

  16. rushatgabhane commented on May 27, 2025

    @rushatgabhane
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/35601/files#r2110541807

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N.A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Not needed. This bug isn't worth adding a new test for

    Do we agree 👍 or 👎

  17. johncschuster commented on May 28, 2025

    @johncschuster
    Contributor

    @mjasikowski do you agree we don't need a regression test here?

  18. mjasikowski commented on May 29, 2025

    @mjasikowski
    Contributor

    @johncschuster I think a regression test would be nice, I imagine this can be frustrating when triggered accidentally:

    1. Tap account
    2. Tap inbox and quickly long press "domains, stop pressing when the page has transitioned to LHN
    3. Verify that no "Copy URL to clipboard" prompt appears
  19. johncschuster commented on May 30, 2025

    @johncschuster
    Contributor

    Sweet. Thanks, @mjasikowski!

  20. johncschuster commented on May 30, 2025

    @johncschuster
    Contributor

    @rushatgabhane please request payment via ND!

  21. garrettmknight commented on Jun 5, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions