You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-20] [$250] Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN #60783
Version Number: V9 1.32-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 phone App Component: User Settings
Action Performed:
Launch app
Tap account
Tap inbox and quickly long press "domains" and take the finger when page transitioned to LHN
Expected Result:
Tapping inbox & quickly long press "domains" must not show copy url to clipboard in LHN.
Actual Result:
Tapping inbox & quickly long press "domains" shows copy url to clipboard in LHN.
Please re-state the problem that we are trying to solve in this issue.
Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN
What is the root cause of that problem?
When a user long-presses a button and then navigates to another screen before the long-press action completes, the event handler for the long-press still fires after the configured delay. This results in unintended behavior on the previous screen.
What changes do you think we should make in order to solve the problem?
Introduce a guard clause in the long-press handler to ensure it only executes if the user is still on the /settings screen. If the screen has changed, the handler should return early to avoid applying unintended logic.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N.A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Not needed. This bug isn't worth adding a new test for
Activity
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon Apr 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
When a user long-presses a button and then navigates to another screen before the long-press action completes, the event handler for the long-press still fires after the configured delay. This results in unintended behavior on the previous screen.
App/src/pages/settings/InitialSettingsPage.tsx
Line 364 in e1e89c9
What changes do you think we should make in order to solve the problem?
/settingsscreen. If the screen has changed, the handler should return early to avoid applying unintended logic.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Apr 29, 2025
@johncschuster Huh... This is 4 days overdue. Who can take care of this?
[-]Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN[/-][+][$250] Android - Settings - Tapping inbox & quickly long press "domains" shows copy clipboard in LHN[/+]melvin-bot commentedon Apr 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021917323258674579490
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)rushatgabhane commentedon Apr 29, 2025
🎀👀🎀 looks good #60783 (comment)
20 remaining items
johncschuster commentedon May 20, 2025
Payment Summary
Contributor: @thelullabyy paid $250 via Upwork ✅
Contributor+: @rushatgabhane owed $ via NewDot
@rushatgabhane can you complete the BZ Checklist above? Thank you!
johncschuster commentedon May 23, 2025
@rushatgabhane bump!
melvin-bot commentedon May 27, 2025
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!
johncschuster commentedon May 27, 2025
Bumped in Slack
rushatgabhane commentedon May 27, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/35601/files#r2110541807
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N.A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Not needed. This bug isn't worth adding a new test for
Do we agree 👍 or 👎
johncschuster commentedon May 28, 2025
@mjasikowski do you agree we don't need a regression test here?
mjasikowski commentedon May 29, 2025
@johncschuster I think a regression test would be nice, I imagine this can be frustrating when triggered accidentally:
johncschuster commentedon May 30, 2025
Sweet. Thanks, @mjasikowski!
johncschuster commentedon May 30, 2025
@rushatgabhane please request payment via ND!
garrettmknight commentedon Jun 5, 2025
$250 approved for @rushatgabhane