Repository navigation
[Due for payment 2025-06-11] [$250] Onboarding - Each time user reenters a digit in magic code field, it validates #60818
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - No OTP prompt on prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #54912
Email or phone of affected tester (no customers): letos9a575@agiuse.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other
Action Performed:
- Go to staging.new.expensify.com
- Log in with this private domain email - @agiuse.com
- Enter name > Continue.
- On magic code page, enter any code (any code will be the incorrect code).
- After app throws error, click on the first digit field.
- Enter any digit.
Expected Result:
After changing the first digit, the code input field will move to the next digit.
Actual Result:
After changing the first digit, the code input field does not move to the next digit. The code revalidates each time a digit is changed. If user wants to change the entire fields, they will have to click on the field six times to reenter the code.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6811628_1745497182936.20250424_201313.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021915749339838034868
- Upwork Job ID: 1915749339838034868
- Last Price Increase: 2025-04-25
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @greg-schroederMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 24, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 24, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nlemma commentedon Apr 24, 2025
@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
rlinoz commentedon Apr 24, 2025
Probably from #54912 that introduced the feature?
cc: @parasharrajat @allroundexperts
allroundexperts commentedon Apr 24, 2025
Hm... I am not sure what the expected behaviour here is. @rlinoz We did not add a submit button in the UI, and as such, we have to submit when the field has all characters filled in.
49 remaining items
[-][$250] Onboarding - Each time user reenters a digit in magic code field, it validates[/-][+][Due for payment 2025-06-11] [$250] Onboarding - Each time user reenters a digit in magic code field, it validates[/+]melvin-bot commentedon Jun 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 4, 2025
@parasharrajat / @allroundexperts @greg-schroeder @parasharrajat / @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
parasharrajat commentedon Jun 9, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not an issue. We changed the design.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Verify that after changing the first digit, the code input field will move to the next digit.
Do we agree 👍 or 👎
greg-schroeder commentedon Jun 10, 2025
Payment summary here looks good and regression test is filed. Both @parasharrajat and @allroundexperts can make a manual request via ND for payment tomorrow, 2025-06-11.
melvin-bot commentedon Jun 11, 2025
Payment Summary
Upwork Job
BugZero Checklist (@greg-schroeder)
parasharrajat commentedon Jun 27, 2025
Payment requested as per #60818 (comment)
JmillsExpensify commentedon Jul 9, 2025
$250 approved for @parasharrajat
trjExpensify commentedon Jan 5, 2026
approved $250 for @allroundexperts.