Repository navigation
Android - Onboarding - No error message for wrong magic code on private domain #60823
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check - no OTP prompt on prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #54912
Email or phone of affected tester (no customers): akabskoshis@agiuse.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other
Action Performed:
- Launch Expensify app.
- Log in with this private domain email - @agiuse.com
- Enter name > Continue.
- On magic code page, enter any code (any code will be the incorrect code).
Expected Result:
There will be a message saying "Invalid code".
Actual Result:
There is an error but it is missing message.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
github-actions commentedon Apr 24, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 24, 2025
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nlemma commentedon Apr 24, 2025
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
5 remaining items
blimpich commentedon Apr 24, 2025
Discussing here: https://expensify.slack.com/archives/C01GTK53T8Q/p1745512280269079
Personally I'd say this is on the edge of being a deploy blocker for me, because it (A) only happens on Android and (B) only happens when they put the wrong code in and (C) still shows UI indicating an error, just no text, and (D) doesn't prevent them from continuing in the onboarding flow.
melvin-bot commentedon Apr 24, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Apr 24, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
blimpich commentedon Apr 24, 2025
We have a fix in the works here: #60856
blimpich commentedon Apr 24, 2025
Hmm, weird, I didn't close this, and it should be kept open. We're still QA-ing. Weird automation mishap.
blimpich commentedon Apr 25, 2025
Fixed in the latest version of staging, see comment: https://expensify.slack.com/archives/C9YU7BX5M/p1745551573463889?thread_ts=1745525448.219759&cid=C9YU7BX5M