Skip to content

[Better Expense Report View] Invoice - Invoice expense can be held which leads to error #60834

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.32-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #60119
Email or phone of affected tester (no customers): applausetester+240413kh@applause.expensifail.com
Issue reported by:
Applause - Internal Team

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Workspace has enabled invoicing feature
  1. Go to staging.expensify.com
  2. Go to Reports
  3. Click Create Report dropdown
  4. Select Invoice
  5. Create two expenses iin the invoice report, then click Send and send it to anyone
  6. Log in to staging.new.expensify.com with the same account
  7. Go to the invoice report
  8. Select one invoice transaction via checkbox
  9. Click on the dropdown
  10. Click Hold
  11. Enter reason and save it
  12. Click on the invoice that is held

Expected Result:

In Step 10, Hold option will not be available for invoice because invoice cannot be held

Actual Result:

In Step 10, Hold option is available for invoice
In Step 12, after holding the invoice, the invoice thread throws error "Unexpected error holding this expense. Please try again later."

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6811738_1745505907735.20250424_223709.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JakubKorytko

Activity

  1. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Apr 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 24, 2025
  5. changed the title [-]Invoice - Invoice expense can be held which leads to error[/-] [+][Better Expense Report View] Invoice - Invoice expense can be held which leads to error[/+] on Apr 24, 2025
  6. moved this to Second Cohort - CRITICAL in [#whatsnext] #migrateon Apr 24, 2025
  7. mountiny commented on Apr 24, 2025

    @mountiny
    Contributor

    This is behind beta so we can demote. @JakubKorytko would you be able to take a look please?

    @pecanoro thanks for handling, feel free to assign to me as I am helping with the project, but also feel free to keep it :D

  8. JakubKorytko commented on Apr 24, 2025

    @JakubKorytko
    Member

    @JakubKorytko would you be able to take a look please?

    Sure, I will take a look tommorow

  9. JakubKorytko commented on Apr 25, 2025

    @JakubKorytko
    Member

    I've spoken to @jnowakow and it's probably related to the new secondary actions in the header, so he'll look into it as he has more context.

  10. allgandalf commented on May 6, 2025

    @allgandalf
    Contributor

    PR on production, good to close

  11. pecanoro commented on May 8, 2025

    @pecanoro
    Contributor

    Sounds good! Closing then!

  12. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions