[Payment Due 5/23] [$250] Incorrect button bottom spacing on the Request Early Cancellation page.

@jayeshmangwani

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Open the app and go to Settings -> Subscription.
If the user has an annual plan and a card added, you will see the "Request early cancellation" button.
Press the button (or go directly to this link https://staging.new.expensify.com/settings/subscription/request-early-cancellation-survey ).
Observe the bottom button.
(The same issue occurs on this page (https://staging.new.expensify.com/settings/subscription/disable-auto-renew-survey ) as well.)

Expected Result:

The bottom button currently has 40px of spacing, but it should be 20px like the other bottom buttons in the app.

Actual Result:

Incorrect button bottom padding spacing(40px) on the Request Early Cancellation page.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

Platforms Tested:

On which of our officially supported platforms was this issue tested:

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021919799293357443334
Upwork Job ID: 1919799293357443334
Last Price Increase: 2025-05-06

Issue Owner

Current Issue Owner: @JS00001

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jayeshmangwani

Proposal by @jayeshmangwani

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect button spacing is observed on the Request Early Cancellation page.

What is the root cause of that problem?

On the RequestEarlyCancellationPage, we use the FeedbackSurvey component to display the content.

App/src/pages/settings/Subscription/RequestEarlyCancellationPage/index.tsx

Lines 100 to 103 in c93cde5

    
           const surveyContent = useMemo( 
        
               () => ( 
        
                   <FeedbackSurvey 
        
                       formID={ONYXKEYS.FORMS.REQUEST_EARLY_CANCELLATION_FORM}

Within FeedbackSurvey, we use FormProvider as the page container, which has a default 20px bottom padding.

App/src/components/FeedbackSurvey.tsx

Lines 103 to 105 in c93cde5

    
           <FormProvider 
        
               formID={formID} 
        
               style={[styles.flexGrow1, styles.justifyContentBetween]}

Additionally, on this page, we use FixedFooter to display the bottom submit button, and FixedFooter also has its own default 20px bottom padding.

App/src/components/FeedbackSurvey.tsx

Lines 137 to 139 in c93cde5

    
           <FixedFooter> 
        
               {!!footerText && footerText} 
        
               <FormAlertWithSubmitButton

As a result, the 20px bottom padding is applied twice, causing extra spacing.

What changes do you think we should make in order to solve the problem?

We can add paddingBottom: 0 style to the FixedFooter here to fix this double padding issue.

App/src/components/FeedbackSurvey.tsx

Lines 137 to 139 in c93cde5

    
           <FixedFooter> 
        
               {!!footerText && footerText} 
        
               <FormAlertWithSubmitButton

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is purely a UI issue. I am not sure if we want to add any tests for the UI padding bugs.

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@CortneyOfstad

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@CortneyOfstad

@CortneyOfstad 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Sorry for the delay, I was OoO when this was assigned. I am able to see the spacing issue as well, so getting eyes on this. Thanks!

Job added to Upwork: https://www.upwork.com/jobs/~021919799293357443334

@CortneyOfstad

@CortneyOfstad , in the future, for (what appears to be) easy fixes like this, please start the price at $125. Thx

@CortneyOfstad

@CortneyOfstad The automation failed here. The PR was merged on the 16th, and the payment is due on the 23rd.

@jayeshmangwani

Thanks @jayeshmangwani! I will get that sorted ASAP.

@eh2077 — can you complete the checklist at your earliest convenience? Once that is done, I can get the Payment Summary out ASAP. Thanks!

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other: Reported by contributor

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: NA. This is from PR feat: Subscription settings UI #42990 but it's a minor UI issue, so I hesitate to left a comment.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

It's simple UI fix, so I don't think we need a regression test here.

@jayeshmangwani

Payment Summary

@jayeshmangwani — to be paid $250 via NewDot
@eh2077 — to be paid $250 via NewDot

Regression Test

Not needed per comment here

@eh2077

$250 approved for @eh2077

@jayeshmangwani

$250 approved for @jayeshmangwani

Navigation Menu

Repository navigation

[Payment Due 5/23] [$250] Incorrect button bottom spacing on the Request Early Cancellation page. #60980

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

9 remaining items

BugZero Checklist:

Payment Summary

Regression Test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const surveyContent = useMemo(
	() => (
	<FeedbackSurvey
	formID={ONYXKEYS.FORMS.REQUEST_EARLY_CANCELLATION_FORM}

	<FormProvider
	formID={formID}
	style={[styles.flexGrow1, styles.justifyContentBetween]}

	<FixedFooter>
	{!!footerText && footerText}
	<FormAlertWithSubmitButton

[Payment Due 5/23] [$250] Incorrect button bottom spacing on the Request Early Cancellation page. #60980

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 28, 2025

m-natarajan commented on Apr 28, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 2, 2025

melvin-bot commented on May 6, 2025

CortneyOfstad commented on May 6, 2025

melvin-bot commented on May 6, 2025

9 remaining items

mallenexpensify commented on May 12, 2025

jayeshmangwani commented on May 21, 2025

CortneyOfstad commented on May 23, 2025

eh2077 commented on May 23, 2025

BugZero Checklist:

CortneyOfstad commented on May 23, 2025

Payment Summary

Regression Test

JmillsExpensify commented on May 29, 2025

garrettmknight commented on Jun 5, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions