You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-20] [$250] Error in archived task "Set up categories" when disabling category in another workspace #61006
Version Number: 9.1.33-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):sdjiosnjosjosjd@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Other
Action Performed:
Go to staging.new.expensify.com
Log in with a new Gmail account (don't use + account).
Click Skip on work email step.
Select Manage my team's expenses.
Select 1-10 employees > Continue.
Select any accounting software > Continue.
Go to Account > Workspaces.
Delete the workspace.
Create a new workspace.
Go to workspace settings > Categories.
Disable any category.
Note that there is task complete sound in the background after disabling the category.
Go back to Inbox.
Open the task report "Set up categories".
Expected Result:
The task report "Set up categories" should not be marked when the original workspace is deleted and category in another workspace is disabled.
Actual Result:
The task report "Set up categories" is marked when the original workspace is deleted and category in another workspace is disabled.
As a result, the task report shows the error "You don't have permission to take the requested action" because the task report is archived.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
🚨 Edited by proposal-police: This proposal was edited at 2025-04-29 04:33:46 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Error in archived task "Set up categories" when disabling category in another workspace
What is the root cause of that problem?
This happen when we try to complete an onboarding task when we disable a category but we actually not checking if the report has been archived/ onboarding workspace has been deleted here
changed the title [-][$250] Error in archived task "Set up categories" when disabling category in another workspace[/-][+][Due for payment 2025-05-20] [$250] Error in archived task "Set up categories" when disabling category in another workspace[/+]on May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193@kadiealexander@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 29, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 29, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samranahm commentedon Apr 29, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-29 04:33:46 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Error in archived task "Set up categories" when disabling category in another workspace
What is the root cause of that problem?
This happen when we try to complete an onboarding task when we disable a category but we actually not checking if the report has been archived/ onboarding workspace has been deleted here
App/src/libs/actions/Task.ts
Lines 1281 to 1283 in bd0f3f2
What changes do you think we should make in order to solve the problem?
We should add
isArchivedReportWithIDhereWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
We can check if the category belong to same workspace/ onboarding workspace, before calling
completeTaskhere
App/src/libs/actions/Task.ts
Lines 1282 to 1284 in bd0f3f2
32 remaining items
[-][$250] Error in archived task "Set up categories" when disabling category in another workspace[/-][+][Due for payment 2025-05-20] [$250] Error in archived task "Set up categories" when disabling category in another workspace[/+]melvin-bot commentedon May 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2025
@hungvu193 @kadiealexander @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
kadiealexander commentedon May 21, 2025
Payments needed:
@hungvu193 please complete the checklist!
hungvu193 commentedon May 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/60608/files#r2099600075
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
https://github.com/Expensify/Expensify/issues/503657
Regression Test Proposal
Test:
Set up categoriestask is archived and not marked as completed.Do we agree 👍 or 👎
kadiealexander commentedon May 22, 2025
Payment summary here.
garrettmknight commentedon Jun 3, 2025
$250 approved for @hungvu193