You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-20] [$150] Expensify Card - Limit input page shows error after incorrect magic code is entered #61051
Version Number: 9.1.33-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+khcategory19@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace has enabled Expensify Card feature and has set up bank account.
Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Click Issue card.
Fill in the details and reach the confirmation page.
On confirmation page, enter incorrect magic code.
Now enter the correct magic code.
Click Issue card.
Select any member.
Select any card type > Next.
Select Limit type > Next.
Expected Result:
Limit input page will not show error.
Actual Result:
Limit input page shows error - You must be a domain admin to create the virtual card.
However, when validating with incorrect magic code, We don’t send policyID together with CreateAdminIssuedVirtualCard, so BE send error in issueNewExpensifyCard with no policyID
So we're not clearing the correct Onyx entry and the error persists.
What changes do you think we should make in order to solve the problem?
BE should return error in correct Onyx entry
To fix this in FE, create a new Onyx key for issueNewExpensifyCard, then we should update clearIssueNewCardError to clear error in issueNewExpensifyCard as well
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@dukenv0307@joekaufmanexpensify@dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Precondition: Workspace has enabled Expensify Card feature and has set up bank account.
Go to workspace settings > Expensify Card.
Click Issue card.
Select Virtual card type
Fill in the details and reach the confirmation page.
On confirmation page, enter incorrect magic code.
Now enter the correct magic code.
Click Issue card.
Select any member.
Select Virtual card type > Next.
Select Limit type > Next.
Verify that: Limit input page will not show error.
This is a pretty niche bug. Only applicable if you're issuing multiple cards in short succession and incorrectly enter magic code when issuing the first one. I don't think we need to have QA test this flow in every test run as it is not likely to be something commonly done by actual users. Going to skip the test for now.
Activity
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Apr 29, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-01 16:28:53 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Limit input page shows error - You must be a domain admin to create the virtual card.
What is the root cause of that problem?
We already have logics to clear error here
App/src/pages/workspace/expensifyCard/issueNew/ConfirmationStep.tsx
Line 148 in b1fcf20
App/src/libs/actions/Card.ts
Lines 373 to 375 in b1fcf20
However, when validating with incorrect magic code, We don’t send
policyIDtogether withCreateAdminIssuedVirtualCard, so BE send error inissueNewExpensifyCardwith nopolicyIDSo we're not clearing the correct Onyx entry and the error persists.
What changes do you think we should make in order to solve the problem?
issueNewExpensifyCard, then we should updateclearIssueNewCardErrorto clear error inissueNewExpensifyCardas wellApp/src/libs/actions/Card.ts
Lines 373 to 375 in b1fcf20
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
I don't think we need one, because it's error when sending API.
What alternative solutions did you explore? (Optional)
We should pass
policyIDtoCreateAdminIssuedVirtualCardparametersApp/src/libs/actions/Card.ts
Lines 768 to 775 in 3941adf
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
joekaufmanexpensify commentedon Apr 30, 2025
Reproduced. The error clears if you proceed past it, so it's no major impact. But it's confusing so feels worth cleaning it up.
melvin-bot commentedon Apr 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021917579859517676775
[-]Expensify Card - Limit input page shows error after incorrect magic code is entered[/-][+][$250] Expensify Card - Limit input page shows error after incorrect magic code is entered[/+]melvin-bot commentedon Apr 30, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)28 remaining items
melvin-bot commentedon May 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2025
@dukenv0307 @joekaufmanexpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dukenv0307 commentedon May 14, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/59996/files#r2089426301
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
joekaufmanexpensify commentedon May 19, 2025
Will handle next steps today so we're prepped to pay tomorrow
joekaufmanexpensify commentedon May 19, 2025
This is a pretty niche bug. Only applicable if you're issuing multiple cards in short succession and incorrectly enter magic code when issuing the first one. I don't think we need to have QA test this flow in every test run as it is not likely to be something commonly done by actual users. Going to skip the test for now.
joekaufmanexpensify commentedon May 19, 2025
All set to pay tomorrow! We need to pay:
joekaufmanexpensify commentedon May 20, 2025
@mkzie2 $150 sent and contract ended!
joekaufmanexpensify commentedon May 20, 2025
Upwork job closed.
joekaufmanexpensify commentedon May 20, 2025
@dukenv0307 Please request payment at your earliest convenience. Closing as this is otherwise all set!
JmillsExpensify commentedon May 22, 2025
$150 approved for @dukenv0307