Skip to content

Workspace - Workspace owner can be selected during bulk selection in Members page #61129

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.38-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #60218
Email or phone of affected tester (no customers): djidjidjdijdid@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Workspace Settings

Action Performed:

  1. Launch Expensify app.
  2. Go to workspace settings > Members.
  3. Tap Invite member.
  4. Invite a member.
  5. Long press on the invited member.
  6. Tap Select.
  7. Tap on your account (owner).

Expected Result:

Workspace owner cannot be selected.

Actual Result:

Workspace owner can be selected.
When selecting any option from the dropdown when owner is selected (Remove members etc), the options do not work.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6817179_1745977717919.ScreenRecording_04-30-2025_09-46-21_1.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 30, 2025
  2. melvin-bot commented on Apr 30, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 30, 2025

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 30, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 30, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. aldo-expensify commented on Apr 30, 2025

    @aldo-expensify
    Contributor

    This is being caused by #60218, I tested with this revert: #61131

  7. aldo-expensify commented on Apr 30, 2025

    @aldo-expensify
    Contributor
  8. aldo-expensify commented on Apr 30, 2025

    @aldo-expensify
    Contributor

    This doesn't seem as simple as doing this change here:

    +                    if (!item.isDisabledCheckbox) {
                            onCheckboxPress?.(item);
    +                    }

    because I think we should also not trigger the "touch" effect if we are not going to do anything:

    Screen.Recording.2025-04-30.at.12.19.16.PM.mov
  9. aldo-expensify commented on Apr 30, 2025

    @aldo-expensify
    Contributor

    I think we should just revert #61131 and make a new PR considering better this case.

  10. aldo-expensify commented on Apr 30, 2025

    @aldo-expensify
    Contributor
  11. NikkiWines commented on Apr 30, 2025

    @NikkiWines
    Contributor

    App only blocker

  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 30, 2025
  13. mountiny commented on Apr 30, 2025

    @mountiny
    Contributor

    Thanks Aldo! PR being cherry picked

  14. aldo-expensify commented on May 1, 2025

    @aldo-expensify
    Contributor

    Tested in staging, can't reproduce anymore, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions