Skip to content

[Due for payment 2025-06-18] [$250] [Multi-Scan] Create Multi-Scan educational pop-up #61180

Closed

Description

@cristipaval

Part of the Bring Multi-Scan to NewDot Mobile project

Main issue: https://github.com/Expensify/Expensify/issues/465328
Doc section: https://docs.google.com/document/d/1ZjSjfIM7N8jhBwyYA4nz3Fe0cvOEXdu-6FA3pethL1Q/edit?tab=t.0#bookmark=id.yv3wtdzdnfb8
Project: #covert

Feature Description

Implement the Multi-Scan educational popup, according to the doc section linked above.

Image

Manual Test Steps

Automated Tests

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021925984216180449692
  • Upwork Job ID: 1925984216180449692
  • Last Price Increase: 2025-05-23
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. changed the title [-]Create Multi-Scan educational pop-up[/-] [+][Multi-Scan] Create Multi-Scan educational pop-up[/+] on May 1, 2025
  2. cristipaval commented on May 12, 2025

    @cristipaval
    ContributorAuthor

    No update

  3. koko57 commented on May 15, 2025

    @koko57
    Contributor

    Hi, I'm Agata from Callstack, I can help @VickyStash with this issue :)

  4. cristipaval commented on May 15, 2025

    @cristipaval
    ContributorAuthor

    Great! thanks a lot

  5. koko57 commented on May 15, 2025

    @koko57
    Contributor

    @cristipaval @dubielzyk-expensify may I ask for access to Figma? I've already sent a request

  6. 48 remaining items

  7. changed the title [-][$250] [Multi-Scan] Create Multi-Scan educational pop-up[/-] [+][Due for payment 2025-06-18] [$250] [Multi-Scan] Create Multi-Scan educational pop-up[/+] on Jun 11, 2025
  8. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jun 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.64-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @koko57 does not require payment (Contractor)
    • @dukenv0307 requires payment through NewDot Manual Requests
  10. dukenv0307 commented on Jun 12, 2025

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: New feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    • mweb/mobile:
    1. Start expense creation flow -> Scan.
    2. Turn on multi-scan - verify that the pop-up appears on the screen
    3. Click got it - verify that the modal is closed
    4. Leave the flow, start the flow again
    5. Repeat steps 1 and 2, but this time verify that the pop-up doesn't appear
    • web/desktop:
    1. Make sure the scan expense creation works the same way as before.

    Do we agree 👍 or 👎

  11. melvin-bot commented on Jun 18, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @koko57 is from an agency-contributor and not due payment
    • Reviewer: @dukenv0307 owed $250 via NewDot

    BugZero Checklist (@dylanexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1925984216180449692/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. melvin-bot commented on Jun 23, 2025

    @melvin-bot

    @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

  13. dylanexpensify commented on Jun 24, 2025

    @dylanexpensify
    Contributor

    Payment summary:

    Contributor+: @dukenv0307 $250 via NewDot

    Please apply/request!

  14. flaviadefaria commented on Aug 4, 2025

    @flaviadefaria
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions