Skip to content

[Due for payment 2025-05-20] [$250] The header for track expense is different from regular expenses #61196

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.38-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation (hyperlinked to channel name): #Migrate

Action Performed:

  1. Track a manual expense
  2. Navigate to the expense details
  3. Observe the header

Expected Result:

The header format for all expenses, including "Track Expense" and regular expenses, should be consistent and follow the pattern:
$x.xx for [merchant/description]

Actual Result:

The "Track Expense" header uses a different format than regular expenses:
Tracking $x.xx for [Description]

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021917699897823842474
  • Upwork Job ID: 1917699897823842474
  • Last Price Increase: 2025-04-30
  • Automatic offers:
    • FitseTLT | Contributor | 107139891
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 30, 2025
  2. melvin-bot commented on Apr 30, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. FitseTLT commented on Apr 30, 2025

    @FitseTLT
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-04-30 14:43:16 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The header for track expense is different from regular expenses

    What is the root cause of that problem?

    WE are using a different copy threadTrackReportName which says tracking ... for track expense

    App/src/libs/ReportUtils.ts

    Lines 4105 to 4107 in 03dfc95

    if (isTrackExpenseAction(reportAction)) {
    return translateLocal('iou.threadTrackReportName', {formattedAmount, comment});
    }

    threadTrackReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `Tracking ${formattedAmount} ${comment ? `for ${comment}` : ''}`,

    What changes do you think we should make in order to solve the problem?

    We can update the copy to remove tracking text

    threadTrackReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `Tracking ${formattedAmount} ${comment ? `for ${comment}` : ''}`,

            threadTrackReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `for ${comment}` : ''}`,
    
    

    and also the Spanish translation

    Or remove the code

    App/src/libs/ReportUtils.ts

    Lines 4105 to 4107 in 03dfc95

    if (isTrackExpenseAction(reportAction)) {
    return translateLocal('iou.threadTrackReportName', {formattedAmount, comment});
    }

    so that we can fallback to the common threadExpenseReportName copy to be consistent but this will have an expense appended when there is no comment but if we want to remove that or use another text more relevant with tracking we can still re-use the copy by adding a param in threadExpenseReportName copy and replace expense text accordingly for track.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    if needed we can assert the new changes on a test performed with getReportName for track expense report

    What alternative solutions did you explore? (Optional)

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 30, 2025
  5. changed the title [-]The header for track expense is different from regular expenses[/-] [+][$250] The header for track expense is different from regular expenses[/+] on Apr 30, 2025
  6. melvin-bot commented on Apr 30, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 30, 2025
  8. melvin-bot commented on Apr 30, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  9. jliexpensify commented on Apr 30, 2025

    @jliexpensify
    Contributor

    Just going to cc @Expensify/design on this (as a courtesy, if they want to review or leave feedback on what exact changes are required)

  10. shawnborton commented on May 1, 2025

    @shawnborton
    Contributor

    Thanks! I think the idea is that all expenses should use the same template for the header. Which is generally $X.XX for X

  11. jjcoffee commented on May 1, 2025

    @jjcoffee
    Contributor

    @FitseTLT's proposal LGTM! We can tweak on the PR, but I think removing the separate condition for isTrackExpenseAction altogether makes sense.

    🎀👀🎀 C+ reviewed

  12. 12 remaining items

  13. changed the title [-][$250] The header for track expense is different from regular expenses[/-] [+][Due for payment 2025-05-20] [$250] The header for track expense is different from regular expenses[/+] on May 13, 2025
  14. melvin-bot commented on May 13, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-20. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on May 13, 2025

    @melvin-bot

    @jjcoffee @jliexpensify @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. jliexpensify commented on May 19, 2025

    @jliexpensify
    Contributor

    Bumping @jjcoffee for the checklist please!

  18. jjcoffee commented on May 19, 2025

    @jjcoffee
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A this was originally implemented intentionally

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Track a manual expense
    2. Navigate to the expense details
    3. Verify that the header text does not contain a Tracking prefix

    Do we agree 👍 or 👎

  19. jliexpensify commented on May 20, 2025

    @jliexpensify
    Contributor

    Payment Summary

    • C: @FitseTLT $250 (to be paid via Upworks)
    • C+: @jjcoffee $250 (to be paid via New Expensify requests)

    Upwork job

  20. garrettmknight commented on May 20, 2025

    @garrettmknight
    Contributor

    $250 approved fro @jjcoffee

  21. jliexpensify commented on May 21, 2025

    @jliexpensify
    Contributor

    Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions