You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-20] [$250] The header for track expense is different from regular expenses #61196
Version Number: 9.1.38-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@jamesdeanexpensify Slack conversation (hyperlinked to channel name): #Migrate
Action Performed:
Track a manual expense
Navigate to the expense details
Observe the header
Expected Result:
The header format for all expenses, including "Track Expense" and regular expenses, should be consistent and follow the pattern:
$x.xx for [merchant/description]
Actual Result:
The "Track Expense" header uses a different format than regular expenses:
Tracking $x.xx for [Description]
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
so that we can fallback to the common threadExpenseReportName copy to be consistent but this will have an expense appended when there is no comment but if we want to remove that or use another text more relevant with tracking we can still re-use the copy by adding a param in threadExpenseReportName copy and replace expense text accordingly for track.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
if needed we can assert the new changes on a test performed with getReportName for track expense report
What alternative solutions did you explore? (Optional)
changed the title [-]The header for track expense is different from regular expenses[/-][+][$250] The header for track expense is different from regular expenses[/+]on Apr 30, 2025
changed the title [-][$250] The header for track expense is different from regular expenses[/-][+][Due for payment 2025-05-20] [$250] The header for track expense is different from regular expenses[/+]on May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jjcoffee@jliexpensify@jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A this was originally implemented intentionally
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Track a manual expense
Navigate to the expense details
Verify that the header text does not contain a Tracking prefix
Activity
melvin-bot commentedon Apr 30, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Apr 30, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-30 14:43:16 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The header for track expense is different from regular expenses
What is the root cause of that problem?
WE are using a different copy
threadTrackReportNamewhich saystracking ...for track expenseApp/src/libs/ReportUtils.ts
Lines 4105 to 4107 in 03dfc95
App/src/languages/en.ts
Line 1064 in 03dfc95
What changes do you think we should make in order to solve the problem?
We can update the copy to remove tracking text
App/src/languages/en.ts
Line 1064 in 03dfc95
and also the Spanish translation
Or remove the code
App/src/libs/ReportUtils.ts
Lines 4105 to 4107 in 03dfc95
so that we can fallback to the common threadExpenseReportName copy to be consistent but this will have an expense appended when there is no comment but if we want to remove that or use another text more relevant with tracking we can still re-use the copy by adding a param in threadExpenseReportName copy and replace
expensetext accordingly for track.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
if needed we can assert the new changes on a test performed with getReportName for track expense report
What alternative solutions did you explore? (Optional)
[-]The header for track expense is different from regular expenses[/-][+][$250] The header for track expense is different from regular expenses[/+]melvin-bot commentedon Apr 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021917699897823842474
melvin-bot commentedon Apr 30, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)jliexpensify commentedon Apr 30, 2025
Just going to cc @Expensify/design on this (as a courtesy, if they want to review or leave feedback on what exact changes are required)
shawnborton commentedon May 1, 2025
Thanks! I think the idea is that all expenses should use the same template for the header. Which is generally
$X.XX for Xjjcoffee commentedon May 1, 2025
@FitseTLT's proposal LGTM! We can tweak on the PR, but I think removing the separate condition for
isTrackExpenseActionaltogether makes sense.🎀👀🎀 C+ reviewed
12 remaining items
[-][$250] The header for track expense is different from regular expenses[/-][+][Due for payment 2025-05-20] [$250] The header for track expense is different from regular expenses[/+]melvin-bot commentedon May 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2025
@jjcoffee @jliexpensify @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jliexpensify commentedon May 19, 2025
Bumping @jjcoffee for the checklist please!
jjcoffee commentedon May 19, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A this was originally implemented intentionally
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
TrackingprefixDo we agree 👍 or 👎
jliexpensify commentedon May 20, 2025
Payment Summary
Upwork job
garrettmknight commentedon May 20, 2025
$250 approved fro @jjcoffee
jliexpensify commentedon May 21, 2025
Paid and job closed!