Skip to content

Update new tooltips in the backend so that dismissal persists #61244

Closed

Description

@flaviadefaria

Coming from #57045, we're adding new tooltips in these 2 PRs:

#58540

#59950

However, if the user dismisses them, signs out, and signs in again, these tooltips show again. We need some backend changes so that the new tooltip dismissal persists in the backend.

cc @ishpaul777 @rayane-d

Activity

  1. added
    Hot PickReady for an engineer to pick up and run with
    InternalRequires API changes or must be handled by Expensify staff
    on May 1, 2025
  2. self-assigned this
    on May 1, 2025
  3. removed
    Hot PickReady for an engineer to pick up and run with
    on May 1, 2025
  4. moved this to Second Cohort - HIGH in [#whatsnext] #migrateon May 1, 2025
  5. neil-marcellini commented on May 1, 2025

    @neil-marcellini
    Contributor

    I don't see the tooltip constants from #58540 anymore. I think maybe they have been removed?

    #59950 I can work on this one though.

  6. rayane-d commented on May 1, 2025

    @rayane-d
    Contributor

    I don't see the tooltip constants from #58540 anymore. I think maybe they have been removed?

    @neil-marcellini They are available on the latest main, here:

    App/src/CONST.ts

    Lines 6995 to 6996 in f7c1995

    GBR_RBR_CHAT: 'chatGBRRBR',
    ACCOUNT_SWITCHER: 'accountSwitcher',

    The constant that we need to add on backend side are:
    chatGBRRBR, accountSwitcher, outstandingFilter, settingsTab, workspacesSettings

  7. neil-marcellini commented on May 1, 2025

    @neil-marcellini
    Contributor

    😅 ha right thanks, will add those

  8. neil-marcellini commented on May 1, 2025

    @neil-marcellini
    Contributor

    The PR is up for review!

  9. melvin-bot commented on May 9, 2025

    @melvin-bot

    @neil-marcellini, @flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. flaviadefaria commented on May 12, 2025

    @flaviadefaria
    ContributorAuthor

    @neil-marcellini, thanks for grabbing this one. I believe we're all done and can now close this?

  11. flaviadefaria commented on May 13, 2025

    @flaviadefaria
    ContributorAuthor

    I'll close this, but reopen in case I missed anything.

  12. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions