Skip to content

[$500] Reports - "Hold" option doesn´t reappear on context menu after unapproving expense #61276

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.39-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+641@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Delayed submissions and approvals enabled.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat.
  3. Submit a manual expense.
  4. Tap on "Submit" and "Approve" on expense preview.
  5. Navigate to "Reports"
  6. Long tap on the just submitted expense and select it.
  7. Tap on the dropdown menu.
  8. Note that "Hold" option is not available.
  9. Open the expense report and tap on the header.
  10. Tap on "Unapprove"
  11. Once redirected to expenses list again, select the same expense.
  12. Tap on the dropdown menu.
  13. Note that "Hold" option didn´t reappear.
  14. Navigate to workspace chat again.
  15. Long tap on expense preview.
  16. Note that "Hold" option is available on context menu.

Expected Result:

"Hold" option should reappear between the expense´s options after unapproving it on "Reports" section.

Actual Result:

"Hold" option doesn´t reappear on expense´s options after unapproving it on "Reports"

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6818963_1746135372180.Unapproved.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021918077092751112095
  • Upwork Job ID: 1918077092751112095
  • Last Price Increase: 2025-06-03
  • Automatic offers:
    • ishakakkad | Contributor | 107614341
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on May 1, 2025
  2. melvin-bot commented on May 1, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 1, 2025

    @melvin-bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 1, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 1, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 1, 2025
  7. 73 remaining items

  8. ishakakkad commented on Jun 16, 2025

    @ishakakkad
    Contributor

    @rushatgabhane PR is ready to review

  9. rushatgabhane commented on Jun 16, 2025

    @rushatgabhane
    Member

    okayy, ty!!

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Jul 1, 2025
  11. luacmartins commented on Jul 1, 2025

    @luacmartins
    Contributor

    @kadiealexander could you help process payment for @rushatgabhane and @ishakakkad? We closed their PR because the issue was fixed (probably as part of a duplicate issue). We should still process compensation since they worked on the PR and it was ready to be merged.

  12. kadiealexander commented on Jul 2, 2025

    @kadiealexander
    Contributor

    Payments needed:

  13. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Jul 2, 2025
  14. garrettmknight commented on Jul 3, 2025

    @garrettmknight
    Contributor

    $500 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions