Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: V9.1.39-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6034716
Email or phone of affected tester (no customers): Slottwo1 7@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Money Requests
Action Performed:
- Launch app
- Go to workspace settings - more features - enable tags
- Add a tag
- Tap settings
- Change tag name as qpjg/(#)<✓> and save it
- Open workspace chat
- Tap plus icon - create expense
- Enter an account and tap next
- In confirmation page, note tag is displayed without bottom text cut off
- Tap tag
- Note in title tag header bottom cut off
- Select a tag
- In confirmation page,after selecting tag, now note tag is displayed with bottom text cut off
Expected Result:
Tag text should be displayed clearly and fully both:
In the tag selection header, and
On the confirmation page after selecting the tag.
Actual Result:
Before selecting the tag: it appears correctly on the confirmation screen.
After selecting the tag:
Tag header in selection screen has bottom cut-off.
Confirmation screen now shows the tag with bottom text cut off.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021920084657829428632
- Upwork Job ID: 1920084657829428632
- Last Price Increase: 2025-05-07
- Automatic offers:
- nkdengineer | Contributor | 107262002
Activity
melvin-bot commentedon May 2, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon May 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Before selecting the tag: it appears correctly on the confirmation screen.
What is the root cause of that problem?
We don't set the lineHeight for headerText in
App/src/components/Header.tsx
Line 79 in 223a34c
What changes do you think we should make in order to solve the problem?
We should add
for
styles.headerTextWe did the same for mutedTextLabel
Or we can add
lineHeightin here only but I think we should fix globallyWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI bug
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Result
github-actions commentedon May 2, 2025
melvin-bot commentedon May 5, 2025
@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon May 7, 2025
@abekkala Eep! 4 days overdue now. Issues have feelings too...
[-]Android - Tags - Tag text bottom cut off in tag selector header[/-][+][$250] Android - Tags - Tag text bottom cut off in tag selector header[/+]melvin-bot commentedon May 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021920084657829428632
melvin-bot commentedon May 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)21 remaining items
[-][$250] Android - Tags - Tag text bottom cut off in tag selector header[/-][+][Due for payment 2025-05-28] [$250] Android - Tags - Tag text bottom cut off in tag selector header[/+]melvin-bot commentedon May 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 21, 2025
@shubham1206agra @abekkala @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon May 21, 2025
PAYMENT SUMMARY FOR MAY 28
Please complete checklist
abekkala commentedon May 28, 2025
@nkdengineer payment sent and contract ended - thank you! 🎉
@shubham1206agra please complete the checklsit above. thanks!
shubham1206agra commentedon May 29, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA since offending code is too old to be actually blamed
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/505851
Regression Test Proposal
Test:
Do we agree 👍 or 👎
abekkala commentedon May 29, 2025
thank you @shubham1206agra
PAYMENT SUMMARY FOR MAY 28
garrettmknight commentedon Jun 19, 2025
$250 approved for @shubham1206agra