Skip to content

[Due for payment 2025-05-28] [$250] Android - Tags - Tag text bottom cut off in tag selector header #61298

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.1.39-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6034716
Email or phone of affected tester (no customers): Slottwo1 7@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Money Requests

Action Performed:

  1. Launch app
  2. Go to workspace settings - more features - enable tags
  3. Add a tag
  4. Tap settings
  5. Change tag name as qpjg/(#)<✓> and save it
  6. Open workspace chat
  7. Tap plus icon - create expense
  8. Enter an account and tap next
  9. In confirmation page, note tag is displayed without bottom text cut off
  10. Tap tag
  11. Note in title tag header bottom cut off
  12. Select a tag
  13. In confirmation page,after selecting tag, now note tag is displayed with bottom text cut off

Expected Result:

Tag text should be displayed clearly and fully both:

In the tag selection header, and

On the confirmation page after selecting the tag.

Actual Result:

Before selecting the tag: it appears correctly on the confirmation screen.

After selecting the tag:

Tag header in selection screen has bottom cut-off.

Confirmation screen now shows the tag with bottom text cut off.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021920084657829428632
  • Upwork Job ID: 1920084657829428632
  • Last Price Increase: 2025-05-07
  • Automatic offers:
    • nkdengineer | Contributor | 107262002
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 2, 2025
  2. melvin-bot commented on May 2, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on May 2, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Before selecting the tag: it appears correctly on the confirmation screen.

    What is the root cause of that problem?

    We don't set the lineHeight for headerText in

    style={[styles.headerText, styles.textLarge, textStyles]}

    What changes do you think we should make in order to solve the problem?

    We should add

    lineHeight: variables.lineHeightLarge
    

    for styles.headerText

    We did the same for mutedTextLabel

    Or we can add lineHeight in here only but I think we should fix globally

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    UI bug

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

    Result

    Image
  4. github-actions commented on May 2, 2025

    @github-actions
    Contributor

    ⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  5. melvin-bot commented on May 5, 2025

    @melvin-bot

    @abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. melvin-bot commented on May 7, 2025

    @melvin-bot

    @abekkala Eep! 4 days overdue now. Issues have feelings too...

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 7, 2025
  8. changed the title [-]Android - Tags - Tag text bottom cut off in tag selector header[/-] [+][$250] Android - Tags - Tag text bottom cut off in tag selector header[/+] on May 7, 2025
  9. melvin-bot commented on May 7, 2025

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 7, 2025
  11. melvin-bot commented on May 7, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  12. 21 remaining items

  13. changed the title [-][$250] Android - Tags - Tag text bottom cut off in tag selector header[/-] [+][Due for payment 2025-05-28] [$250] Android - Tags - Tag text bottom cut off in tag selector header[/+] on May 21, 2025
  14. melvin-bot commented on May 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-28. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on May 21, 2025

    @melvin-bot

    @shubham1206agra @abekkala @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. abekkala commented on May 21, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR MAY 28

  18. abekkala commented on May 28, 2025

    @abekkala
    Contributor

    @nkdengineer payment sent and contract ended - thank you! 🎉

    @shubham1206agra please complete the checklsit above. thanks!

  19. shubham1206agra commented on May 29, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA since offending code is too old to be actually blamed

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/505851

    Regression Test Proposal

    Test:

    1. Launch the app
    2. Go to workspace settings - more features - enable tags
    3. Add a tag
    4. Tap settings
    5. Change tag name as qpjg/(#)<✓> and save it
    6. Open workspace chat
    7. Tap the plus icon - create expense
    8. Enter an account and tap Next
    9. In the confirmation page, verify that tag is displayed without the bottom text cut off
    10. Tap tag
    11. Verify that the title tag header bottom is not cut off
    12. Select a tag
    13. In the confirmation page, after selecting the tag, verify that the tag is displayed without the bottom text cut off

    Do we agree 👍 or 👎

  20. abekkala commented on May 29, 2025

    @abekkala
    Contributor

    thank you @shubham1206agra

    PAYMENT SUMMARY FOR MAY 28

  21. garrettmknight commented on Jun 19, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions