Skip to content

[Payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task #61303

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.39-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): hejejejsjs@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Launch Expensify app.
  2. Log in with a new Gmail account.
  3. Select Something else during onboarding.
  4. Complete the rest of the onboarding.
  5. Note that there is GBR for Concierge chat in LHN.
  6. Open the Concierge chat.

Expected Result:

In Step 5, there should be no GBR for Concierge chat in LHN because there is no onboarding task in Concierge when "Something else" is chosen during onboarding.

Actual Result:

In Step 5, GBR appears for Concierge chat in LHN when "Something else" is chosen during onboarding.
In Step 6, Concierge chat has no onboarding task or user mention which does not explain the GBR in LHN after completing onboarding.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6819248_1746165651766.ScreenRecording_05-02-2025_13-55-51_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021919537281589595711
  • Upwork Job ID: 1919537281589595711
  • Last Price Increase: 2025-05-05
  • Automatic offers:
    • gijoe0295 | Contributor | 107200681
Issue OwnerCurrent Issue Owner: @lydiabarclay

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 2, 2025
  2. melvin-bot commented on May 2, 2025

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. gijoe0295 commented on May 2, 2025

    @gijoe0295
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task

    What is the root cause of that problem?

    We set the lastMentionedTime for the target report where onboarding tasks would be posted which can either be Concierge chat or workspace admin room:

    lastMentionedTime: DateUtils.getDBTime(),

    Which then makes isUnreadWithMention true and shows GBR:

    App/src/libs/ReportUtils.ts

    Lines 3344 to 3348 in 9f2767b

    if (isUnreadWithMention(optionOrReport)) {
    return {
    reason: CONST.REQUIRES_ATTENTION_REASONS.IS_UNREAD_WITH_MENTION,
    };
    }

    What changes do you think we should make in order to solve the problem?

    We don't need lastMentionedTime here since no real "mention" message is created. Even in case there're onboarding tasks and we should show GBR, we already have hasOutstandingChildTask attribute. I think lastMentionedTime here is redundant because I compared with BE response and no lastMentionedTime was returned. It was added in this PR #39951.

    So we should remove lastMentionedTime from that optimistic report.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  4. lydiabarclay commented on May 3, 2025

    @lydiabarclay
    Contributor

    @Expensify/design I'm curious about this one - my first instinct was that a GBR kind of makes sense here because it's directing you to interact with Concierge for the first time, which is what we want. But is that wrong, and it's actually a bug?

  5. dubielzyk-expensify commented on May 5, 2025

    @dubielzyk-expensify
    Contributor

    I wonder if we actually added this so that the tooltip would show accurate:

    Image

    cc @zanyrenney @puneetlath @danielrvidal (or however can remember 😅)

  6. shawnborton commented on May 5, 2025

    @shawnborton
    Contributor

    Hmm that feels like a bug to me - if there is nothing in the Concierge chat that actually generates a GBR, I don't think we should show one in the LHN.

  7. dannymcclain commented on May 5, 2025

    @dannymcclain
    Contributor

    Hmm that feels like a bug to me - if there is nothing in the Concierge chat that actually generates a GBR, I don't think we should show one in the LHN.

    Agree with this. I think forcing it undermines what the GBR/RBR is supposed to be. If we desperately want a GBR on that Concierge chat, let's add a mention to the first message or something that will actually create a GBR. (Or maybe this is just a bug and we should fix it haha)

  8. puneetlath commented on May 5, 2025

    @puneetlath
    Contributor

    Agreed that seems like a bug. It's weird that we have a lastMentionedTime set on the chat if the user wasn't actually mentioned in the message. I wonder if we were manually setting that for some reason, as @dubielzyk-expensify mentioned, as a way to force the GBR for that tooltip or something. In any case, I think we should fix it.

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 5, 2025
  10. changed the title [-]LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-] [+][$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+] on May 5, 2025
  11. melvin-bot commented on May 5, 2025

    @melvin-bot
  12. 29 remaining items

  13. lydiabarclay commented on May 22, 2025

    @lydiabarclay
    Contributor
    • ND setup is a WIP for @ZhenjaHorbach
    • As agreed, will hold this issue for their payment until ND setup is complete
  14. changed the title [-][Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-] [+][HOLD] [Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+] on May 22, 2025
  15. changed the title [-][HOLD] [Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-] [+][HOLD payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+] on May 22, 2025
  16. lydiabarclay commented on Jun 19, 2025

    @lydiabarclay
    Contributor

    ND setup complete, payment summary above is correct!

  17. changed the title [-][HOLD payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-] [+][Payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+] on Jun 19, 2025
  18. ZhenjaHorbach commented on Jun 19, 2025

    @ZhenjaHorbach
    Contributor

    Requested in ND

  19. garrettmknight commented on Jun 26, 2025

    @garrettmknight
    Contributor

    $250 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions