You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task #61303
Version Number: 9.1.39-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):hejejejsjs@gmail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.4 App Component: Left Hand Navigation (LHN)
Action Performed:
Launch Expensify app.
Log in with a new Gmail account.
Select Something else during onboarding.
Complete the rest of the onboarding.
Note that there is GBR for Concierge chat in LHN.
Open the Concierge chat.
Expected Result:
In Step 5, there should be no GBR for Concierge chat in LHN because there is no onboarding task in Concierge when "Something else" is chosen during onboarding.
Actual Result:
In Step 5, GBR appears for Concierge chat in LHN when "Something else" is chosen during onboarding.
In Step 6, Concierge chat has no onboarding task or user mention which does not explain the GBR in LHN after completing onboarding.
What changes do you think we should make in order to solve the problem?
We don't need lastMentionedTime here since no real "mention" message is created. Even in case there're onboarding tasks and we should show GBR, we already have hasOutstandingChildTask attribute. I think lastMentionedTime here is redundant because I compared with BE response and no lastMentionedTime was returned. It was added in this PR #39951.
So we should remove lastMentionedTime from that optimistic report.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
@Expensify/design I'm curious about this one - my first instinct was that a GBR kind of makes sense here because it's directing you to interact with Concierge for the first time, which is what we want. But is that wrong, and it's actually a bug?
Hmm that feels like a bug to me - if there is nothing in the Concierge chat that actually generates a GBR, I don't think we should show one in the LHN.
Hmm that feels like a bug to me - if there is nothing in the Concierge chat that actually generates a GBR, I don't think we should show one in the LHN.
Agree with this. I think forcing it undermines what the GBR/RBR is supposed to be. If we desperately want a GBR on that Concierge chat, let's add a mention to the first message or something that will actually create a GBR. (Or maybe this is just a bug and we should fix it haha)
Agreed that seems like a bug. It's weird that we have a lastMentionedTime set on the chat if the user wasn't actually mentioned in the message. I wonder if we were manually setting that for some reason, as @dubielzyk-expensify mentioned, as a way to force the GBR for that tooltip or something. In any case, I think we should fix it.
changed the title [-]LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+]on May 5, 2025
changed the title [-][Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][HOLD] [Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+]on May 22, 2025
changed the title [-][HOLD] [Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][HOLD payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+]on May 22, 2025
changed the title [-][HOLD payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][Payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+]on Jun 19, 2025
Activity
melvin-bot commentedon May 2, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.gijoe0295 commentedon May 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task
What is the root cause of that problem?
We set the
lastMentionedTimefor the target report where onboarding tasks would be posted which can either be Concierge chat or workspace admin room:App/src/libs/ReportUtils.ts
Line 9879 in 9f2767b
Which then makes
isUnreadWithMentiontrue and shows GBR:App/src/libs/ReportUtils.ts
Lines 3344 to 3348 in 9f2767b
What changes do you think we should make in order to solve the problem?
We don't need
lastMentionedTimehere since no real "mention" message is created. Even in case there're onboarding tasks and we should show GBR, we already havehasOutstandingChildTaskattribute. I thinklastMentionedTimehere is redundant because I compared with BE response and nolastMentionedTimewas returned. It was added in this PR #39951.So we should remove
lastMentionedTimefrom that optimistic report.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
lydiabarclay commentedon May 3, 2025
@Expensify/design I'm curious about this one - my first instinct was that a GBR kind of makes sense here because it's directing you to interact with Concierge for the first time, which is what we want. But is that wrong, and it's actually a bug?
dubielzyk-expensify commentedon May 5, 2025
I wonder if we actually added this so that the tooltip would show accurate:
cc @zanyrenney @puneetlath @danielrvidal (or however can remember 😅)
shawnborton commentedon May 5, 2025
Hmm that feels like a bug to me - if there is nothing in the Concierge chat that actually generates a GBR, I don't think we should show one in the LHN.
dannymcclain commentedon May 5, 2025
Agree with this. I think forcing it undermines what the GBR/RBR is supposed to be. If we desperately want a GBR on that Concierge chat, let's add a mention to the first message or something that will actually create a GBR. (Or maybe this is just a bug and we should fix it haha)
puneetlath commentedon May 5, 2025
Agreed that seems like a bug. It's weird that we have a
lastMentionedTimeset on the chat if the user wasn't actually mentioned in the message. I wonder if we were manually setting that for some reason, as @dubielzyk-expensify mentioned, as a way to force the GBR for that tooltip or something. In any case, I think we should fix it.[-]LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+]melvin-bot commentedon May 5, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021919537281589595711
29 remaining items
lydiabarclay commentedon May 22, 2025
[-][Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][HOLD] [Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+][-][HOLD] [Due for payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][HOLD payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+]lydiabarclay commentedon Jun 19, 2025
ND setup complete, payment summary above is correct!
[-][HOLD payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/-][+][Payment 2025-05-22] [$250] LHN - GRB appears for Concierge chat in LHN after onboarding when there is no onboarding task[/+]ZhenjaHorbach commentedon Jun 19, 2025
Requested in ND
garrettmknight commentedon Jun 26, 2025
$250 approved for @ZhenjaHorbach