Skip to content

[Due for payment 2025-05-14] [$250] Expense - Unable to exit selection mode in expense report without closing expense report #61320

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.39-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+x27@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Submit two expenses.
  4. Tap on the expense preview.
  5. Long tap on any expense.
  6. Tap Select.
  7. Try to exit selection mode without having to close the expense report.

Expected Result:

User should be able to exit selection mode without having to close the expense report.

Actual Result:

There is no way to exit the selection mode without having to close the expense report via app back button on the top left.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6819388_1746178295714.ScreenRecording_05-02-2025_17-21-42_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021918353232385500146
  • Upwork Job ID: 1918353232385500146
  • Last Price Increase: 2025-05-02
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 2, 2025
  2. melvin-bot commented on May 2, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on May 2, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There is no way to exit the selection mode without having to close the expense report via app back button on the top left.

    What is the root cause of that problem?

    When users press back button in the header, we always trigger navigation to go back to the previous page

    What changes do you think we should make in order to solve the problem?

    Update HeaderWithBackButton to turn off selection mode if it's enabled in

    onPress={() => {
    if (Keyboard.isVisible()) {
    Keyboard.dismiss();

    const {selectionMode} = useMobileSelectionMode();
    ...
    if (Keyboard.isVisible()) {
                                        Keyboard.dismiss();
                                    }
                                    if(selectionMode?.isEnabled){
                                        turnOffMobileSelectionMode()
                                        return
                                    }
    

    we should check other places like this and apply the same solution

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. allgandalf commented on May 2, 2025

    @allgandalf
    Contributor

    @jnowakow please look into fixing this one on Monday

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 2, 2025
  6. changed the title [-]Expense - Unable to exit selection mode in expense report without closing expense report[/-] [+][$250] Expense - Unable to exit selection mode in expense report without closing expense report[/+] on May 2, 2025
  7. melvin-bot commented on May 2, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 2, 2025
  9. melvin-bot commented on May 2, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

  10. ishakakkad commented on May 4, 2025

    @ishakakkad
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-05-04 07:10:49 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Unable to exit selection mode in expense report without closing expense report

    What is the root cause of that problem?

    There are no way in UI to exit the selection mode without going back to previous screen.

    What changes do you think we should make in order to solve the problem?

    • We should add some button like cancel or exist or icon inside the the HeaderWithBackButton, this button only visible if selectionMode is on. Button placement decision needs to discussed with design team. (For ex, in whatsapp we have cancel button to exist the selection mode)

    pass shouldDisplayExistSelectionModeButton pass as a props

    OR

    const shouldDisplayExistSelectionModeButton = selectionMode?.isEnabled && shouldShowBackButton;
    
    OR 
    
    const shouldDisplayExistSelectionModeButton = selectionMode?.isEnabled && isNarrowScreen;
    
    {shouldDisplayExistSelectionModeButton && <ExistSeletionModeButton />} 
    

    We can create ExistSeletionModeButton component same way we have help button Or we can add the logic into HeaderWithBackButton itself.

    https://github.com/Expensify/App/blob/main/src/components/SidePanel/HelpComponents/HelpButton.tsx#L16

    • onPress event of button we should exist the selection mode.
    onPress={() => {
      turnOffMobileSelectionMode();
    }}
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None UI changes

    What alternative solutions did you explore? (Optional)

    Another option is to, we can hide the back button when selection mode is on and show the Cancel button. (In Whatsapp if we are in selection mode it hide the back button and shows the close button). And follow same logic of main proposal.

    {shouldShowBackButton && (

    {shouldShowBackButton && !shouldDisplayExistSelectionModeButton (
    

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  11. jnowakow commented on May 5, 2025

    @jnowakow
    Contributor

    I'll handle this one

  12. 18 remaining items

  13. melvin-bot commented on May 14, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @jnowakow is from an agency-contributor and not due payment
    • Reviewer: @ishpaul777 owed $250 via NewDot

    BugZero Checklist (@garrettmknight)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1918353232385500146/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. garrettmknight commented on May 15, 2025

    @garrettmknight
    Contributor

    @ishpaul777 checklist please!

  15. ishpaul777 commented on May 16, 2025

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/60430/files#r2093621803

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: no need

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Log in with Expensifail account.

    Test:

    1. Launch Expensify app.
    2. Go to workspace chat.
    3. Submit two expenses.
    4. Tap on the expense preview.
    5. Long tap on any expense.
    6. Tap Select.
    7. Try to exit selection mode without having to close the expense report.

    Expected result : User should be able to exit selection mode without having to close the expense report.

    Do we agree 👍 or 👎

  16. melvin-bot commented on May 19, 2025

    @melvin-bot

    @garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. garrettmknight commented on May 20, 2025

    @garrettmknight
    Contributor

    Getting payment summary so I can approve.

  18. JmillsExpensify commented on May 20, 2025

    @JmillsExpensify
    Contributor

    Payment summary: @ishpaul777 $250 via NewDot

  19. garrettmknight commented on May 20, 2025

    @garrettmknight
    Contributor

    @ishpaul777 request when ready.

  20. garrettmknight commented on Jun 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions