You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-14] [$250] Expense - Unable to exit selection mode in expense report without closing expense report #61320
Version Number: 9.1.39-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+x27@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.4 App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Launch Expensify app.
Go to workspace chat.
Submit two expenses.
Tap on the expense preview.
Long tap on any expense.
Tap Select.
Try to exit selection mode without having to close the expense report.
Expected Result:
User should be able to exit selection mode without having to close the expense report.
Actual Result:
There is no way to exit the selection mode without having to close the expense report via app back button on the top left.
we should check other places like this and apply the same solution
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - Unable to exit selection mode in expense report without closing expense report[/-][+][$250] Expense - Unable to exit selection mode in expense report without closing expense report[/+]on May 2, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-04 07:10:49 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to exit selection mode in expense report without closing expense report
What is the root cause of that problem?
There are no way in UI to exit the selection mode without going back to previous screen.
What changes do you think we should make in order to solve the problem?
We should add some button like cancel or exist or icon inside the the HeaderWithBackButton, this button only visible if selectionMode is on. Button placement decision needs to discussed with design team. (For ex, in whatsapp we have cancel button to exist the selection mode)
pass shouldDisplayExistSelectionModeButton pass as a props
onPress event of button we should exist the selection mode.
onPress={() => {
turnOffMobileSelectionMode();
}}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None UI changes
What alternative solutions did you explore? (Optional)
Another option is to, we can hide the back button when selection mode is on and show the Cancel button. (In Whatsapp if we are in selection mode it hide the back button and shows the close button). And follow same logic of main proposal.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: no need
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Log in with Expensifail account.
Test:
Launch Expensify app.
Go to workspace chat.
Submit two expenses.
Tap on the expense preview.
Long tap on any expense.
Tap Select.
Try to exit selection mode without having to close the expense report.
Expected result : User should be able to exit selection mode without having to close the expense report.
Activity
melvin-bot commentedon May 2, 2025
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon May 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is no way to exit the selection mode without having to close the expense report via app back button on the top left.
What is the root cause of that problem?
When users press back button in the header, we always trigger navigation to go back to the previous page
What changes do you think we should make in order to solve the problem?
Update HeaderWithBackButton to turn off selection mode if it's enabled in
App/src/components/HeaderWithBackButton/index.tsx
Lines 162 to 164 in 223a34c
we should check other places like this and apply the same solution
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
allgandalf commentedon May 2, 2025
@jnowakow please look into fixing this one on Monday
[-]Expense - Unable to exit selection mode in expense report without closing expense report[/-][+][$250] Expense - Unable to exit selection mode in expense report without closing expense report[/+]melvin-bot commentedon May 2, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021918353232385500146
melvin-bot commentedon May 2, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (
External)ishakakkad commentedon May 4, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-04 07:10:49 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to exit selection mode in expense report without closing expense report
What is the root cause of that problem?
There are no way in UI to exit the selection mode without going back to previous screen.
What changes do you think we should make in order to solve the problem?
cancelorexistoriconinside the theHeaderWithBackButton, this button only visible if selectionMode is on. Button placement decision needs to discussed with design team. (For ex, in whatsapp we have cancel button to exist the selection mode)pass
shouldDisplayExistSelectionModeButtonpass as a propsOR
We can create
ExistSeletionModeButtoncomponent same way we have help button Or we can add the logic into HeaderWithBackButton itself.https://github.com/Expensify/App/blob/main/src/components/SidePanel/HelpComponents/HelpButton.tsx#L16
onPressevent of button we should exist the selection mode.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None UI changes
What alternative solutions did you explore? (Optional)
Another option is to, we can hide the back button when selection mode is on and show the Cancel button. (In Whatsapp if we are in selection mode it hide the back button and shows the close button). And follow same logic of main proposal.
App/src/components/HeaderWithBackButton/index.tsx
Line 159 in 223a34c
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
jnowakow commentedon May 5, 2025
I'll handle this one
18 remaining items
melvin-bot commentedon May 14, 2025
Payment Summary
Upwork Job
BugZero Checklist (@garrettmknight)
garrettmknight commentedon May 15, 2025
@ishpaul777 checklist please!
ishpaul777 commentedon May 16, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/60430/files#r2093621803
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: no need
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Expected result : User should be able to exit selection mode without having to close the expense report.
Do we agree 👍 or 👎
melvin-bot commentedon May 19, 2025
@garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
garrettmknight commentedon May 20, 2025
Getting payment summary so I can approve.
JmillsExpensify commentedon May 20, 2025
Payment summary: @ishpaul777 $250 via NewDot
garrettmknight commentedon May 20, 2025
@ishpaul777 request when ready.
garrettmknight commentedon Jun 3, 2025
$250 approved for @ishpaul777