Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.39-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3940539
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition: user is logged in ND with gmail account without workspaces.
- Click on FAB > Book travel
- Click on Book travel
Expected Result:
Message displayed as "You'll need to use your work email (e.g., name@company.com
) with Expensify Travel, not your personal email (e.g., name@gmail.com
)."
Actual Result:
Message displayed as "You'll need to use your work email (e.g., name@company.com
) with Expensify Travel, not your personal email (e.g., name@gmail.com
)"
NOTE: no dot in the end of message.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6822452_1746474943837.bandicam_2025-05-05_22-51-59-619.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021922637702785541299
- Upwork Job ID: 1922637702785541299
- Last Price Increase: 2025-05-14
- Automatic offers:
- samranahm | Contributor | 107305620
Activity
melvin-bot commentedon May 5, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon May 5, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-05 20:55:03 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Travel - Dot is missed in message
What is the root cause of that problem?
We are missing dot here
App/src/languages/en.ts
Line 2879 in a38a00c
What changes do you think we should make in order to solve the problem?
App/src/languages/en.ts
Line 2879 in a38a00c
App/src/languages/es.ts
Line 2906 in 047500f
add
.at the end of both translationsWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon May 5, 2025
melvin-bot commentedon May 9, 2025
@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!
abekkala commentedon May 9, 2025
@stitesExpensify do we want to continue with adding a period to the end of the message?
Expected Result:
Message displayed as "You'll need to use your work email (e.g., name@company.com
) with Expensify Travel, not your personal email (e.g., name@gmail.com
)."
Actual Result:
Message displayed as "You'll need to use your work email (e.g., name@company.com
) with Expensify Travel, not your personal email (e.g., name@gmail.com
)"
NOTE: no dot in the end of message.
stitesExpensify commentedon May 12, 2025
Sure, we can update that copy
melvin-bot commentedon May 13, 2025
@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Travel - Dot is missed in message[/-][+][$250] Travel - Dot is missed in message[/+]24 remaining items
[-][$100] Travel - Dot is missed in message[/-][+][Due for payment 2025-05-28] [$100] Travel - Dot is missed in message[/+]melvin-bot commentedon May 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 21, 2025
@parasharrajat @abekkala @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
parasharrajat commentedon May 21, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Minor issue.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Not needed. Translation change.
Do we agree 👍 or 👎
NathanHeuton commentedon May 21, 2025
abekkala commentedon May 21, 2025
PAYMENT SUMMARY FOR MAY 28
abekkala commentedon May 28, 2025
@samranahm payment sent and contract ended - thank you! 🎉
@parasharrajat {$100] payment will be made via NewDot - thank you!
parasharrajat commentedon Jul 28, 2025
Payment requested as per #61398 (comment)
twisterdotcom commentedon Jul 31, 2025
@parasharrajat has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
### Payment Summarycomment from @melvin-bot found. I have therefore verified this manually from the BZ payment summary above.Zapier Logs
Run ID: 00040eee-8800-a7e8-a064-ca4f5d849581