Skip to content

[Due for payment 2025-05-28] [$100] Travel - Dot is missed in message #61398

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.39-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3940539
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: user is logged in ND with gmail account without workspaces.

  1. Click on FAB > Book travel
  2. Click on Book travel

Expected Result:

Message displayed as "You'll need to use your work email (e.g., name@company.com
) with Expensify Travel, not your personal email (e.g., name@gmail.com
)."

Actual Result:

Message displayed as "You'll need to use your work email (e.g., name@company.com
) with Expensify Travel, not your personal email (e.g., name@gmail.com
)"
NOTE: no dot in the end of message.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6822452_1746474943837.bandicam_2025-05-05_22-51-59-619.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021922637702785541299
  • Upwork Job ID: 1922637702785541299
  • Last Price Increase: 2025-05-14
  • Automatic offers:
    • samranahm | Contributor | 107305620
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 5, 2025
  2. melvin-bot commented on May 5, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on May 5, 2025

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-05-05 20:55:03 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Travel - Dot is missed in message

    What is the root cause of that problem?

    We are missing dot here

    message: `You'll need to use your work email (e.g., name@company.com) with Expensify Travel, not your personal email (e.g., name@gmail.com)`,

    What changes do you think we should make in order to solve the problem?

    message: `You'll need to use your work email (e.g., name@company.com) with Expensify Travel, not your personal email (e.g., name@gmail.com)`,

    message: 'Tendrás que usar tu correo electrónico laboral (por ejemplo, nombre@empresa.com) con Expensify Travel, no tu correo personal (por ejemplo, nombre@gmail.com)',


                message: `You'll need to use your work email (e.g., name@company.com) with Expensify Travel, not your personal email (e.g., name@gmail.com).`,

    add . at the end of both translations

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. github-actions commented on May 5, 2025

    @github-actions
    Contributor

    ⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  5. melvin-bot commented on May 9, 2025

    @melvin-bot

    @abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. abekkala commented on May 9, 2025

    @abekkala
    Contributor

    @stitesExpensify do we want to continue with adding a period to the end of the message?

    Expected Result:
    Message displayed as "You'll need to use your work email (e.g., name@company.com
    ) with Expensify Travel, not your personal email (e.g., name@gmail.com
    )."

    Actual Result:
    Message displayed as "You'll need to use your work email (e.g., name@company.com
    ) with Expensify Travel, not your personal email (e.g., name@gmail.com
    )"
    NOTE: no dot in the end of message.

  7. stitesExpensify commented on May 12, 2025

    @stitesExpensify
    Contributor

    Sure, we can update that copy

  8. melvin-bot commented on May 13, 2025

    @melvin-bot

    @abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 14, 2025
  10. changed the title [-]Travel - Dot is missed in message[/-] [+][$250] Travel - Dot is missed in message[/+] on May 14, 2025
  11. 24 remaining items

  12. changed the title [-][$100] Travel - Dot is missed in message[/-] [+][Due for payment 2025-05-28] [$100] Travel - Dot is missed in message[/+] on May 21, 2025
  13. melvin-bot commented on May 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-28. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on May 21, 2025

    @melvin-bot

    @parasharrajat @abekkala @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. parasharrajat commented on May 21, 2025

    @parasharrajat
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Minor issue.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not needed

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Not needed. Translation change.

    Do we agree 👍 or 👎

  17. NathanHeuton commented on May 21, 2025

    @NathanHeuton

    Contributor details
    Your Expensify account email: nathan+jd51@yahoo.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0193cb9a05de91c999

  18. abekkala commented on May 21, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR MAY 28

  19. abekkala commented on May 28, 2025

    @abekkala
    Contributor

    @samranahm payment sent and contract ended - thank you! 🎉

    @parasharrajat {$100] payment will be made via NewDot - thank you!

  20. parasharrajat commented on Jul 28, 2025

    @parasharrajat
    Member

    Payment requested as per #61398 (comment)

  21. twisterdotcom commented on Jul 31, 2025

    @twisterdotcom
    Contributor

    @parasharrajat has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    • Vendor found in VML: True. Status: Active
    • Amount requested: $100.00. No ### Payment Summary comment from @melvin-bot found. I have therefore verified this manually from the BZ payment summary above.
    • I, @twisterdotcom am not already the BZ assignee. I have approved this payment.
    Zapier Logs Run ID: 00040eee-8800-a7e8-a064-ca4f5d849581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions