Skip to content

[Report Creation UI] Integrate the primary action logic to the empty money report preview #61513

Closed

Description

@mountiny

Coming from here #59804 (comment)

Lets integrate the primary action button in the empty state for moneyRequestPreview.

Issue OwnerCurrent Issue Owner: @sumo-slonik

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 6, 2025
  2. melvin-bot commented on May 6, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. moved this to Second Cohort - CRITICAL in [#whatsnext] #migrateon May 6, 2025
  4. nabi-ebrahimi commented on May 6, 2025

    @nabi-ebrahimi

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The empty state for moneyRequestPreview currently lacks a clear call to action, which can lead to confusion or drop-off when users encounter it with no prior money request activity.

    What is the root cause of that problem?

    The moneyRequestPreview component does not integrate the primary action logic that guides users toward creating a new expense or money request. This creates an incomplete and passive experience in the UI.

    What changes do you think we should make in order to solve the problem?

    • Integrate the primary action button into the empty state of moneyRequestPreview. For now, this will be a hardcoded "Create expense" button as a placeholder.
    • Replace the transaction row components used in the search view to ensure consistency.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    • Verify the primary action button appears in the empty state.
    • Ensure the button triggers the correct navigation or logic.
    • Validate the search view uses the updated row components once replaced.
    • Confirm no regressions are introduced in the standard (non-empty) state of moneyRequestPreview.

    What alternative solutions did you explore? (Optional)

  5. sumo-slonik commented on May 7, 2025

    @sumo-slonik
    Contributor

    Hi, I'm Kuba from SWM, and I'll take care of this.

  6. changed the title [-][Better Expense Report View] Integrate the primary action logic to the empty money report preview[/-] [+][Report Creation UI] Integrate the primary action logic to the empty money report preview[/+] on May 7, 2025
  7. SzymczakJ commented on May 9, 2025

    @SzymczakJ
    Contributor

    As we discussed with @sumo-slonik, I'll take over this issue 🙇

  8. melvin-bot commented on May 12, 2025

    @melvin-bot

    @sumo-slonik Huh... This is 4 days overdue. Who can take care of this?

  9. SzymczakJ commented on May 12, 2025

    @SzymczakJ
    Contributor

    WIP

  10. melvin-bot commented on May 13, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. trjExpensify commented on May 19, 2025

    @trjExpensify
    Contributor

    The PR for this is on prod now, so I'm going to close it out.

  12. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions