Skip to content

[Due for payment 2025-05-27] Show settlement account for admins who don't own bank account #61531

Closed

Description

@puneetlath

Part of the Cross Compatible Corporate Cards project

Main issue: https://github.com/Expensify/Expensify/issues/467915

Feature Description

Right now, if you are an admin on a workspace, but not shared on the bank account used for Expensify Card settlement, you see a blank page when you view the settlement account settings.

Image

This is true whether you are a workspace admin looking at a workspace feed's settings or a domain admin looking at a domain feed's settings. To fix this, I have updated the back-end to return paymentBankAccountAddressName and paymentBankAccountNumber in addition to paymentBankAccountID in the card settings object.

Let's update the client to use these, when the user doesn't have the bank account in their bankAccountsList. That way we can still display in the card settings which settlement account is being used.

Manual Test Steps

  1. Set up an accountOwner with a policyA and policyB
  2. invite accountAdmin to both policies as an admin
  3. set up accountOwner with a bank account and enable the Expensify Card on policyA
  4. set up a domain Expensify Card feed on the domain and set its preferred policy as policyB
  5. go to the workspace settings of policyA as accountAdmin
  6. you should be able to see the settlement account for the Expensify Cards
  7. go to the workspace settings of policyB as accountAdmin
  8. you should be able to see the settlement account for the Expensify Cards
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. self-assigned this
    on May 6, 2025
  2. added theissue type on May 6, 2025
  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 6, 2025
  4. removed theissue type on May 6, 2025
  5. melvin-bot commented on May 6, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. puneetlath commented on May 6, 2025

    @puneetlath
    ContributorAuthor

    @koko57 @VickyStash @DylanDylann would one of y'all want to take this? The back-end PR is in review, so will probably go live tomorrow or the day after. But you should be able to start on it with mock data in the meantime.

  7. DylanDylann commented on May 7, 2025

    @DylanDylann
    Contributor

    Ideally, @koko57 or @VickyStash will create the PR, and I’ll assist with the review. If neither is available, I’ll go ahead and create the PR myself.

  8. waterim commented on May 7, 2025

    @waterim
    Contributor

    Hello, Im Artem from Callstack and will help with this one

  9. puneetlath commented on May 7, 2025

    @puneetlath
    ContributorAuthor

    Great. Assigned you @waterim

  10. puneetlath commented on May 9, 2025

    @puneetlath
    ContributorAuthor

    How's it going @waterim?

  11. 24 remaining items

  12. melvin-bot commented on May 27, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @waterim is from an agency-contributor and not due payment
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@Christinadobrzyn)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. lydiabarclay commented on May 27, 2025

    @lydiabarclay
    Contributor

    Waiting on BZ checklist from @DylanDylann, also pinged in Slack

  14. DylanDylann commented on May 28, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug: Not a bug, this is a new feature
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Not a bug, this is a new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/505468

    Regression Test Proposal

    Test:

    1. Set up an accountOwner with a policyA and policyB
    2. invite accountAdmin to both policies as an admin
    3. set up accountOwner with a bank account and enable the Expensify Card on policyA
    4. set up a domain Expensify Card feed on the domain and set its preferred policy as policyB
    5. go to the workspace settings of policyA as accountAdmin
    6. you should be able to see the settlement account for the Expensify Cards
    7. go to the workspace settings of policyB as accountAdmin
    8. you should be able to see the settlement account for the Expensify Cards

    Do we agree 👍 or 👎

  15. Christinadobrzyn commented on May 29, 2025

    @Christinadobrzyn
    Contributor

    Thanks for covering this @lydiabarclay!

    I see the regression test here - #61531 (comment)

    Payment summary here - #61531 (comment)

    @DylanDylann please make sure to request payment in ND.

    Closing as complete

  16. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon May 29, 2025
  17. lydiabarclay commented on May 29, 2025

    @lydiabarclay
    Contributor

    Note:

    • ND setup is a WIP for @DylanDylann
    • As agreed, will payment request until ND setup is complete
  18. JmillsExpensify commented on Aug 7, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions