You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-27] Show settlement account for admins who don't own bank account #61531
Right now, if you are an admin on a workspace, but not shared on the bank account used for Expensify Card settlement, you see a blank page when you view the settlement account settings.
This is true whether you are a workspace admin looking at a workspace feed's settings or a domain admin looking at a domain feed's settings. To fix this, I have updated the back-end to return paymentBankAccountAddressName and paymentBankAccountNumber in addition to paymentBankAccountID in the card settings object.
Let's update the client to use these, when the user doesn't have the bank account in their bankAccountsList. That way we can still display in the card settings which settlement account is being used.
Manual Test Steps
Set up an accountOwner with a policyA and policyB
invite accountAdmin to both policies as an admin
set up accountOwner with a bank account and enable the Expensify Card on policyA
set up a domain Expensify Card feed on the domain and set its preferred policy as policyB
go to the workspace settings of policyA as accountAdmin
you should be able to see the settlement account for the Expensify Cards
go to the workspace settings of policyB as accountAdmin
you should be able to see the settlement account for the Expensify Cards
@koko57@VickyStash@DylanDylann would one of y'all want to take this? The back-end PR is in review, so will probably go live tomorrow or the day after. But you should be able to start on it with mock data in the meantime.
[Contributor] Classify the bug: Not a bug, this is a new feature
Bug classification
Source of bug:
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not a bug, this is a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon May 6, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.puneetlath commentedon May 6, 2025
@koko57 @VickyStash @DylanDylann would one of y'all want to take this? The back-end PR is in review, so will probably go live tomorrow or the day after. But you should be able to start on it with mock data in the meantime.
DylanDylann commentedon May 7, 2025
Ideally, @koko57 or @VickyStash will create the PR, and I’ll assist with the review. If neither is available, I’ll go ahead and create the PR myself.
waterim commentedon May 7, 2025
Hello, Im Artem from Callstack and will help with this one
puneetlath commentedon May 7, 2025
Great. Assigned you @waterim
puneetlath commentedon May 9, 2025
How's it going @waterim?
24 remaining items
melvin-bot commentedon May 27, 2025
Payment Summary
Upwork Job
BugZero Checklist (@Christinadobrzyn)
lydiabarclay commentedon May 27, 2025
Waiting on BZ checklist from @DylanDylann, also pinged in Slack
DylanDylann commentedon May 28, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not a bug, this is a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/505468
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Christinadobrzyn commentedon May 29, 2025
Thanks for covering this @lydiabarclay!
I see the regression test here - #61531 (comment)
Payment summary here - #61531 (comment)
@DylanDylann please make sure to request payment in ND.
Closing as complete
lydiabarclay commentedon May 29, 2025
Note:
JmillsExpensify commentedon Aug 7, 2025
$250 approved for @DylanDylann