You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Reports - "Filter for expenses that need approval" tooltip is displayed cutted off #61634
Version Number: 9.1.42-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):ibellicotest+683@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 App Component: Other
Action Performed:
Open the Expensify app.
Sign up with a new account.
Create a new workspace.
Navigate to "Reports"
Note that the tooltip displayed on outstanding filter is displayed cutted off.
Expected Result:
"Filter for expenses that need approval" tooltip should be completelly visible.
Actual Result:
"Filter for expenses that need approval" on outstanding tab on "Reports" is displayed cutted off and the "X" button to dismiss it can´t be reached. User has to scroll the filters to see the tooltip complete.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Something like... if the entire tooltip can't be shown then don't show it. Or offset it so that it's always on the right edge of the screen without overlap. It could be done, but not sure if it's worth the effort. @trjExpensify WDYT?
I really have mixed feelings on this. I have a very narrow screen phone (Z Fold) and thus the "Outstanding" filter is cut, I feel like we would be in a worst position if the tooltip appears to be pointing to the "Unreported" for very narrow phones than it being floating with the list of filters, but that is obviously my opinion.
Let's tag @Expensify/design if anyone can give us some thoughts on what would be the best way to handle this.
Yeah agree. Part of me thinks we should make this tooltip go on another filter and maybe make it more generic to avoid this issue. If we can easily scroll and shift the tooltip, then that'd be great. I got this bug yesterday and I had more cut-off than the video due to a smaller screen
Hmm I feel like we should do nothing here, these are all going to change soon with the Suggested Search project. When that happens, we'll want to change the tooltip location entirely as we won't have exposed status tabs like this.
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 8, 2025
Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 8, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 8, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
marcaaron commentedon May 8, 2025
Appears to be introduced by #59950 cc @ishpaul777 @MarioExpensify
Honestly, does not look so bad to me - but maybe could be improved? I think we make this a non-blocker or perhaps even close.
ishpaul777 commentedon May 8, 2025
same thoughts @marcaaron, @rayane-d what do you think it would be possible to improve this?
marcaaron commentedon May 8, 2025
Something like... if the entire tooltip can't be shown then don't show it. Or offset it so that it's always on the right edge of the screen without overlap. It could be done, but not sure if it's worth the effort. @trjExpensify WDYT?
MarioExpensify commentedon May 8, 2025
I really have mixed feelings on this. I have a very narrow screen phone (Z Fold) and thus the "Outstanding" filter is cut, I feel like we would be in a worst position if the tooltip appears to be pointing to the "Unreported" for very narrow phones than it being floating with the list of filters, but that is obviously my opinion.
Let's tag @Expensify/design if anyone can give us some thoughts on what would be the best way to handle this.
trjExpensify commentedon May 8, 2025
Mhm, I think we do probably need to shift it over because it has an
Xto dismiss it which is cut off right now out of view. 🤔dubielzyk-expensify commentedon May 9, 2025
Yeah agree. Part of me thinks we should make this tooltip go on another filter and maybe make it more generic to avoid this issue. If we can easily scroll and shift the tooltip, then that'd be great. I got this bug yesterday and I had more cut-off than the video due to a smaller screen
MarioExpensify commentedon May 9, 2025
A more generic text pointing to the first filter would probably solve the issue as we will always have it appearing on screen.
@rayane-d @flaviadefaria if you can take a look.
shawnborton commentedon May 9, 2025
Hmm I feel like we should do nothing here, these are all going to change soon with the Suggested Search project. When that happens, we'll want to change the tooltip location entirely as we won't have exposed status tabs like this.
trjExpensify commentedon May 9, 2025
Fair point. We'll likely want to highlight the bookmark button to lead people to the suggested searches for
Submit,Approve,Payetc.marcaaron commentedon May 9, 2025
Gonna close for now. Feel free to reopen if experiencing strong feelings.