Skip to content

Android - Reports - "Filter for expenses that need approval" tooltip is displayed cutted off #61634

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+683@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Other

Action Performed:

  1. Open the Expensify app.
  2. Sign up with a new account.
  3. Create a new workspace.
  4. Navigate to "Reports"
  5. Note that the tooltip displayed on outstanding filter is displayed cutted off.

Expected Result:

"Filter for expenses that need approval" tooltip should be completelly visible.

Actual Result:

"Filter for expenses that need approval" on outstanding tab on "Reports" is displayed cutted off and the "X" button to dismiss it can´t be reached. User has to scroll the filters to see the tooltip complete.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6825034_1746665933795.Cutted.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 8, 2025
  2. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. marcaaron commented on May 8, 2025

    @marcaaron
    Contributor

    Appears to be introduced by #59950 cc @ishpaul777 @MarioExpensify

    Honestly, does not look so bad to me - but maybe could be improved? I think we make this a non-blocker or perhaps even close.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 8, 2025
  8. ishpaul777 commented on May 8, 2025

    @ishpaul777
    Contributor

    same thoughts @marcaaron, @rayane-d what do you think it would be possible to improve this?

  9. marcaaron commented on May 8, 2025

    @marcaaron
    Contributor

    Something like... if the entire tooltip can't be shown then don't show it. Or offset it so that it's always on the right edge of the screen without overlap. It could be done, but not sure if it's worth the effort. @trjExpensify WDYT?

  10. MarioExpensify commented on May 8, 2025

    @MarioExpensify
    Contributor

    I really have mixed feelings on this. I have a very narrow screen phone (Z Fold) and thus the "Outstanding" filter is cut, I feel like we would be in a worst position if the tooltip appears to be pointing to the "Unreported" for very narrow phones than it being floating with the list of filters, but that is obviously my opinion.

    Let's tag @Expensify/design if anyone can give us some thoughts on what would be the best way to handle this.

  11. trjExpensify commented on May 8, 2025

    @trjExpensify
    Contributor

    Mhm, I think we do probably need to shift it over because it has an X to dismiss it which is cut off right now out of view. 🤔

  12. dubielzyk-expensify commented on May 9, 2025

    @dubielzyk-expensify
    Contributor

    Yeah agree. Part of me thinks we should make this tooltip go on another filter and maybe make it more generic to avoid this issue. If we can easily scroll and shift the tooltip, then that'd be great. I got this bug yesterday and I had more cut-off than the video due to a smaller screen

  13. MarioExpensify commented on May 9, 2025

    @MarioExpensify
    Contributor

    A more generic text pointing to the first filter would probably solve the issue as we will always have it appearing on screen.

    @rayane-d @flaviadefaria if you can take a look.

  14. shawnborton commented on May 9, 2025

    @shawnborton
    Contributor

    Hmm I feel like we should do nothing here, these are all going to change soon with the Suggested Search project. When that happens, we'll want to change the tooltip location entirely as we won't have exposed status tabs like this.

  15. trjExpensify commented on May 9, 2025

    @trjExpensify
    Contributor

    Fair point. We'll likely want to highlight the bookmark button to lead people to the suggested searches for Submit, Approve, Pay etc.

  16. marcaaron commented on May 9, 2025

    @marcaaron
    Contributor

    Gonna close for now. Feel free to reopen if experiencing strong feelings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions