You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-22] [$250] Expense - First expense show "card" icon after reviewing duplicates and submit another expense #61646
Version Number: 9.1.42-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail:#61273 Email or phone of affected tester (no customers):applausetester+300402kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses with the same amount and merchant.
Click on the expense preview.
Click Review duplicates.
Click Keep this one on any expense preview.
Click Confirm on the confirmation page.
Click + > Create expense > Manual.
Submit another manual expense.
Expected Result:
The first expense will show "cash" icon instead of "card" icon.
Actual Result:
The first expense show "card" icon instead of "cash" icon after reviewing duplicates and submit another expense.
It changes to "cash" icon after opening the transaction thread.
On small screen, it shows "card" text.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] Expense - First expense show "card" icon after reviewing duplicates and submit another expense[/-][+][Due for payment 2025-05-22] [$250] Expense - First expense show "card" icon after reviewing duplicates and submit another expense[/+]on May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@c3024@NicMendonca@c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No frontend PR can be held responsible because this arises from a legacy backend code.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
None
Test:
Go to workspace chat.
Submit two expenses with the same amount and merchant.
Click on the expense preview.
Click Review duplicates.
Click Keep this one on any expense preview.
Click Confirm on the confirmation page.
Click + > Create expense > Manual.
Submit another manual expense.
Verify that the type icon of the first expense remains as cash
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 8, 2025
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 8, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 8, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
madmax330 commentedon May 8, 2025
I think this is an FE issue
21 remaining items
[-][$250] Expense - First expense show "card" icon after reviewing duplicates and submit another expense[/-][+][Due for payment 2025-05-22] [$250] Expense - First expense show "card" icon after reviewing duplicates and submit another expense[/+]melvin-bot commentedon May 15, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2025
@c3024 @NicMendonca @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
c3024 commentedon May 20, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No frontend PR can be held responsible because this arises from a legacy backend code.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon May 22, 2025
Payment Summary
Upwork Job
BugZero Checklist (@NicMendonca)
NicMendonca commentedon May 23, 2025
Payment Summary
Contributor: $250 paid via NewDot
JmillsExpensify commentedon May 29, 2025
$250 approved for @c3024