Skip to content

[Due for payment 2025-05-22] [Due for payment 2025-05-20] Expense-The Change workspace option is available to the employee and the approver #61649

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #60872
Email or phone of affected tester (no customers): applausetester+ag0705e@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 14
App Component: Money Requests

Action Performed:

Pre-conditions:

  • An employee account
  • An approver account
  • An admin account
  • Workspace with all members above
  • Workflow is configured to Add approvals and approver set to approver account
  • Only use Expensifail accounts
  • Employee and approver are members of at least 2 workspaces [Just create a workspace for every user, (the employee and the approver)]
  1. Go to staging.new.expensify.com
  2. Log in with the employee account
  3. Submit an expense to the workspace
  4. [Approver] Approve the report
  5. [Employee] Verify that you don't see the Change workspace option
  6. [Approver] Verify that you don't see the Change workspace option

Expected Result:

The Change workspace option is not displayed to the employee and the approver after approving an expense report.

Actual Result:

The Change workspace option is available to the employee and the approver after approving an expense report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6825073_1746677299420.Change_workspace_option_displayed_2.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 8, 2025
  2. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MariaHCD commented on May 8, 2025

    @MariaHCD
    Contributor
  7. 15 remaining items

  8. changed the title [-][Due for payment 2025-05-20] Expense-The Change workspace option is available to the employee and the approver[/-] [+][Due for payment 2025-05-22] [Due for payment 2025-05-20] Expense-The Change workspace option is available to the employee and the approver[/+] on May 15, 2025
  9. melvin-bot commented on May 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-22. 🎊

  10. melvin-bot commented on May 15, 2025

    @melvin-bot

    @MariaHCD / @luacmartins @alexpensify @MariaHCD / @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on May 22, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  12. alexpensify commented on May 22, 2025

    @alexpensify
    Contributor

    @luacmartins—can you please confirm? Looking at the PR, I see that @rushatgabhane was a reviewer. I noticed @rayane-d was included to review, but I don't see any comments in the PR GH. Can you please confirm who should be included for payment here? I think the last Melvin update is wrong. Thanks!

  13. luacmartins commented on May 22, 2025

    @luacmartins
    Contributor

    correct, we only need to pay @rushatgabhane for the review

  14. alexpensify commented on May 22, 2025

    @alexpensify
    Contributor

    Payment Summary

    Contributor: N/A - Internal
    Contributor+: @rushatgabhane due $250 via NewDot - please submit a request in Chat, thanks!

  15. garrettmknight commented on Jun 13, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions