Skip to content

[Due for payment 2025-06-19] [$250] Split expense doesn't appear on chat history when the user scan or upload any image #61651

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #60827
Email or phone of affected tester (no customers): applausetester+rg_6@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Android 13 / Chrome, Windows 11 / Chrome
App Component: Other

Action Performed:

  1. Login using Expensifail account
  2. Start a chat with any user
  3. Tap the + > Split expense
  4. Take or upload any image
  5. Tap the Split expense

Expected Result:

Split expense should appear on chat history even though the user scan or upload any image

Actual Result:

Split expense doesn't appear on chat history when the user scan or upload any image
Note:

  • Split expense will appear on chat history when the user scan or uploads a valid receipt (after scanning is complete)
  • There New message banner will appear but truncated

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021922375848669212558
  • Upwork Job ID: 1922375848669212558
  • Last Price Increase: 2025-05-27
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 8, 2025
  2. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. bernhardoj commented on May 8, 2025

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Scan split expense doesn't show the split preview on the DM chat.

    What is the root cause of that problem?

    When using table report view, we don't show the individual expense as separate message, except for self DM and split bill in group chat.

    // Table Report View does not display these components as separate messages, except for self-DM
    if (canUseTableReportView && report?.type === CONST.REPORT.TYPE.CHAT) {
    if ((report.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM && !isDeletedAction(action)) || isSplitInGroupChat) {
    children = (
    <View style={[styles.mt1, styles.w100]}>
    <TransactionPreview
    iouReportID={getIOUReportIDFromReportActionPreview(action)}

    If we do a manual split bill, an expense preview will be shown because the amount is defined. But if we do a scan split bill, it will start scanning first before creating the expense preview. Basically, if we do split bill, there will be:

    1. split preview
    2. transaction/expense preview

    It looks like we don't want to show the split preview, except in a group chat.

    What changes do you think we should make in order to solve the problem?

    We can update the condition to show the split preview in DM too by removing the group chat check.

    const isSplitInGroupChat = moneyRequestActionType === CONST.IOU.REPORT_ACTION_TYPE.SPLIT && report?.chatType === CONST.REPORT.CHAT_TYPE.GROUP;

    if (canUseTableReportView && report?.type === CONST.REPORT.TYPE.CHAT) {
    if ((report.chatType === CONST.REPORT.CHAT_TYPE.SELF_DM && !isDeletedAction(action)) || isSplitInGroupChat) {

    If we want, we can only show it when the split type is a scan and is currently scanning.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

  4. melvin-bot commented on May 13, 2025

    @melvin-bot

    @abekkala Eep! 4 days overdue now. Issues have feelings too...

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 13, 2025
  6. melvin-bot commented on May 13, 2025

    @melvin-bot
  7. changed the title [-]Split expense doesn't appear on chat history when the user scan or upload any image[/-] [+][$250] Split expense doesn't appear on chat history when the user scan or upload any image[/+] on May 13, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 13, 2025
  9. melvin-bot commented on May 13, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  10. Ollyws commented on May 14, 2025

    @Ollyws
    Contributor

    @bernhardoj Are you still able to reproduce this? It's working fine for me on the latest main.

  11. 37 remaining items

  12. melvin-bot commented on Jun 12, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jun 12, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.65-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests
  14. melvin-bot commented on Jun 12, 2025

    @melvin-bot

    @Ollyws @abekkala @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. abekkala commented on Jun 13, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JUN 19

    • Fix: @bernhardoj [$250, if no regressions] payment via New Dot
    • PR Review: @Ollyws [$250, if no regressions] payment via New Dot
      please complete checklist
  16. melvin-bot commented on Jun 19, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@abekkala)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1922375848669212558/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. Ollyws commented on Jun 19, 2025

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/59811/files#r2156470132

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    1. Open a DM
    2. Do a split scan with any receipt
    3. Verify the split preview is shown on the chat
    

    Do we agree 👍 or 👎

  18. Ollyws commented on Jun 19, 2025

    @Ollyws
    Contributor

    Requested in ND.

  19. garrettmknight commented on Jun 19, 2025

    @garrettmknight
    Contributor

    $250 approved for @Ollyws

  20. abekkala commented on Jun 19, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY FOR JUN 19

    • Fix: @bernhardoj [$250] request payment via New Dot

    • PR Review: @Ollyws [$250] payment approved in New Dot - thank you! 🎉

  21. bernhardoj commented on Jun 20, 2025

    @bernhardoj
    Contributor

    Requested in ND.

  22. JmillsExpensify commented on Jul 2, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions