You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-19] [$250] Split expense doesn't appear on chat history when the user scan or upload any image #61651
Version Number: 9.1.42-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#60827 Email or phone of affected tester (no customers):applausetester+rg_6@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Android 13 / Chrome, Windows 11 / Chrome App Component: Other
Action Performed:
Login using Expensifail account
Start a chat with any user
Tap the + > Split expense
Take or upload any image
Tap the Split expense
Expected Result:
Split expense should appear on chat history even though the user scan or upload any image
Actual Result:
Split expense doesn't appear on chat history when the user scan or upload any image
Note:
Split expense will appear on chat history when the user scan or uploads a valid receipt (after scanning is complete)
There New message banner will appear but truncated
If we do a manual split bill, an expense preview will be shown because the amount is defined. But if we do a scan split bill, it will start scanning first before creating the expense preview. Basically, if we do split bill, there will be:
split preview
transaction/expense preview
It looks like we don't want to show the split preview, except in a group chat.
What changes do you think we should make in order to solve the problem?
We can update the condition to show the split preview in DM too by removing the group chat check.
changed the title [-]Split expense doesn't appear on chat history when the user scan or upload any image[/-][+][$250] Split expense doesn't appear on chat history when the user scan or upload any image[/+]on May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.65-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Ollyws@abekkala@Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon May 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Scan split expense doesn't show the split preview on the DM chat.
What is the root cause of that problem?
When using table report view, we don't show the individual expense as separate message, except for self DM and split bill in group chat.
App/src/pages/home/report/PureReportActionItem.tsx
Lines 807 to 813 in 1de2c6d
If we do a manual split bill, an expense preview will be shown because the amount is defined. But if we do a scan split bill, it will start scanning first before creating the expense preview. Basically, if we do split bill, there will be:
It looks like we don't want to show the split preview, except in a group chat.
What changes do you think we should make in order to solve the problem?
We can update the condition to show the split preview in DM too by removing the group chat check.
App/src/pages/home/report/PureReportActionItem.tsx
Line 786 in 1de2c6d
App/src/pages/home/report/PureReportActionItem.tsx
Lines 808 to 809 in 1de2c6d
If we want, we can only show it when the split type is a scan and is currently scanning.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
melvin-bot commentedon May 13, 2025
@abekkala Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon May 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021922375848669212558
[-]Split expense doesn't appear on chat history when the user scan or upload any image[/-][+][$250] Split expense doesn't appear on chat history when the user scan or upload any image[/+]melvin-bot commentedon May 13, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)Ollyws commentedon May 14, 2025
@bernhardoj Are you still able to reproduce this? It's working fine for me on the latest main.
37 remaining items
melvin-bot commentedon Jun 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.65-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 12, 2025
@Ollyws @abekkala @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Jun 13, 2025
PAYMENT SUMMARY FOR JUN 19
please complete checklist
melvin-bot commentedon Jun 19, 2025
Payment Summary
Upwork Job
BugZero Checklist (@abekkala)
Ollyws commentedon Jun 19, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/59811/files#r2156470132
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/515375
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Ollyws commentedon Jun 19, 2025
Requested in ND.
garrettmknight commentedon Jun 19, 2025
$250 approved for @Ollyws
abekkala commentedon Jun 19, 2025
PAYMENT SUMMARY FOR JUN 19
Fix: @bernhardoj [$250] request payment via New Dot
PR Review: @Ollyws [$250] payment approved in New Dot - thank you! 🎉
bernhardoj commentedon Jun 20, 2025
Requested in ND.
JmillsExpensify commentedon Jul 2, 2025
$250 approved for @bernhardoj