You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term #61652
Version Number: 9.1.42-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail:#60488 Email or phone of affected tester (no customers):applausetester+khcategory19@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Report fields are enabled in workspace settings > More features.
Create a list type report field with at least 16 list values.
Go to staging.new.expensify.com
Go to workspace settings > Report fields.
Click on the list type report field.
Click List values.
Enter search term in the search field.
Expected Result:
Search field will not disappear after entering search term.
Actual Result:
Search field disappears after entering search term.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Report fields - Search field disappears after entering search term
What is the root cause of that problem?
we are showing the search bar only if the length of the filtered list items is greater than 15. Once we enter some text in the search bar and the matching items list length is less than 15, the search bar disappears.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Report fields - Search field disappears after entering search term[/-][+][Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/+]on May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@sobitneupane@OfstadC@sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/+]on May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@sobitneupane@OfstadC@sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 8, 2025
Triggered auto assignment to @nkuoch (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 8, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 8, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Burhan-Rashid commentedon May 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Report fields - Search field disappears after entering search term
What is the root cause of that problem?
we are showing the search bar only if the length of the filtered list items is greater than 15. Once we enter some text in the search bar and the matching items list length is less than 15, the search bar disappears.
App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx
Lines 333 to 335 in f9942f1
Issue coming from this PR: #60488
What changes do you think we should make in order to solve the problem?
Instead of using the filtered list length
filteredListValues.length, we need to use the original list lengthdata.lengthWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nkuoch commentedon May 8, 2025
@daledah is already working on a fix
28 remaining items
[-][$250] Report fields - Search field disappears after entering search term[/-][+][Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/+]melvin-bot commentedon May 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2025
@sobitneupane @OfstadC @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 15, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
[-][Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/+]melvin-bot commentedon May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2025
@sobitneupane @OfstadC @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sobitneupane commentedon May 16, 2025
This was a regression, and it has been addressed. I believe the issue can now be closed.