Skip to content

[Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term #61652

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #60488
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Report fields are enabled in workspace settings > More features.
  • Create a list type report field with at least 16 list values.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Report fields.
  3. Click on the list type report field.
  4. Click List values.
  5. Enter search term in the search field.

Expected Result:

Search field will not disappear after entering search term.

Actual Result:

Search field disappears after entering search term.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6825246_1746684692248.20250508_140838.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021920379890102559140
  • Upwork Job ID: 1920379890102559140
  • Last Price Increase: 2025-05-15
Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on May 8, 2025
  2. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 8, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 8, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Burhan-Rashid commented on May 8, 2025

    @Burhan-Rashid
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Report fields - Search field disappears after entering search term

    What is the root cause of that problem?

    we are showing the search bar only if the length of the filtered list items is greater than 15. Once we enter some text in the search bar and the matching items list length is less than 15, the search bar disappears.

    {filteredListValues.length > CONST.SEARCH_ITEM_LIMIT && (
    <SearchBar
    label={translate('workspace.reportFields.findReportField')}

    Issue coming from this PR: #60488

    What changes do you think we should make in order to solve the problem?

    Instead of using the filtered list length filteredListValues.length, we need to use the original list length data.length

    {data?.length > CONST.SEARCH_ITEM_LIMIT && (
                        <SearchBar
                            label={translate('workspace.reportFields.findReportField')}
                            inputValue={inputValue}
                            onChangeText={setInputValue}
                            shouldShowEmptyState={!shouldShowEmptyState && filteredListValues.length === 0}
                        />
                    )}
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. nkuoch commented on May 8, 2025

    @nkuoch
    Contributor

    @daledah is already working on a fix

  8. 28 remaining items

  9. changed the title [-][$250] Report fields - Search field disappears after entering search term[/-] [+][Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/+] on May 13, 2025
  10. melvin-bot commented on May 13, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on May 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-20. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on May 13, 2025

    @melvin-bot

    @sobitneupane @OfstadC @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on May 15, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  14. changed the title [-][Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/-] [+][Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term[/+] on May 15, 2025
  15. melvin-bot commented on May 15, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-22. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on May 15, 2025

    @melvin-bot

    @sobitneupane @OfstadC @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. sobitneupane commented on May 16, 2025

    @sobitneupane
    Contributor

    This was a regression, and it has been addressed. I believe the issue can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions