You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] iOS - Workspace - After returning from role selection page, Role field is highlighted #61669
Version Number: 9.1.42-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):ghdjjdjdjsg@gmail.con Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.4 App Component: Workspace Settings
Action Performed:
Launch Expensify app.
Go to workspace settings > Members.
Invite a member if there is no other member.
Tap on the member.
Tap Role
Select other role.
Expected Result:
After returning from role selection page, Role field will not be highlighted.
Actual Result:
After returning from role selection page, Role field is highlighted.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This is reproduce-able in PROD so not a deploy blocker. Furthermore, it might be the desired behaviour (to only apply highlights to roles other than member). Will cross-check and confirm.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@s77rt@laurenreidexpensify@s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
@laurenreidexpensify This one's a unique one for me. The original issue was a regression introduced as part of an existing PR and caused a deployblocker. @nkdengineer's solution was used (even though it wasn't merged) to resolve this, therefore should be compensated. Given the urgency at the time, I directly reviewed the solution and approved it (without waiting for the contributor+ assigned: s77rt). Therefore s77rt shouldn't require a payment even though melvin-bot says otherwise.
changed the title [-][Due for payment 2025-05-20] [$250] iOS - Workspace - After returning from role selection page, Role field is highlighted[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] iOS - Workspace - After returning from role selection page, Role field is highlighted[/+]on May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@s77rt@laurenreidexpensify@s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression test needed: No, this is coming from a PR that was still in regression test period
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 8, 2025
Triggered auto assignment to @inimaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 8, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 8, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
inimaga commentedon May 8, 2025
This is reproduce-able in PROD so not a deploy blocker. Furthermore, it might be the desired behaviour (to only apply highlights to roles other than member). Will cross-check and confirm.
38 remaining items
melvin-bot commentedon May 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2025
@s77rt @laurenreidexpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
inimaga commentedon May 13, 2025
@laurenreidexpensify This one's a unique one for me. The original issue was a regression introduced as part of an existing PR and caused a deployblocker. @nkdengineer's solution was used (even though it wasn't merged) to resolve this, therefore should be compensated. Given the urgency at the time, I directly reviewed the solution and approved it (without waiting for the contributor+ assigned: s77rt). Therefore s77rt shouldn't require a payment even though melvin-bot says otherwise.
[-][Due for payment 2025-05-20] [$250] iOS - Workspace - After returning from role selection page, Role field is highlighted[/-][+][Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] iOS - Workspace - After returning from role selection page, Role field is highlighted[/+]melvin-bot commentedon May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2025
@s77rt @laurenreidexpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
laurenreidexpensify commentedon May 16, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
s77rt commentedon May 19, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Fix: add search bar to lists with items above 15 #60488
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: n/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression test needed: No, this is coming from a PR that was still in regression test period
laurenreidexpensify commentedon May 20, 2025
Payment Summary
@s77rt requires payment through NewDot Manual Requests- see [Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] iOS - Workspace - After returning from role selection page, Role field is highlighted #61669 (comment)