Skip to content

[Due for payment 2025-08-13] Fix system messages with MoveIOUReportToExistingPolicy command #61744

Closed

Description

@joekaufmanexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #convert

Action Performed:

Precondition: reproduction requires using ad-hoc build from #56838

  1. As user 1 create a workspace.
  2. As user 2 submit another IOU to user 1.
  3. As user 1, click Pay and then Pay with %workspace name% workspace. This moves the IOU to the workspace via the bottom up flow.

Expected Result:

We use the same system messages in the 1:1 DM and expense report when moving an IOU to an existing workspace for the bottom-up flow with the new MoveIOUReportToExistingPolicy command as we do with the existing CreateWorkspaceFromIOUPayment command. We should also use the same system message in both places for the MoveIOUReportToPolicyAndInviteSubmitter command. This means using the following system message:

moved this report to the [%workspace name%](link to submitter workspace chat) workspace

Actual Result:

The MoveIOUReportToExistingPolicy doesn't use the correct system messages in the 1:1 DM or expense report. We need to update it to accept a new param and generate a moved action to the DM just like CreateWorkspaceFromIOUPayment

Workaround:

N/A

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • MacOS: Chrome / Safari

Screenshots/Videos

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 8, 2025
  2. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. self-assigned this
    on May 9, 2025
  4. marcaaron commented on May 9, 2025

    @marcaaron
    Contributor

    If I'm understanding this issue correctly we'll want to do something like:

    • Stop creating the CHANGE_POLICY action in MoveIOUReportToExistingPolicy
    • Create a MOVED action which is added to the DM chat to point the submitter to the new workspace chat
    • Create a MOVED action which is added to the expense report

    Does that sound about right?

  5. marcaaron commented on May 9, 2025

    @marcaaron
    Contributor

    It looks like we should do the same for MoveIOUReportToPolicyAndInviteSubmitter?

  6. marcaaron commented on May 9, 2025

    @marcaaron
    Contributor

    WDYT @joekaufmanexpensify?

    Haven't tested the current behavior, but the behavior when we implemented MoveIOUReportToPolicyAndInviteSubmitter was something like this...

    Pre-requisite: a user (not member of any workspace), a workspace with an admin.

    [user] Request money (IOU) from admin.
    [admin] Open the IOU report and select change workspace (append /change-workspace to the URL in order to open the workspace selector).
    [admin] Move the IOU report to the admin's workspace.
    Verify that the IOU report was converted to an Expense report and the user was invited to the workspace.
    Verify that the user has a workspace chat created for them.
    Verify that the report preview was removed from the DM and added to the user's workspace chat.

  7. marcaaron commented on May 9, 2025

    @marcaaron
    Contributor

    We will need some frontend PR for both of these changes if @getusha wants to work on that while I look at the BE. Otherwise, we can search for someone else maybe @ikevin127 since he implemented MoveIOUReportToPolicyAndInviteSubmitter and should be familiar with these flows I think 🙏

  8. 72 remaining items

  9. melvin-bot commented on Aug 5, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. changed the title [-]Fix system messages with MoveIOUReportToExistingPolicy command[/-] [+][Due for payment 2025-08-13] Fix system messages with MoveIOUReportToExistingPolicy command[/+] on Aug 6, 2025
  11. melvin-bot commented on Aug 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Aug 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.89-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-08-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @getusha requires payment through NewDot Manual Requests
  13. melvin-bot commented on Aug 6, 2025

    @melvin-bot

    @getusha @joekaufmanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. joekaufmanexpensify commented on Aug 11, 2025

    @joekaufmanexpensify
    ContributorAuthor

    Frontend PR is out to prod. @getusha @hungvu193 are being paid centrally for the whole project, so no payment needed here. Closing as this is all set!

  15. Krishna2323 commented on Aug 19, 2026

    @Krishna2323
    Contributor

    The PR #66790 caused #97152. It passed an empty amount for PAY actions, but the ELSEWHERE branch could still use iou.payerSettledWithMissingBankAccount, resulting in "paid . Add a bank account to receive your payment." when copying the "marked as paid" message.

    Fixed in #97999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions