You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-13] Fix system messages with MoveIOUReportToExistingPolicy command #61744
Precondition: reproduction requires using ad-hoc build from #56838
As user 1 create a workspace.
As user 2 submit another IOU to user 1.
As user 1, click Pay and then Pay with %workspace name% workspace. This moves the IOU to the workspace via the bottom up flow.
Expected Result:
We use the same system messages in the 1:1 DM and expense report when moving an IOU to an existing workspace for the bottom-up flow with the new MoveIOUReportToExistingPolicy command as we do with the existing CreateWorkspaceFromIOUPayment command. We should also use the same system message in both places for the MoveIOUReportToPolicyAndInviteSubmitter command. This means using the following system message:
moved this report to the [%workspace name%](link to submitter workspace chat) workspace
Actual Result:
The MoveIOUReportToExistingPolicydoesn't use the correct system messages in the 1:1 DM or expense report. We need to update it to accept a new param and generate a moved action to the DM just like CreateWorkspaceFromIOUPayment
Workaround:
N/A
Platforms:
Select the officially supported platforms where the issue was reproduced:
Haven't tested the current behavior, but the behavior when we implemented MoveIOUReportToPolicyAndInviteSubmitter was something like this...
Pre-requisite: a user (not member of any workspace), a workspace with an admin.
[user] Request money (IOU) from admin.
[admin] Open the IOU report and select change workspace (append /change-workspace to the URL in order to open the workspace selector).
[admin] Move the IOU report to the admin's workspace.
Verify that the IOU report was converted to an Expense report and the user was invited to the workspace.
Verify that the user has a workspace chat created for them.
Verify that the report preview was removed from the DM and added to the user's workspace chat.
We will need some frontend PR for both of these changes if @getusha wants to work on that while I look at the BE. Otherwise, we can search for someone else maybe @ikevin127 since he implemented MoveIOUReportToPolicyAndInviteSubmitter and should be familiar with these flows I think 🙏
changed the title [-]Fix system messages with MoveIOUReportToExistingPolicy command[/-][+][Due for payment 2025-08-13] Fix system messages with MoveIOUReportToExistingPolicy command[/+]on Aug 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.89-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@getusha@joekaufmanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The PR #66790 caused #97152. It passed an empty amount for PAY actions, but the ELSEWHERE branch could still use iou.payerSettledWithMissingBankAccount, resulting in "paid . Add a bank account to receive your payment." when copying the "marked as paid" message.
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.marcaaron commentedon May 9, 2025
If I'm understanding this issue correctly we'll want to do something like:
CHANGE_POLICYaction inMoveIOUReportToExistingPolicyMOVEDaction which is added to the DM chat to point the submitter to the new workspace chatMOVEDaction which is added to the expense reportDoes that sound about right?
marcaaron commentedon May 9, 2025
It looks like we should do the same for
MoveIOUReportToPolicyAndInviteSubmitter?marcaaron commentedon May 9, 2025
WDYT @joekaufmanexpensify?
Haven't tested the current behavior, but the behavior when we implemented
MoveIOUReportToPolicyAndInviteSubmitterwas something like this...Pre-requisite: a user (not member of any workspace), a workspace with an admin.
marcaaron commentedon May 9, 2025
We will need some frontend PR for both of these changes if @getusha wants to work on that while I look at the BE. Otherwise, we can search for someone else maybe @ikevin127 since he implemented
MoveIOUReportToPolicyAndInviteSubmitterand should be familiar with these flows I think 🙏72 remaining items
melvin-bot commentedon Aug 5, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Fix system messages with MoveIOUReportToExistingPolicy command[/-][+][Due for payment 2025-08-13] Fix system messages with MoveIOUReportToExistingPolicy command[/+]melvin-bot commentedon Aug 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.89-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 6, 2025
@getusha @joekaufmanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
joekaufmanexpensify commentedon Aug 11, 2025
Frontend PR is out to prod. @getusha @hungvu193 are being paid centrally for the whole project, so no payment needed here. Closing as this is all set!
Krishna2323 commentedon Aug 19, 2026
The PR #66790 caused #97152. It passed an empty
amountfor PAY actions, but theELSEWHEREbranch could still useiou.payerSettledWithMissingBankAccount, resulting in "paid . Add a bank account to receive your payment." when copying the "marked as paid" message.Fixed in #97999.