Repository navigation
Description
Tracking GH: https://github.com/Expensify/Expensify/issues/418655
Design Doc: https://docs.google.com/document/d/1_p8qZXVKG-s32i9GKqVjCLEcEREBUEgYcxk3KYHXMVg/edit?tab=t.0
Admin: Downloading Tags
First, we will not hide the threeDotsMenuItems for multi-level tags, we need to set shouldShowThreeDotsButton={true} for all cases (currently we hide it when tags are multi-level).
- Call new downloadMultiLeveltagsCSV function for multi-level tags
We are not going to support download for Multi-Level Dependent Tags, we need to update the condition for showing the download CSV option along with that we need to create a new Util which will call ExportMultiLevelTagsCSV API endpoint for multi-level tags: \
// We hide the option to download tags in case of dependent tags
if (hasVisibleTags && !hasDependentTags) {
menuItems.push({
icon: Expensicons.Download,
text: translate("spreadsheet.downloadCSV"),
onSelected: () => {
if (isOffline) {
Modal.close(() => setIsOfflineModalVisible(true));
return;
}
Modal.close(() => {
// Here we will check if the policy has multilevel tags
// And will call the appropriate API command
if (policy?.isUsingMultiLevelTags) {
Tag.downloadMultiLeveltagsCSV(policyID, () => {
setIsDownloadFailureModalVisible(true);
});
return;
}
Tag.downloadTagsCSV(policyID, () => {
setIsDownloadFailureModalVisible(true);
});
});
},
});
}
- Create new util to download multi-level independent tags
The downloadMultiLeveltagsCSV steps util will be similar to downloadTagsCSV only difference is we will call ExportMultiLevelTagsCSV endpoint in this case:
The Util downloadMultiLeveltagsCSV endpoint will be as follows: \
function downloadMultiLeveltagsCSV(
policyID: string,
onDownloadFailed: () => void
) {
const finalParameters = enhanceParameters(
WRITE_COMMANDS.EXPORT_MULTI_LEVEL_TAGS_CSV,
{
policyID,
}
);
const fileName = "MultiLevelTags.csv";
const formData = new FormData();
Object.entries(finalParameters).forEach(([key, value]) => {
formData.append(key, String(value));
});
fileDownload(
ApiUtils.getCommandURL({
command: WRITE_COMMANDS.EXPORT_MULTI_LEVEL_TAGS_CSV,
}),
fileName,
"",
false,
formData,
CONST.NETWORK.METHOD.POST,
onDownloadFailed
);
}
The API command EXPORT_MULTI_LEVEL_TAGS_CSV will be implemented according to the backend changes here.
We will rename the command ExportTagsCSV to ExportSingleLevelTagsCSV (More details here)
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021922164703131803558
- Upwork Job ID: 1922164703131803558
- Last Price Increase: 2025-05-13
- Automatic offers:
- allgandalf | Reviewer | 107454938
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @joekaufmanexpensifyMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon May 9, 2025
Triggered auto assignment to @joekaufmanexpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.allgandalf commentedon May 12, 2025
Will start to work on it this week
joekaufmanexpensify commentedon May 12, 2025
Great, thank you!
[-][Multi-tags] Admin - Downloading Tags[/-][+][$250] [Multi-tags] Admin - Downloading Tags[/+]melvin-bot commentedon May 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021922164703131803558
23 remaining items
melvin-bot commentedon May 21, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mananjadhav commentedon May 26, 2025
@yuwenmemon Can you assign this issue to me for the payout? I helped with the PR review.
melvin-bot commentedon May 26, 2025
📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
mananjadhav commentedon May 27, 2025
@yuwenmemon @allgandalf can you confirm if the regression test is added for the issue during the project?
mananjadhav commentedon May 29, 2025
@joekaufmanexpensify Quick bump on the payment summary?
joekaufmanexpensify commentedon May 31, 2025
I was OOO until May 30th. Will handle on Monday!
joekaufmanexpensify commentedon Jun 2, 2025
This issue was linked to a DB , however in the PR fix there it sounds like there was some confusion on the BE command name that should be used, so I don't think there should be a regression penalty here.
joekaufmanexpensify commentedon Jun 2, 2025
@allgandalf I assume you're being paid holistically for this project because I see you worked on the design doc. LMK if that is not correct. Assuming it is, only payment needed in this issue is:
joekaufmanexpensify commentedon Jun 2, 2025
Closing this for now, as we should be all set here!
garrettmknight commentedon Jun 3, 2025
$250 approved for @mananjadhav