Skip to content

[Due for payment 2025-05-27] [Better Expense Report View] Switching from multi to one expense report view is a little wonky with deleted expenses #61775

Closed

Description

@trjExpensify

Coming from here.

Tom: I get the one expense report view when I delete an expense, but not when I delete an expense that has comments in thread.

2025-05-08_17-02-35.mp4

Jakub: I think this is not really related to the deleting expense with comments in general, more related to switching between single transaction report view and normal report view when we delete one of the last two expenses while it has comments, have a look, it switches to the old view:

Screen.Recording.2025-05-09.at.13.09.32.mov

Todos

  • Fix the view @JakubKorytko is working on a PR for this
  • Fix the lingering thread reply count. We're going to need a BE PR for this. CC: @mountiny
Issue OwnerCurrent Issue Owner: @mountiny

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 9, 2025
  2. moved this to Second Cohort - MEDIUM or LOW in [#whatsnext] #migrateon May 9, 2025
  3. melvin-bot commented on May 9, 2025

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  4. 23 remaining items

  5. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon May 28, 2025
  6. mountiny commented on May 28, 2025

    @mountiny
    Contributor

    Ok, well, next time, no presents for you!

    I swear you commented on some PR you need to get a payment handled and I probably mixed up the associated issues. Sorry for confusion

  7. added
    ReviewingHas a PR in review
    and removed on Jun 2, 2025
  8. mountiny commented on Jul 9, 2025

    @mountiny
    Contributor

    @allroundexperts I think I assigned you here for the PR #61777

  9. allroundexperts commented on Jul 9, 2025

    @allroundexperts
    Contributor

    Yes, sorry my bad. Thank you for following up here.

  10. allroundexperts commented on Jul 9, 2025

    @allroundexperts
    Contributor

    Can we have a payment summary here? (Assuming #61775 (comment) is not enough?)

  11. trjExpensify commented on Jul 9, 2025

    @trjExpensify
    ContributorAuthor

    @allroundexperts I think I assigned you here for the PR #61777

    My question still stands...

    Mhm, why isn't @allroundexperts assigned on the PR nor ✅ for approving it? 😕

  12. allroundexperts commented on Jul 9, 2025

    @allroundexperts
    Contributor

    I was assigned for the review on #62275

  13. trjExpensify commented on Jul 9, 2025

    @trjExpensify
    ContributorAuthor

    Lmao, Vit has been at the pub clearly linking the same incorrect PR TWICE.. 😂

    Payment summary as follows:

  14. JmillsExpensify commented on Jul 10, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

  15. mountiny commented on Jul 10, 2025

    @mountiny
    Contributor

    deepest apologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions