Skip to content

[$250] android-You appear offline message is displayed above little blank space #61782

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.29-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/466141
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Xiaomi Redmi Note 10S - Android 13, Reliance Jio, Chrome
App Component: LHN

Action Performed:

  1. Launch app
  2. Go offline
  3. Tap fab - start chat - room
  4. Tap visibility

Expected Result:

You appear offline message must be displayed at the bottom like mweb.

Actual Result:

You appear offline message is displayed above little blank space.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6805279_1744908175506.Screenrecorder-2025-04-17-21-57-20-996.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021921792507271921322
  • Upwork Job ID: 1921792507271921322
  • Last Price Increase: 2025-05-12
Issue OwnerCurrent Issue Owner: @alitoshmatov

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 9, 2025
  2. melvin-bot commented on May 9, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on May 9, 2025

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-05-10 17:40:27 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    You appear offline message is displayed above little blank space

    What is the root cause of that problem?

    The ValueSelectorModal applies default bottom padding for safe areas, while the ScreenWrapper adds extra padding for the offline indicator when includeSafeAreaPaddingBottom creating double padding that pushes the message up.

    What changes do you think we should make in order to solve the problem?

    We should add enableEdgeToEdgeBottomSafeAreaPadding = {false}

    Here

    <ScreenWrapper
    style={styles.pb0}
    includePaddingTop={false}
    includeSafeAreaPaddingBottom
    testID={ValueSelectorModal.displayName}
    shouldEnableKeyboardAvoidingView={shouldEnableKeyboardAvoidingView}
    >

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. kadiealexander commented on May 12, 2025

    @kadiealexander
    Contributor

    Android <> iOS bug swap with @jliexpensify

  5. dubielzyk-expensify commented on May 12, 2025

    @dubielzyk-expensify
    Contributor

    Yeah this looks like a bug to me. No idea why the background is transparent. On the room screen we don't use a fixed button so the only error to me is the transparent background. The positioning does look right. cc @Expensify/design for gut check

  6. linhvovan29546 commented on May 12, 2025

    @linhvovan29546
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    android-You appear offline message is displayed above little blank space

    What is the root cause of that problem?

    We use the ValueSelectorModal component to display the options. This component wraps both a Modal and a ScreenWrapper, each of which adds default bottom padding. This results in extra space at the bottom of the modal.

    <Modal
    type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
    isVisible={isVisible}
    onClose={() => onClose?.()}
    onModalHide={onClose}
    hideModalContentWhileAnimating
    useNativeDriver
    onBackdropPress={onBackdropPress}
    shouldHandleNavigationBack
    >
    <ScreenWrapper
    style={styles.pb0}
    includePaddingTop={false}
    includeSafeAreaPaddingBottom

    style={[styles.defaultModalContainer, modalContainerStyle, modalPaddingStyles, !isVisible && styles.pointerEventsNone]}

    What changes do you think we should make in order to solve the problem?

    We should update the component to handle edge-to-edge layout correctly. This is important because the modal content can extend beyond the screen height, requiring proper bottom padding handling. The CategorySelectorModal component is a good reference for how this should be done.
    Required Changes:

     <Modal
    enableEdgeToEdgeBottomSafeAreaPadding
    ...>
                <ScreenWrapper
                    enableEdgeToEdgeBottomSafeAreaPadding
                    <ValueSelectionList
                    addBottomSafeAreaPadding

    return (
    <SelectionList

            <SelectionList
                addBottomSafeAreaPadding={addBottomSafeAreaPadding}

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    We only need to pass enableEdgeToEdgeBottomSafeAreaPadding to the Modal component

            <Modal
            enableEdgeToEdgeBottomSafeAreaPadding
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 12, 2025
  8. changed the title [-]android-You appear offline message is displayed above little blank space[/-] [+][$250] android-You appear offline message is displayed above little blank space[/+] on May 12, 2025
  9. melvin-bot commented on May 12, 2025

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 12, 2025
  11. 7 remaining items

  12. PiyushChandra17 commented on May 13, 2025

    @PiyushChandra17
    Contributor

    @jliexpensify I think my proposal makes more sense and is more consistent with all the ScreenWrapper props used throughout the app, also it includes the working demo.

  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 13, 2025
  14. jliexpensify commented on May 13, 2025

    @jliexpensify
    Contributor

    Sorry @PiyushChandra17 @samranahm - this one has been assigned already!

  15. chrispader commented on May 13, 2025

    @chrispader
    Contributor

    Basically I can't think of any case where we actually wanted the offline indicator to use a translucent background, so I think we need to make sure we undo all of those changes.

    The translucent offline indicator behavior should already be reverted and also couldn't reproduce it on the new room page.

    The issue with Visibility selection modal is fixed in #61367

  16. melvin-bot commented on May 19, 2025

    @melvin-bot

    @alitoshmatov Huh... This is 4 days overdue. Who can take care of this?

  17. added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    and removed on May 19, 2025
  18. jliexpensify commented on May 19, 2025

    @jliexpensify
    Contributor

    Thanks for the update @chrispader - @nlemma can you retest this one?

  19. nlemma commented on May 20, 2025

    @nlemma
    Author

    Issue is no longer reproducible.

    Screenrecorder-2025-05-20-10-49-24-110.mp4
  20. jliexpensify commented on May 20, 2025

    @jliexpensify
    Contributor

    Awesome, thanks! No payments nreeded here - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions