You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] android-You appear offline message is displayed above little blank space #61782
Version Number: 9.1.29-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://github.com/Expensify/Expensify/issues/466141 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Xiaomi Redmi Note 10S - Android 13, Reliance Jio, Chrome App Component: LHN
Action Performed:
Launch app
Go offline
Tap fab - start chat - room
Tap visibility
Expected Result:
You appear offline message must be displayed at the bottom like mweb.
Actual Result:
You appear offline message is displayed above little blank space.
🚨 Edited by proposal-police: This proposal was edited at 2025-05-10 17:40:27 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
You appear offline message is displayed above little blank space
What is the root cause of that problem?
The ValueSelectorModal applies default bottom padding for safe areas, while the ScreenWrapper adds extra padding for the offline indicator when includeSafeAreaPaddingBottom creating double padding that pushes the message up.
What changes do you think we should make in order to solve the problem?
We should add enableEdgeToEdgeBottomSafeAreaPadding = {false}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Yeah this looks like a bug to me. No idea why the background is transparent. On the room screen we don't use a fixed button so the only error to me is the transparent background. The positioning does look right. cc @Expensify/design for gut check
Please re-state the problem that we are trying to solve in this issue.
android-You appear offline message is displayed above little blank space
What is the root cause of that problem?
We use the ValueSelectorModal component to display the options. This component wraps both a Modal and a ScreenWrapper, each of which adds default bottom padding. This results in extra space at the bottom of the modal.
What changes do you think we should make in order to solve the problem?
We should update the component to handle edge-to-edge layout correctly. This is important because the modal content can extend beyond the screen height, requiring proper bottom padding handling. The CategorySelectorModal component is a good reference for how this should be done.
Required Changes:
Add enableEdgeToEdgeBottomSafeAreaPadding to both Modal and ScreenWrapper:
changed the title [-]android-You appear offline message is displayed above little blank space[/-][+][$250] android-You appear offline message is displayed above little blank space[/+]on May 12, 2025
@jliexpensify I think my proposal makes more sense and is more consistent with all the ScreenWrapper props used throughout the app, also it includes the working demo.
Basically I can't think of any case where we actually wanted the offline indicator to use a translucent background, so I think we need to make sure we undo all of those changes.
The translucent offline indicator behavior should already be reverted and also couldn't reproduce it on the new room page.
The issue with Visibility selection modal is fixed in #61367
Activity
melvin-bot commentedon May 9, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon May 9, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-10 17:40:27 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
You appear offline message is displayed above little blank space
What is the root cause of that problem?
The ValueSelectorModal applies default bottom padding for safe areas, while the ScreenWrapper adds extra padding for the offline indicator when
includeSafeAreaPaddingBottomcreating double padding that pushes the message up.What changes do you think we should make in order to solve the problem?
We should add
enableEdgeToEdgeBottomSafeAreaPadding = {false}Here
App/src/components/ValuePicker/ValueSelectorModal.tsx
Lines 34 to 40 in 3c6789a
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
kadiealexander commentedon May 12, 2025
Android <> iOS bug swap with @jliexpensify
dubielzyk-expensify commentedon May 12, 2025
Yeah this looks like a bug to me. No idea why the background is transparent. On the room screen we don't use a fixed button so the only error to me is the transparent background. The positioning does look right. cc @Expensify/design for gut check
linhvovan29546 commentedon May 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
android-You appear offline message is displayed above little blank space
What is the root cause of that problem?
We use the
ValueSelectorModalcomponent to display the options. This component wraps both aModaland aScreenWrapper, each of which adds default bottom padding. This results in extra space at the bottom of the modal.App/src/components/ValuePicker/ValueSelectorModal.tsx
Lines 24 to 37 in 6feef49
App/src/components/Modal/BaseModal.tsx
Line 312 in 6feef49
What changes do you think we should make in order to solve the problem?
We should update the component to handle edge-to-edge layout correctly. This is important because the modal content can extend beyond the screen height, requiring proper bottom padding handling. The
CategorySelectorModalcomponent is a good reference for how this should be done.Required Changes:
App/src/components/ValuePicker/ValueSelectorModal.tsx
Lines 32 to 34 in 6feef49
App/src/components/ValuePicker/ValueSelectorModal.tsx
Line 45 in 6feef49
App/src/components/ValuePicker/ValueSelectionList.tsx
Lines 12 to 13 in 6feef49
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
We only need to pass
enableEdgeToEdgeBottomSafeAreaPaddingto the Modal componentApp/src/components/ValuePicker/ValueSelectorModal.tsx
Line 24 in 6feef49
[-]android-You appear offline message is displayed above little blank space[/-][+][$250] android-You appear offline message is displayed above little blank space[/+]melvin-bot commentedon May 12, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021921792507271921322
7 remaining items
PiyushChandra17 commentedon May 13, 2025
@jliexpensify I think my proposal makes more sense and is more consistent with all the
ScreenWrapperprops used throughout the app, also it includes the working demo.jliexpensify commentedon May 13, 2025
Sorry @PiyushChandra17 @samranahm - this one has been assigned already!
chrispader commentedon May 13, 2025
The translucent offline indicator behavior should already be reverted and also couldn't reproduce it on the new room page.
The issue with Visibility selection modal is fixed in #61367
melvin-bot commentedon May 19, 2025
@alitoshmatov Huh... This is 4 days overdue. Who can take care of this?
jliexpensify commentedon May 19, 2025
Thanks for the update @chrispader - @nlemma can you retest this one?
nlemma commentedon May 20, 2025
Issue is no longer reproducible.
Screenrecorder-2025-05-20-10-49-24-110.mp4
jliexpensify commentedon May 20, 2025
Awesome, thanks! No payments nreeded here - closing