Skip to content

[Due for payment 2025-07-28] [Due for payment 2025-07-14] [Due for payment 2025-05-27] [$250] Remove getTransaction #61910

Closed

Description

@luacmartins

Problem

It breaks the reactivity of the application because the method itself is not subscribed to Onyx changes. So when a page uses the method to display information about the transaction, e.g. here and the transaction changes, the view is not updated with that change.

Solution

Remove getTransaction and pass transaction as argument instead

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. self-assigned this
    on May 13, 2025
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 13, 2025
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 13, 2025
  4. melvin-bot commented on May 13, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    ReviewingHas a PR in review
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 13, 2025
  6. melvin-bot commented on May 13, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. 74 remaining items

  8. zanyrenney commented on Aug 1, 2025

    @zanyrenney
    Contributor

    Looks like neither of you applied to the upwork job as asked here: #61910 (comment)

    I'll recreate the job, please apply in future in a timely fashion since recreating these adds a delay.

  9. zanyrenney commented on Aug 1, 2025

    @zanyrenney
    Contributor

    have reinivited you both manually.

  10. FitseTLT commented on Aug 1, 2025

    @FitseTLT
    Contributor

    @zanyrenney I have submitted the proposal 👍

  11. dominictb commented on Aug 6, 2025

    @dominictb
    Contributor

    @zanyrenney I applied to that job too, thank you 🙇

  12. zanyrenney commented on Aug 8, 2025

    @zanyrenney
    Contributor

    Thanks both!

  13. zanyrenney commented on Aug 8, 2025

    @zanyrenney
    Contributor

    offers sent for both @FitseTLT @dominictb please accept for payout.

  14. FitseTLT commented on Aug 8, 2025

    @FitseTLT
    Contributor

    @zanyrenney Accepted

  15. zanyrenney commented on Aug 8, 2025

    @zanyrenney
    Contributor
  16. FitseTLT commented on Aug 15, 2025

    @FitseTLT
    Contributor

    @zanyrenney Can you pls pay here? Thx

  17. zanyrenney commented on Aug 18, 2025

    @zanyrenney
    Contributor

    Payment summary

    $250 paid to @FitseTLT via upwork.
    $250 paid to @dominictb via upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions