Skip to content

[Due for payment 2025-05-27] [Report Creation UI] Expense - Skeleton loader displayed when adding expense to report via "Add Expense" button. #61987

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.45-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+725@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

  1. Open the Expensify app.
  2. Log in with a Gmail account.
  3. Open any workspace chat.
  4. Submit an expense to chat.
  5. Open the report of the just submitted expense.
  6. Tap on "More" and select "Add Expense"
  7. Tap on "Create new expense"
  8. Complete the creation flow,
  9. Once redirected to report again, note that a skeleton loader is displayed for a few seconds before the expense appears.
  10. Tap on the "+" button on the report.
  11. Tap on "Create Expense"
  12. Complete the creation flow.
  13. Once redirected to report, note that in this case, skeleton loader is not displayed when expense appears.

Expected Result:

When adding an expense to a report via the "Add Expense" button, skeleton loader shouldn´t be displayed before expense appears.

Actual Result:

When adding an expense to a report via the "Add Expense" button (Step 9), skeleton loader is displayed for a few seconds before the new expense appears. This loader is not displayed if the expense is added via the "+" button on the report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @NicMendonca

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 14, 2025
  2. github-actions commented on May 14, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on May 14, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on May 14, 2025

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on May 14, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. 9 remaining items

  7. trjExpensify commented on May 14, 2025

    @trjExpensify
    Contributor

    Demoting after the CP

  8. SzymczakJ commented on May 15, 2025

    @SzymczakJ
    Contributor

    I think we can close this, the button that was causing this regression is behind beta and it doesn't cause any regression with the new beta components:

    Screen.Recording.2025-05-15.at.10.36.53.mov

    I also checked case with no beta permissions and it's bug-free:

    Screen.Recording.2025-05-15.at.10.42.36.mov
  9. trjExpensify commented on May 15, 2025

    @trjExpensify
    Contributor

    Works for me!

  10. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon May 15, 2025
  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 20, 2025
  12. changed the title [-][Report Creation UI] Expense - Skeleton loader displayed when adding expense to report via "Add Expense" button.[/-] [+][Due for payment 2025-05-27] [Report Creation UI] Expense - Skeleton loader displayed when adding expense to report via "Add Expense" button.[/+] on May 20, 2025
  13. melvin-bot commented on May 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-27. 🎊

    For reference, here are some details about the assignees on this issue:

    • @SzymczakJ does not require payment (Contractor)
  15. melvin-bot commented on May 20, 2025

    @melvin-bot

    @MariaHCD @NicMendonca @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions