You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-11] [$125] [Report Creation UI] Expense - After adding track expense to workspace report, actionable whisper is still present #61998
Version Number: 9.1.45-6 Reproducible in staging?: Yes Reproducible in production?: Unable to check, new feature If this was caught during regression testing, add the test name, ID and link from TestRail:#61760 Email or phone of affected tester (no customers):sndiuhdisssd@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Account has self DM and a workspace.
Go to staging.new.expensify.com
Go to self DM.
Track a manual expense in self DM. Do not dismiss the actionable whisper.
Go to workspace chat.
Submit an expense.
Click on the expense preview.
Click More.
Click Add expense > Add unreported expense.
Select the track expense from Step 3.
Click Add to report.
Go back to self DM.
Expected Result:
Actionable whisper will no longer appear because the track expense is moved to a workspace expense and no longer in self DM.
Actual Result:
Actionable whisper is still present when the track expense is no longer in self DM.
When trying to submit the track expense via actionable whisper, it is stuck at the confirmation page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
With this PR(#62004) this button will be hidden behind a beta, so I think we can demote this deploy blocker and me or @sumo-slonik will work on the fix. cc @mountiny@luacmartins
changed the title [-]Expense - After adding track expense to workspace report, actionable whisper is still present[/-][+][Report Creation UI] Expense - After adding track expense to workspace report, actionable whisper is still present[/+]on May 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@mallenexpensify@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, the whisper case didn't exist until we added the ability to add unreported expenses, but the delete condition was added ~3 years back, so no offending PR here.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Create a track expense in the selfDM
Create a new workspace and create an expense in the WS chat
Open expense report > More button > Add expense > Unreported expense
Selected the track expense above
Verify that the action whisper disappears from the selfDM after the track expense is added to the WS
Activity
melvin-bot commentedon May 14, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 14, 2025
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 14, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 14, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
SzymczakJ commentedon May 14, 2025
With this PR(#62004) this button will be hidden behind a beta, so I think we can demote this deploy blocker and me or @sumo-slonik will work on the fix. cc @mountiny @luacmartins
[-]Expense - After adding track expense to workspace report, actionable whisper is still present[/-][+][Report Creation UI] Expense - After adding track expense to workspace report, actionable whisper is still present[/+]51 remaining items
melvin-bot commentedon Jun 4, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 4, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 4, 2025
@allgandalf @mallenexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny commentedon Jun 5, 2025
@allgandalf 🇨🇿 list please
allgandalf commentedon Jun 9, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, the whisper case didn't exist until we added the ability to add
unreported expenses, but the delete condition was added ~3 years back, so no offending PR here.[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify that the action whisper disappears from the selfDM after the track expense is added to the WS
Do we agree 👍 or 👎
Add safer access of message html property in isDeletedAction
mallenexpensify commentedon Jun 14, 2025
Contributor: @nkdengineer paid $125 via Upwork
Contributor+: @allgandalf paid $125 via Upwork
Test case
Thx!