Skip to content

[Due for payment 2025-06-11] [$125] [Report Creation UI] Expense - After adding track expense to workspace report, actionable whisper is still present #61998

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.45-6
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #61760
Email or phone of affected tester (no customers): sndiuhdisssd@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has self DM and a workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a manual expense in self DM. Do not dismiss the actionable whisper.
  4. Go to workspace chat.
  5. Submit an expense.
  6. Click on the expense preview.
  7. Click More.
  8. Click Add expense > Add unreported expense.
  9. Select the track expense from Step 3.
  10. Click Add to report.
  11. Go back to self DM.

Expected Result:

Actionable whisper will no longer appear because the track expense is moved to a workspace expense and no longer in self DM.

Actual Result:

Actionable whisper is still present when the track expense is no longer in self DM.
When trying to submit the track expense via actionable whisper, it is stuck at the confirmation page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021927834364028511748
  • Upwork Job ID: 1927834364028511748
  • Last Price Increase: 2025-05-28
  • Automatic offers:
    • allgandalf | Reviewer | 107488255
    • nkdengineer | Contributor | 107488256
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 14, 2025
  2. melvin-bot commented on May 14, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 14, 2025

    @melvin-bot

    Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 14, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 14, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. SzymczakJ commented on May 14, 2025

    @SzymczakJ
    Contributor

    With this PR(#62004) this button will be hidden behind a beta, so I think we can demote this deploy blocker and me or @sumo-slonik will work on the fix. cc @mountiny @luacmartins

  7. changed the title [-]Expense - After adding track expense to workspace report, actionable whisper is still present[/-] [+][Report Creation UI] Expense - After adding track expense to workspace report, actionable whisper is still present[/+] on May 14, 2025
  8. 51 remaining items

  9. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-11. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Jun 4, 2025

    @melvin-bot

    @allgandalf @mallenexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. mountiny commented on Jun 5, 2025

    @mountiny
    Contributor

    @allgandalf 🇨🇿 list please

  13. allgandalf commented on Jun 9, 2025

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A, the whisper case didn't exist until we added the ability to add unreported expenses, but the delete condition was added ~3 years back, so no offending PR here.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Create a track expense in the selfDM
    2. Create a new workspace and create an expense in the WS chat
    3. Open expense report > More button > Add expense > Unreported expense
    4. Selected the track expense above

    Verify that the action whisper disappears from the selfDM after the track expense is added to the WS

    Do we agree 👍 or 👎

  14. mallenexpensify commented on Jun 14, 2025

    @mallenexpensify
    Contributor

    Contributor: @nkdengineer paid $125 via Upwork
    Contributor+: @allgandalf paid $125 via Upwork

    Test case

    Thx!

  15. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions