You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-05] [$250] mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro #62015
Version Number: v9.1.45-6 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#61481 Email or phone of affected tester (no customers):applausetester+en@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Apple iPhone 15 Pro - iOS 18 App Component: Workspace Settings
Action Performed:
Access staging.new.expensify.com
Sign into a valid user
Go to Account > WS > WS overview > Edit Photo
Choose any option in edit photo then on the Edit Photo page, go Offline
Expected Result:
User expects the offline message to not influence the UI
Actual Result:
Offline message causes the UI to shift up and cause extreme overlapping
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
What changes do you think we should make in order to solve the problem?
On relativeHeight change to height - 40 which 40 is the slider height (we can adjust this value later if needed) to make the image container size responsive and include the slider size on the calculation
changed the title [-]mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro[/-][+][$250] mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro[/+]on May 14, 2025
@NicMendonca I am OOO next week, back 9 June. can you please ensure this gets paid once the checklist is filled out and that any regression tests are added to testrail, thanks
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Go to Account > WS > WS overview > Edit Photo
Choose any option in edit photo, then on the Edit Photo page, go Offline
Verify that the button does not overlap the image slider
Activity
melvin-bot commentedon May 14, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thelullabyy commentedon May 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Offline message causes the UI to shift up and cause extreme overlapping
What is the root cause of that problem?
The ads and the offline indicator takes up height space making Profile Editor View not have enough space
What changes do you think we should make in order to solve the problem?
Wrap body with the ScrollView allow scroll when lack of space
App/src/components/AvatarCropModal/AvatarCropModal.tsx
Line 369 in c45e5b3
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nyomanjyotisa commentedon May 14, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro
What is the root cause of that problem?
We don't include the slider height on the image container size calculation here
App/src/components/AvatarCropModal/AvatarCropModal.tsx
Lines 84 to 91 in c45e5b3
What changes do you think we should make in order to solve the problem?
On
relativeHeightchange toheight - 40which 40 is the slider height (we can adjust this value later if needed) to make the image container size responsive and include the slider size on the calculationRESULT
New-Expensify.1.online-video-cutter.com.mp4
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
[-]mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro[/-][+][$250] mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro[/+]melvin-bot commentedon May 14, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021922640389828029912
melvin-bot commentedon May 14, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)shubham1206agra commentedon May 15, 2025
@nyomanjyotisa's proposal looks good to me.
🎀👀🎀 C+ reviewed
30 remaining items
laurenreidexpensify commentedon May 30, 2025
@NicMendonca I am OOO next week, back 9 June. can you please ensure this gets paid once the checklist is filled out and that any regression tests are added to testrail, thanks
NicMendonca commentedon Jun 5, 2025
Payment summary
Contributor+: @shubham1206agra - $250 via NewDot Manual Requests
Contributor: @nyomanjyotisa - $250 paid via Upwork (done ✅ )
NicMendonca commentedon Jun 5, 2025
@shubham1206agra bump on the BZ checklist so we can close this out. Thank you!
shubham1206agra commentedon Jun 5, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/17347/files#r2129270250
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
NicMendonca commentedon Jun 6, 2025
Payment summary
Contributor+: @shubham1206agra - $250 via NewDot Manual Requests
Contributor: @nyomanjyotisa - $250 paid via Upwork (done ✅ )
garrettmknight commentedon Jun 19, 2025
$250 approved for @shubham1206agra