Skip to content

[Due for payment 2025-06-05] [$250] mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro #62015

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.45-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #61481
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Apple iPhone 15 Pro - iOS 18
App Component: Workspace Settings

Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid user
  3. Go to Account > WS > WS overview > Edit Photo
  4. Choose any option in edit photo then on the Edit Photo page, go Offline

Expected Result:

User expects the offline message to not influence the UI

Actual Result:

Offline message causes the UI to shift up and cause extreme overlapping

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6830629_1747208704540.Overlapping_when_going_offline.mp4

Image

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021922640389828029912
  • Upwork Job ID: 1922640389828029912
  • Last Price Increase: 2025-05-14
  • Automatic offers:
    • nyomanjyotisa | Contributor | 107382592
Issue OwnerCurrent Issue Owner: @shubham1206agra

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 14, 2025
  2. melvin-bot commented on May 14, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. thelullabyy commented on May 14, 2025

    @thelullabyy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Offline message causes the UI to shift up and cause extreme overlapping

    What is the root cause of that problem?

    The ads and the offline indicator takes up height space making Profile Editor View not have enough space

    What changes do you think we should make in order to solve the problem?

    Wrap body with the ScrollView allow scroll when lack of space

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. nyomanjyotisa commented on May 14, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro

    What is the root cause of that problem?

    We don't include the slider height on the image container size calculation here

    const initializeImageContainer = useCallback((event: LayoutChangeEvent) => {
    setIsImageContainerInitialized(true);
    const {height, width} = event.nativeEvent.layout;
    // Even if the browser height is reduced too much, the relative height should not be negative
    const relativeHeight = Math.max(height, CONST.AVATAR_CROP_MODAL.INITIAL_SIZE);
    setImageContainerSize(Math.floor(Math.min(relativeHeight, width)));
    }, []);

    What changes do you think we should make in order to solve the problem?

    On relativeHeight change to height - 40 which 40 is the slider height (we can adjust this value later if needed) to make the image container size responsive and include the slider size on the calculation

    const relativeHeight = Math.max(height - 40, CONST.AVATAR_CROP_MODAL.INITIAL_SIZE);
    

    RESULT

    New-Expensify.1.online-video-cutter.com.mp4

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  5. changed the title [-]mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro[/-] [+][$250] mWeb - Going "Offline" causes overlapping in WS Profile Editor on iPhone 15 Pro[/+] on May 14, 2025
  6. melvin-bot commented on May 14, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 14, 2025
  8. melvin-bot commented on May 14, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  9. shubham1206agra commented on May 15, 2025

    @shubham1206agra
    Contributor

    @nyomanjyotisa's proposal looks good to me.

    🎀👀🎀 C+ reviewed

  10. 30 remaining items

  11. laurenreidexpensify commented on May 30, 2025

    @laurenreidexpensify
    Contributor

    @NicMendonca I am OOO next week, back 9 June. can you please ensure this gets paid once the checklist is filled out and that any regression tests are added to testrail, thanks

  12. NicMendonca commented on Jun 5, 2025

    @NicMendonca
    Contributor

    Payment summary

    Contributor+: @shubham1206agra - $250 via NewDot Manual Requests
    Contributor: @nyomanjyotisa - $250 paid via Upwork (done ✅ )

  13. NicMendonca commented on Jun 5, 2025

    @NicMendonca
    Contributor

    @shubham1206agra bump on the BZ checklist so we can close this out. Thank you!

  14. shubham1206agra commented on Jun 5, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/17347/files#r2129270250

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Go to Account > WS > WS overview > Edit Photo
    2. Choose any option in edit photo, then on the Edit Photo page, go Offline
    3. Verify that the button does not overlap the image slider

    Do we agree 👍 or 👎

  15. NicMendonca commented on Jun 6, 2025

    @NicMendonca
    Contributor

    Payment summary

    Contributor+: @shubham1206agra - $250 via NewDot Manual Requests
    Contributor: @nyomanjyotisa - $250 paid via Upwork (done ✅ )

  16. garrettmknight commented on Jun 19, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions